0

Migrate NOTREACHED_NORETURN -> NOTREACHED

NOTREACHED() has turned [[noreturn]] so the former macro isn't needed
anymore.

This does not attempt to do a rewrite of any surrounding code, like:

if (!foo) {
  NOTREACHED();
}

to CHECK(foo);

Those transforms take a non-trivial amount of time (and there are
thousands of instances). Cleanup can be left as an exercise for the
reader.

NO_IFTTT=No-op-rename migration.

Bug: 40580068
Change-Id: I068c5fdce9dc4c352d8bdd62bb3cd2c0a2d59659
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5782602
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Owners-Override: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1342096}
This commit is contained in:
Peter Boström
2024-08-15 02:39:49 +00:00
committed by Chromium LUCI CQ
parent cc7de17279
commit 01ab59ae08
1259 changed files with 2336 additions and 2407 deletions
android_webview
ash
accelerators
ambient
app_list
assistant
birch
capture_mode
clipboard
components
events
game_dashboard
glanceables
picker
public
quick_pair
rounded_display
scalable_iph
system
user_education
webui
wm
base/android
cc
chrome
browser
accessibility
ai
apps
app_service
publishers
link_capturing
platform_apps
ash
autofill
banners
bookmarks
browsing_data
chromeos
device_notifications
device_reauth
digital_credentials
download
enterprise
extensions
feedback
first_party_sets
hid
ip_protection
keyboard_accessory
lacros
mac
media
metrics
os_crypt
page_load_metrics
password_manager
performance_manager
policy
predictors
lcp_critical_path_predictor
preloading
printing
privacy_sandbox
profiles
promos
safe_browsing
safety_hub
screen_ai
sharesheet
shell_integration_linux.cc
signin
storage_access_api
supervised_user
sync
ui
ash
autofill
browser_navigator_iwa_browsertest.cc
content_settings
download
extensions
file_system_access
layout_constants.ccmanaged_ui.cc
passwords
serial
signin
tab_sharing
tabs
views
accelerator_table.cc
apps
autofill
bookmarks
browser_commands_views.cccertificate_selector.ccchrome_layout_provider.ccconstrained_web_dialog_delegate_views.cccontent_setting_bubble_contents.cccrypto_module_password_dialog_view.cc
desktop_capture
download
extensions
flying_indicator.cc
frame
global_media_controls
intent_picker_bubble_view.cc
location_bar
mahi
media_preview
media_router
message_box_dialog.cc
notifications
overlay
page_info
passwords
payments
performance_controls
permissions
platform_keys_certificate_selector_chromeos.cc
plugin_vm
privacy_sandbox
profiles
promos
renderer_context_menu
safe_browsing
select_file_dialog_extension.cc
send_tab_to_self
site_data
status_icons
supervised_user
tabs
toolbar
translate
user_education
web_apps
webauthn
web_applications
webauthn
webui
usb
user_education
vr
web_applications
webauthn
common
renderer
services
test
chromecast
chromeos
components
access_code_cast
android_autofill
app_launch_prefetch
attribution_reporting
autofill
bookmarks
browsing_data
browsing_topics
commerce
component_updater
content_settings
data_sharing
download
error_page
exo
global_media_controls
gwp_asan
client
lightweight_detector
heap_profiling
history
invalidation
ip_protection
metrics
omnibox
optimization_guide
os_crypt
ownership
page_load_metrics
password_manager
payments
pdf
performance_manager
permissions
plus_addresses
policy
power_metrics
prefs
printing
privacy_sandbox
qr_code_generator
reading_list
reporting
storage
safe_browsing
services
sharing_message
signin
speech
supervised_user
sync
sync_bookmarks
sync_device_info
sync_preferences
tpcd
trusted_vault
unexportable_keys
unified_consent
user_education
viz
web_package
webauthn
content
browser
accessibility
aggregation_service
attribution_reporting
buckets
devtools
fenced_frame
file_system_access
first_party_sets
generic_sensor
gpu
indexed_db
interest_group
loader
media
navigation_transitions
network
preloading
private_aggregation
renderer_host
service_worker
shared_storage
usb
webid
worker_host
common
public
renderer
shell
test
utility
web_test
device
extensions
fuchsia_web/webengine/renderer
gin
google_apis
gpu
ios
chrome
app
application_delegate
browser
autofill
bookmarks
credential_provider
default_browser
default_promo
home_customization
ntp
overlays
passwords
providers
segmentation_platform
sessions
settings
model
sync
shared
signin
supervised_user
tips_notifications
ui
authentication
content_suggestions
menu
popup_menu
reading_list
recent_tabs
settings
tab_switcher
unit_conversion
upgrade
web
common
open_extension
test
providers
web
media
audio
base
capture
cast
cdm
filters
formats
fuchsia
gpu
learning
midi
mojo
parsers
renderers
video
mojo
net
pdf
printing/backend
services
skia/public/mojom
sql
styleguide/c++
testing/rust_gtest_interop
third_party/blink
common
public
renderer
bindings
core
extensions
chromeos
webview
modules
platform
ui
accessibility
base
color
display
events
gfx
gl
native_theme
ozone
shell_dialogs
touch_selection
views
url

@ -143,9 +143,9 @@ std::optional<std::string> DoSerialize(base::ValueView value,
// Failed to serialize prefs file. Backup the existing prefs file and
// crash.
BackupPrefsFile(path);
NOTREACHED_NORETURN() << "Failed to serialize preferences : " << path
<< "\nBacked up under "
<< path.ReplaceExtension(kBadExtension);
NOTREACHED() << "Failed to serialize preferences : " << path
<< "\nBacked up under "
<< path.ReplaceExtension(kBadExtension);
}
return output;
}