Migrate NOTREACHED_NORETURN -> NOTREACHED
NOTREACHED() has turned [[noreturn]] so the former macro isn't needed anymore. This does not attempt to do a rewrite of any surrounding code, like: if (!foo) { NOTREACHED(); } to CHECK(foo); Those transforms take a non-trivial amount of time (and there are thousands of instances). Cleanup can be left as an exercise for the reader. NO_IFTTT=No-op-rename migration. Bug: 40580068 Change-Id: I068c5fdce9dc4c352d8bdd62bb3cd2c0a2d59659 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5782602 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Owners-Override: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/main@{#1342096}
This commit is contained in:

committed by
Chromium LUCI CQ

parent
cc7de17279
commit
01ab59ae08
android_webview
browser
js_sandbox
service
ash
accelerators
ambient
app_list
assistant
ui
main_stage
birch
capture_mode
clipboard
clipboard_history_controller_unittest.ccclipboard_history_item.ccclipboard_history_item_unittest.ccclipboard_history_util.ccclipboard_nudge_controller.cc
views
components
events
game_dashboard
glanceables
picker
public
quick_pair
fast_pair_handshake
rounded_display
scalable_iph
system
focus_mode
input_device_settings
mahi
network
notification_center
power
privacy_hub
user_education
welcome_tour
webui
camera_app_ui
files_internals
print_preview_cros
backend
projector_app
wm
base/android
cc
animation
input
paint
trees
chrome
browser
accessibility
ai
apps
app_service
publishers
link_capturing
platform_apps
api
sync_file_system
ash
app_list
app_mode
borealis
calendar
crosapi
events
file_system_provider
fileapi
diversion_backend_delegate.ccdiversion_backend_delegate_unittest.ccdiversion_file_manager_unittest.cc
input_method
login
policy
core
dlp
enrollment
remote_commands
reporting
event_based_logs
metrics_reporting
skyvault
privacy_hub
scalable_iph
scanning
system_logs
autofill
banners
bookmarks
android
browsing_data
chromeos
extensions
telemetry
device_notifications
device_connection_tracker.ccdevice_pinned_notification_renderer.ccdevice_status_icon_renderer.ccdevice_status_icon_unittest.ccdevice_system_tray_icon_unittest.cc
device_reauth
digital_credentials
download
enterprise
extensions
api
autofill_private
developer_private
passwords_private
scripting
feedback
first_party_sets
hid
ip_protection
keyboard_accessory
android
lacros
mac
media
capture_access_handler_base.ccencrypted_media_supported_types_browsertest.cc
router
discovery
access_code
dial
mdns
providers
webrtc
capture_policy_utils.ccconditional_focus_browsertest.ccdesktop_capture_access_handler.ccdisplay_media_access_handler.ccmedia_stream_capture_indicator.ccnative_desktop_media_list.ccsub_capture_browsertest.ccsystem_media_capture_permissions_mac.mmthumbnail_capturer.ccthumbnail_capturer_mac.mmwebrtc_event_log_manager_common.ccwebrtc_event_log_manager_unittest_helpers.ccwebrtc_getdisplaymedia_browsertest.ccwebrtc_text_log_handler.cc
metrics
usage_scenario
os_crypt
page_load_metrics
password_manager
android
performance_manager
policy
predictors
lcp_critical_path_predictor
preloading
printing
pdf_nup_converter_client_browsertest.ccprint_backend_service_manager.ccprint_browsertest.ccprinter_query.cc
web_api
privacy_sandbox
profiles
promos
safe_browsing
download_protection
safety_hub
android
screen_ai
optical_character_recognizer_browsertest.ccscreen_ai_dlc_installer.ccscreen_ai_service_router_browsertest.cc
sharesheet
shell_integration_linux.ccsignin
bound_session_credentials
dice_web_signin_interceptor.ccstorage_access_api
supervised_user
chromeos
classify_url_navigation_throttle.ccdesktop
linux_mac_windows
supervised_user_extensions_metrics_recorder.ccsupervised_user_navigation_throttle_browsertest.ccsupervised_user_verification_page.ccsync
ui
ash
autofill
autofill_context_menu_manager.ccautofill_context_menu_manager_browsertest.ccautofill_popup_controller_impl.ccchrome_autofill_client.cc
browser_navigator_iwa_browsertest.ccpayments
content_settings
download
extensions
file_system_access
layout_constants.ccmanaged_ui.ccpasswords
bubble_controllers
serial
signin
tab_sharing
tabs
views
accelerator_table.cc
apps
autofill
autofill_bubble_handler_impl.cc
payments
autofill_progress_dialog_views_browsertest.cccard_unmask_authentication_selection_dialog_view.cciban_bubble_view_uitest.ccoffer_notification_bubble_views.ccoffer_notification_bubble_views_interactive_uitest.ccoffer_notification_bubble_views_test_base.ccpayments_window_user_consent_dialog_view.ccvirtual_card_enroll_bubble_views_interactive_uitest.ccwebauthn_dialog_view.cc
popup
update_address_profile_view.ccbookmarks
browser_commands_views.cccertificate_selector.ccchrome_layout_provider.ccconstrained_web_dialog_delegate_views.cccontent_setting_bubble_contents.cccrypto_module_password_dialog_view.ccdesktop_capture
desktop_media_delegated_source_list_view.ccdesktop_media_pane_view.ccdesktop_media_permission_pane_view_mac.mmdesktop_media_picker_views.ccdesktop_media_picker_views_unittest.ccdesktop_media_tab_list.cc
download
extensions
extension_install_friction_dialog_view.ccextensions_menu_button.ccextensions_menu_site_permissions_page_view.ccextensions_menu_view_controller.ccextensions_toolbar_container_interactive_uitest.cc
flying_indicator.ccframe
browser_frame_mac.mmbrowser_frame_view_layout_linux_native.ccbrowser_frame_view_layout_linux_native_unittest.ccbrowser_frame_view_linux_native.ccbrowser_non_client_frame_view.ccimmersive_mode_controller_chromeos.ccimmersive_mode_controller_stub.ccopaque_browser_frame_view.ccopaque_browser_frame_view_layout.ccwindows_caption_button.cc
global_media_controls
intent_picker_bubble_view.cclocation_bar
mahi
media_preview
media_router
message_box_dialog.ccnotifications
overlay
page_info
page_info_cookies_content_view.ccpage_info_main_view.ccpage_info_view_factory.ccsafety_tip_page_info_bubble_view_browsertest.ccsecurity_information_view.cc
passwords
payments
contact_info_editor_view_controller.ccshipping_address_editor_view_controller.ccshipping_option_view_controller.ccvalidation_delegate.cc
performance_controls
permissions
platform_keys_certificate_selector_chromeos.ccplugin_vm
privacy_sandbox
profiles
badged_profile_photo.ccdice_web_signin_interception_bubble_view.ccfirst_run_flow_controller_lacros.ccfirst_run_interactive_uitest.ccmanaged_user_profile_notice_ui_browsertest.ccprofile_management_step_controller.ccprofile_menu_coordinator.ccprofile_menu_view.ccprofile_picker_feature_promo_controller.ccprofile_picker_flow_controller.ccprofile_picker_interactive_uitest_base.ccprofile_picker_turn_sync_on_delegate.ccprofile_picker_view.ccprofile_picker_view_test_utils.ccsignin_view_controller_delegate_views.ccsync_confirmation_ui_browsertest.cc
promos
renderer_context_menu
safe_browsing
select_file_dialog_extension.ccsend_tab_to_self
site_data
status_icons
supervised_user
tabs
alert_indicator_button.cccompound_tab_container.cctab_drag_controller.cctab_drag_controller_interactive_uitest.cctab_strip.cctab_strip_scroll_session.cctab_strip_scrolling_overflow_indicator_strategy.cc
toolbar
translate
user_education
web_apps
webauthn
web_applications
webauthn
webui
ash
print_preview
settings
signin
whats_new
usb
user_education
vr
web_applications
commands
isolated_web_apps
web_app_sync_bridge_unittest.ccwebauthn
common
renderer
accessibility
services
media_gallery_util
sharing
nearby
test
base
ash
interactive
interaction
supervised_user
chromecast
chromeos
ash
components
drivefs
early_prefs
nearby
presence
network
osauth
telemetry_extension
common
diagnostics
events
routines
telemetry
tether
services
ui
clipboard_history
components
access_code_cast
android_autofill
browser
app_launch_prefetch
attribution_reporting
autofill
content
browser
renderer
core
browser
address_data_cleaner.ccaddress_suggestion_generator.ccautofill_address_util.ccautofill_external_delegate.ccautofill_granular_filling_utils.ccautofill_optimization_guide.ccbrowser_autofill_manager.ccbrowser_autofill_manager_unittest.cc
crowdsourcing
data_model
field_type_utils.ccfield_types.ccfilling_product.ccform_filler.ccform_structure_rationalization_engine.ccform_types.ccheuristic_source.ccmetrics
autofill_in_devtools_metrics.ccautofill_metrics.ccgranular_filling_metrics.ccmanual_fallback_metrics.cc
payments
suggestions_list_metrics.ccpayments
autofill_save_card_ui_info.cccredit_card_access_manager.ccmandatory_reauth_manager.cc
payments_suggestion_generator.ccpayments_suggestion_generator_unittest.ccpayments_requests
virtual_card_enroll_metrics_logger.ccui
webdata
common
bookmarks
browsing_data
content
browsing_topics
commerce
component_updater
installer_policies
content_settings
browser
data_sharing
internal
download
public
common
error_page
common
exo
global_media_controls
public
gwp_asan
client
lightweight_detector
heap_profiling
in_process
history
core
browser
invalidation
ip_protection
android
common
metrics
demographics
omnibox
optimization_guide
core
model_execution
os_crypt
async
ownership
page_load_metrics
browser
password_manager
core
browser
features
leak_detection
password_counter.ccpassword_form_metrics_recorder.ccpassword_manager_util.ccpassword_manual_fallback_flow.ccpassword_store
store_metrics_reporter.ccui
votes_uploader.ccpayments
core
pdf
renderer
performance_manager
decorators
execution_context
graph
metrics
performance_manager_impl.ccresource_attribution
service_worker_context_adapter.ccv8_memory
worker_watcher.ccpermissions
plus_addresses
metrics
plus_address_http_client_impl_unittest.ccplus_address_jit_allocator.ccplus_address_service.ccpolicy
core
common
cloud
remote_commands
test_support
power_metrics
prefs
printing
renderer
privacy_sandbox
qr_code_generator
reading_list
reporting
storage
safe_browsing
content
core
services
sharing_message
signin
internal
identity_manager
public
speech
supervised_user
core
sync
engine
model
nigori
protocol
service
sync_bookmarks
sync_device_info
sync_preferences
tpcd
metadata
trusted_vault
recovery_key_store_connection_impl.ccstandalone_trusted_vault_client.cc
test
trusted_vault_histograms.cctrusted_vault_service.ccunexportable_keys
unified_consent
user_education
viz
common
service
display
display_embedder
frame_sinks
layers
test
web_package
signed_web_bundles
test_support
signed_web_bundles
webauthn
content
browser
accessibility
browser_accessibility.ccbrowser_accessibility_manager.ccbrowser_accessibility_manager_mac.mmbrowser_accessibility_manager_win.cc
aggregation_service
attribution_reporting
attribution_data_host_manager_impl.ccattribution_internals_handler_impl.ccattribution_manager_impl.ccattribution_resolver_delegate.cccreate_report_result.ccrate_limit_table.cc
test
buckets
devtools
fenced_frame
file_system_access
file_path_watcher
first_party_sets
generic_sensor
gpu
indexed_db
interest_group
auction_shared_storage_host.ccbidding_and_auction_server_key_fetcher_unittest.ccinterest_group_pa_report_util.ccinterest_group_real_time_report_util.cc
loader
cached_navigation_url_loader.cckeep_alive_url_loader.ccnavigation_early_hints_manager.ccurl_loader_factory_utils.cc
media
active_media_session_controller.cc
android
capture
captured_surface_controller_unittest.ccmedia_capabilities_browsertest.ccmedia_keys_listener_manager_impl.ccnavigation_transitions
network
preloading
private_aggregation
renderer_host
media
fuchsia_media_codec_provider_impl.ccin_process_video_capture_device_launcher.ccmedia_stream_manager_unittest.ccmedia_stream_metrics.cc
navigation_request.ccnavigation_transitions
render_widget_host_view_base.ccservice_worker
service_worker_cache_storage_matcher.ccservice_worker_client.ccservice_worker_main_resource_loader.ccservice_worker_version.cc
shared_storage
usb
webid
worker_host
common
public
browser
test
renderer
accessibility
font_data
media
batching_media_log.ccrender_media_client.ccrenderer_web_media_player_delegate.ccrenderer_webaudiodevice_impl.cc
service_worker
shell
browser
bluetooth
test
fuzzer
utility
web_test
device
bluetooth
fido
vr
extensions
browser
api
automation_internal
bluetooth
cec_private
user_scripts
virtual_keyboard_private
content_verifier
embedder_user_script_loader.ccscripting_utils.ccservice_worker
common
renderer
fuchsia_web/webengine/renderer
gin
google_apis
calendar
classroom
tasks
gpu
command_buffer
service
gles2_cmd_decoder_passthrough_doers.ccraster_decoder.ccshared_context_state.cc
shared_image
dcomp_image_backing_factory.ccdcomp_surface_image_backing.ccdcomp_surface_image_representation.ccdxgi_swap_chain_image_backing.ccdxgi_swap_chain_image_representation.ccegl_image_backing_factory.ccgl_texture_holder.ccgl_texture_image_backing_factory.cciosurface_image_backing.mmraw_draw_image_backing_factory.ccshared_image_backing.ccshared_image_format_service_utils.ccshared_image_format_service_utils_mac.mmwrapped_sk_image_backing_factory.cc
config
ios
chrome
app
application_delegate
browser
autofill
ui_bundled
bookmarks
model
ui_bundled
credential_provider
default_browser
default_promo
home_customization
coordinator
utils
ntp
overlays
ui_bundled
passwords
model
providers
photos
signin
user_feedback
segmentation_platform
sessions
model
settings
model
sync
utils
shared
model
ui
bottom_sheet
signin
supervised_user
tips_notifications
ui
authentication
account_menu
cells
history_sync
signin
add_account_signin
consistency_promo_signin
consistency_default_account
signin_history_sync
signin_utils.mmtwo_screens_signin
content_suggestions
menu
popup_menu
overflow_menu
reading_list
recent_tabs
settings
clear_browsing_data
quick_delete_browsing_data_view_controller.mmquick_delete_coordinator.mmquick_delete_view_controller.mm
google_services
bulk_upload
notifications
password
password_issues
widget_promo_instructions
tab_switcher
tab_grid
grid
base_grid_coordinator.mmbase_grid_mediator.mmbase_grid_view_controller.mmgrid_layout.mm
incognito
regular
selected_grid_items.mminactive_tabs
pinned_tabs
tab_grid_coordinator.mmtab_groups
tab_strip
coordinator
test
unit_conversion
upgrade
web
model
choose_file
common
open_extension
test
providers
user_feedback
web
media
audio
audio_device_description.ccaudio_encoders_unittest.ccaudio_manager_base.ccaudio_output_resampler.cc
fuchsia
base
android
audio_buffer.cccdm_key_information.ccfake_demuxer_stream.cckey_systems_impl.cckey_systems_unittest.ccmac
media_log_message_levels.ccmedia_track.ccmedia_url_demuxer.ccpipeline_impl.ccpipeline_status.ccsvc_scalability_mode.ccvideo_codecs.ccvideo_frame.ccvideo_transformation.ccvideo_types.ccvideo_util.ccwatch_time_keys.cccapture
content
mojom
video
cast
common
encoding
logging
openscreen
cdm
filters
chunk_demuxer.ccdecrypting_demuxer_stream.ccffmpeg_demuxer.ccsource_buffer_stream.ccsource_buffer_stream_unittest.cc
formats
fuchsia
gpu
android
av1_decoder.ccchromeos
h264_builder.cch264_decoder.ccsandbox
test
v4l2
v4l2_image_processor_backend.ccv4l2_queue.ccv4l2_vda_helpers.ccv4l2_video_decoder.ccv4l2_video_encode_accelerator.cc
vaapi
h264_vaapi_video_encoder_delegate.cc
vp9_decoder.ccvp9_svc_layers.cctest
vaapi_image_decode_accelerator_worker_unittest.ccvaapi_video_decoder.ccvaapi_wrapper.ccwindows
learning
midi
mojo
mojom
audio_encoder_config_mojom_traits.cccdm_key_information_mojom_traits.ccmedia_foundation_rendering_mode_mojom_traits.hmedia_types_enum_mojom_traits.h
stable
video_encode_accelerator_mojom_traits.ccvideo_encode_accelerator_mojom_traits.hvideo_frame_mojom_traits.ccservices
parsers
renderers
audio_renderer_impl.ccpaint_canvas_video_renderer.ccvideo_frame_yuv_mailboxes_holder.ccvideo_resource_updater.cc
win
video
mojo
net
base
cert
cookies
dns
http
bidirectional_stream.cchttp_auth_controller.cchttp_stream_pool.cchttp_stream_pool_job.cchttp_stream_pool_job_unittest.cchttp_stream_pool_test_util.cc
nqe
quic
reporting
shared_dictionary
socket
test
url_request
pdf
printing/backend
services
device
compute_pressure
generic_sensor
network
attribution
cors
ip_protection
ip_protection_proxy_delegate_unittest.ccip_protection_proxy_list_manager_impl_unittest.ccip_protection_token_cache_manager_impl_unittest.cc
network_context.ccp2p
public
cpp
shared_dictionary
ssl_config_type_converter.ccthrottling
video_capture
viz
public
cpp
compositing
webnn
skia/public/mojom
sql
styleguide/c++
testing/rust_gtest_interop
third_party/blink
common
interest_group
public
platform
renderer
bindings
core
css
css_math_expression_node.cccss_math_expression_node.hcss_value_id_mappings.hmedia_query_evaluator.cc
properties
resolver
exported
fetch
frame
html
input
inspector
console_message_storage.ccinspector_issue_conversion.ccinspector_page_agent.ccinspector_trace_events.cc
layout
block_layout_algorithm.h
inline
layout_block.cclayout_box.cclayout_custom_scrollbar_part.cclayout_flow_thread.cclayout_inline.cclayout_object.ccpage_border_box_layout_algorithm.hpage_container_layout_algorithm.hpaginated_root_layout_algorithm.hpagination_utils.ccphysical_fragment.ccloader
navigation_api
paint
script
scroll
style
timing
extensions
modules
accessibility
ai
canvas
canvas2d
compute_pressure
file_system_access
imagecapture
mediarecorder
mediasource
mediastream
browser_capture_media_stream_track_test.cccapture_controller.cccapture_controller_test.ccmedia_devices_test.ccmedia_stream_video_capturer_source.cctransferred_media_stream_track.cc
ml
peerconnection
serial
shared_storage
webaudio
webcodecs
webgpu
webusb
platform
bindings
fonts
shaping
geometry
graphics
heap
image-decoders
loader
fetch
media
mojo
peerconnection
scheduler
text
ui
accessibility
base
ime
metadata
models
mojom
pointer
test
color
display
manager
events
keycodes
gfx
gl
native_theme
ozone
shell_dialogs
touch_selection
views
accessibility
animation
animation_sequence_block.ccink_drop_animation_ended_reason.ccink_drop_impl.ccink_drop_state.ccslide_out_controller.ccsquare_ink_drop_ripple.cc
bubble
controls
button
combobox
label.ccmenu
scroll_view.ccscroll_view_unittest.ccscrollbar
slider_unittest.cctable
textfield
webview
corewm
examples
interaction
layout
mouse_watcher.ccselection_controller.cctest
touchui
view.ccview_targeter.ccwidget
desktop_aura
desktop_native_cursor_manager.ccdesktop_window_tree_host_platform.ccdesktop_window_tree_host_platform_unittest.cc
native_widget_mac.mmsublevel_manager_mac_unittest.mmsublevel_manager_unittest.ccwidget.ccwidget_aura_utils.ccwidget_hwnd_utils.ccwin
url
@ -143,9 +143,9 @@ std::optional<std::string> DoSerialize(base::ValueView value,
|
||||
// Failed to serialize prefs file. Backup the existing prefs file and
|
||||
// crash.
|
||||
BackupPrefsFile(path);
|
||||
NOTREACHED_NORETURN() << "Failed to serialize preferences : " << path
|
||||
<< "\nBacked up under "
|
||||
<< path.ReplaceExtension(kBadExtension);
|
||||
NOTREACHED() << "Failed to serialize preferences : " << path
|
||||
<< "\nBacked up under "
|
||||
<< path.ReplaceExtension(kBadExtension);
|
||||
}
|
||||
return output;
|
||||
}
|
||||
|
Reference in New Issue
Block a user