Use ScopedTempDir to create test folder instead of
"TypedUrlSyncableServiceTest". BUG=561083 Review URL: https://codereview.chromium.org/1475823002 Cr-Commit-Position: refs/heads/master@{#361687}
This commit is contained in:
@@ -5,6 +5,7 @@
|
|||||||
#include "components/history/core/browser/typed_url_syncable_service.h"
|
#include "components/history/core/browser/typed_url_syncable_service.h"
|
||||||
|
|
||||||
#include "base/files/file_util.h"
|
#include "base/files/file_util.h"
|
||||||
|
#include "base/files/scoped_temp_dir.h"
|
||||||
#include "base/logging.h"
|
#include "base/logging.h"
|
||||||
#include "base/memory/ref_counted.h"
|
#include "base/memory/ref_counted.h"
|
||||||
#include "base/memory/scoped_ptr.h"
|
#include "base/memory/scoped_ptr.h"
|
||||||
@@ -214,10 +215,10 @@ class TypedUrlSyncableServiceTest : public testing::Test {
|
|||||||
|
|
||||||
void SetUp() override {
|
void SetUp() override {
|
||||||
fake_history_backend_ = new TestHistoryBackend();
|
fake_history_backend_ = new TestHistoryBackend();
|
||||||
ASSERT_TRUE(base::CreateNewTempDirectory(
|
ASSERT_TRUE(test_dir_.CreateUniqueTempDir());
|
||||||
FILE_PATH_LITERAL("TypedUrlSyncableServiceTest"), &test_dir_));
|
fake_history_backend_->Init(
|
||||||
fake_history_backend_->Init(std::string(), false,
|
std::string(), false,
|
||||||
TestHistoryDatabaseParamsForPath(test_dir_));
|
TestHistoryDatabaseParamsForPath(test_dir_.path()));
|
||||||
typed_url_sync_service_.reset(
|
typed_url_sync_service_.reset(
|
||||||
new TypedUrlSyncableService(fake_history_backend_.get()));
|
new TypedUrlSyncableService(fake_history_backend_.get()));
|
||||||
fake_change_processor_.reset(new syncer::FakeSyncChangeProcessor);
|
fake_change_processor_.reset(new syncer::FakeSyncChangeProcessor);
|
||||||
@@ -285,7 +286,7 @@ class TypedUrlSyncableServiceTest : public testing::Test {
|
|||||||
|
|
||||||
protected:
|
protected:
|
||||||
base::MessageLoop message_loop_;
|
base::MessageLoop message_loop_;
|
||||||
base::FilePath test_dir_;
|
base::ScopedTempDir test_dir_;
|
||||||
scoped_refptr<TestHistoryBackend> fake_history_backend_;
|
scoped_refptr<TestHistoryBackend> fake_history_backend_;
|
||||||
scoped_ptr<TypedUrlSyncableService> typed_url_sync_service_;
|
scoped_ptr<TypedUrlSyncableService> typed_url_sync_service_;
|
||||||
scoped_ptr<syncer::FakeSyncChangeProcessor> fake_change_processor_;
|
scoped_ptr<syncer::FakeSyncChangeProcessor> fake_change_processor_;
|
||||||
|
Reference in New Issue
Block a user