Enable CrashReporter in Cast Browser.
This enables dump generation for crashes inside Cast browser. Does not initialize Crash Uploader since the uploads will be handled by mediashell's CrashUploader. Bug: 411471568 Change-Id: Idc83104de2e43575027965b70715ea968eff775c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6527510 Auto-Submit: Anirudh Tadakamala <antadaka@google.com> Commit-Queue: Anirudh Tadakamala <antadaka@google.com> Reviewed-by: Antonio Rivera <antoniori@google.com> Reviewed-by: Simeon Anfinrud <sanfin@chromium.org> Commit-Queue: Simeon Anfinrud <sanfin@chromium.org> Cr-Commit-Position: refs/heads/main@{#1458356}
This commit is contained in:

committed by
Chromium LUCI CQ

parent
a10195ea0e
commit
06fe5978f9
@@ -41,7 +41,9 @@
|
|||||||
|
|
||||||
#if BUILDFLAG(IS_ANDROID)
|
#if BUILDFLAG(IS_ANDROID)
|
||||||
#include "base/android/apk_assets.h"
|
#include "base/android/apk_assets.h"
|
||||||
|
#include "base/android/java_exception_reporter.h"
|
||||||
#include "chromecast/app/android/cast_crash_reporter_client_android.h"
|
#include "chromecast/app/android/cast_crash_reporter_client_android.h"
|
||||||
|
#include "components/crash/core/app/crashpad.h"
|
||||||
#include "ui/base/resource/resource_bundle_android.h"
|
#include "ui/base/resource/resource_bundle_android.h"
|
||||||
#elif BUILDFLAG(IS_LINUX) || BUILDFLAG(IS_CHROMEOS)
|
#elif BUILDFLAG(IS_LINUX) || BUILDFLAG(IS_CHROMEOS)
|
||||||
#include "chromecast/app/linux/cast_crash_reporter_client.h"
|
#include "chromecast/app/linux/cast_crash_reporter_client.h"
|
||||||
@@ -50,14 +52,6 @@
|
|||||||
|
|
||||||
namespace {
|
namespace {
|
||||||
|
|
||||||
#if BUILDFLAG(IS_LINUX) || BUILDFLAG(IS_CHROMEOS)
|
|
||||||
chromecast::CastCrashReporterClient* GetCastCrashReporter() {
|
|
||||||
static base::NoDestructor<chromecast::CastCrashReporterClient>
|
|
||||||
crash_reporter_client;
|
|
||||||
return crash_reporter_client.get();
|
|
||||||
}
|
|
||||||
#endif // BUILDFLAG(IS_LINUX) || BUILDFLAG(IS_CHROMEOS)
|
|
||||||
|
|
||||||
#if BUILDFLAG(IS_ANDROID)
|
#if BUILDFLAG(IS_ANDROID)
|
||||||
const int kMaxCrashFiles = 10;
|
const int kMaxCrashFiles = 10;
|
||||||
#endif // BUILDFLAG(IS_ANDROID)
|
#endif // BUILDFLAG(IS_ANDROID)
|
||||||
@@ -179,18 +173,27 @@ void CastMainDelegate::PreSandboxStartup() {
|
|||||||
bool enable_crash_reporter =
|
bool enable_crash_reporter =
|
||||||
!command_line->HasSwitch(switches::kDisableCrashReporter);
|
!command_line->HasSwitch(switches::kDisableCrashReporter);
|
||||||
if (enable_crash_reporter) {
|
if (enable_crash_reporter) {
|
||||||
|
#if BUILDFLAG(IS_ANDROID)
|
||||||
|
static base::NoDestructor<chromecast::CastCrashReporterClientAndroid>
|
||||||
|
crash_reporter_client(process_type);
|
||||||
|
#else
|
||||||
|
static base::NoDestructor<CastCrashReporterClient> crash_reporter_client;
|
||||||
|
#endif
|
||||||
|
crash_reporter::SetCrashReporterClient(crash_reporter_client.get());
|
||||||
|
|
||||||
// TODO(crbug.com/40188745): Complete crash reporting integration on
|
// TODO(crbug.com/40188745): Complete crash reporting integration on
|
||||||
// Fuchsia.
|
// Fuchsia.
|
||||||
#if BUILDFLAG(IS_LINUX) || BUILDFLAG(IS_CHROMEOS)
|
#if BUILDFLAG(IS_LINUX) || BUILDFLAG(IS_CHROMEOS)
|
||||||
crash_reporter::SetCrashReporterClient(GetCastCrashReporter());
|
|
||||||
|
|
||||||
if (process_type != switches::kZygoteProcess) {
|
if (process_type != switches::kZygoteProcess) {
|
||||||
CastCrashReporterClient::InitCrashReporter(process_type);
|
CastCrashReporterClient::InitCrashReporter(process_type);
|
||||||
}
|
}
|
||||||
crash_reporter::InitializeCrashKeys();
|
|
||||||
#endif // BUILDFLAG(IS_LINUX) || BUILDFLAG(IS_CHROMEOS)
|
#endif // BUILDFLAG(IS_LINUX) || BUILDFLAG(IS_CHROMEOS)
|
||||||
|
#if BUILDFLAG(IS_ANDROID)
|
||||||
|
crash_reporter::InitializeCrashpad(process_type.empty(), process_type);
|
||||||
|
base::android::InitJavaExceptionReporter();
|
||||||
|
#endif
|
||||||
|
crash_reporter::InitializeCrashKeys();
|
||||||
}
|
}
|
||||||
|
|
||||||
InitializeResourceBundle();
|
InitializeResourceBundle();
|
||||||
}
|
}
|
||||||
|
|
||||||
|
Reference in New Issue
Block a user