chromium/src
0
Fork 0
Code Activity

Avoid string copies in OverlayUserPrefStore.

Browse Source 
Bug: 349741884
Change-Id: Iab74393bcb4ec85d658b79924d081d7399844599
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5667397
Commit-Queue: Jan Keitel <jkeitel@google.com>
Reviewed-by: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1320954}
This commit is contained in:
Jan Keitel
2024-06-28 14:34:30 +00:00
committed by Chromium LUCI CQ
parent df42fc8339
commit 07b772bdff
2 changed files with 3 additions and 5 deletions

6
components/prefs/overlay_user_pref_store.cc

@@ -26,9 +26,7 @@ class OverlayUserPrefStore::ObserverAdapter : public PrefStore::Observer {
// Methods of PrefStore::Observer. // Methods of PrefStore::Observer.
void OnPrefValueChanged(std::string_view key) override { void OnPrefValueChanged(std::string_view key) override {
// TODO: crbug.com/349741884 - Pass `std::string_view` once the interface is parent_->OnPrefValueChanged(ephemeral_user_pref_store_, key);
// changed.
parent_->OnPrefValueChanged(ephemeral_user_pref_store_, std::string(key));
} }
void OnInitializationCompleted(bool succeeded) override { void OnInitializationCompleted(bool succeeded) override {
parent_->OnInitializationCompleted(ephemeral_user_pref_store_, succeeded); parent_->OnInitializationCompleted(ephemeral_user_pref_store_, succeeded);
@@ -225,7 +223,7 @@ OverlayUserPrefStore::~OverlayUserPrefStore() {
} }
void OverlayUserPrefStore::OnPrefValueChanged(bool ephemeral, void OverlayUserPrefStore::OnPrefValueChanged(bool ephemeral,
const std::string& key) { std::string_view key) {
if (ephemeral) { if (ephemeral) {
ReportValueChanged(key, DEFAULT_PREF_WRITE_FLAGS); ReportValueChanged(key, DEFAULT_PREF_WRITE_FLAGS);
} else { } else {

2
components/prefs/overlay_user_pref_store.h

@@ -81,7 +81,7 @@ class COMPONENTS_PREFS_EXPORT OverlayUserPrefStore
private: private:
class ObserverAdapter; class ObserverAdapter;
void OnPrefValueChanged(bool ephemeral, const std::string& key); void OnPrefValueChanged(bool ephemeral, std::string_view key);
void OnInitializationCompleted(bool ephemeral, bool succeeded); void OnInitializationCompleted(bool ephemeral, bool succeeded);
// Returns true if |key| corresponds to a preference that shall be stored in // Returns true if |key| corresponds to a preference that shall be stored in