0

Delete chrome_pdf::kTabAcrossPDFAnnotations feature flag.

The flag has been on by default for quite some time.

Bug: 994500
Change-Id: Id28d80740cef7ef83d463b56a8d02d88bd431d76
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4237817
Reviewed-by: K. Moon <kmoon@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1103613}
This commit is contained in:
Lei Zhang
2023-02-10 01:21:33 +00:00
committed by Chromium LUCI CQ
parent a8c2b75400
commit 0be4f1f329
4 changed files with 1 additions and 18 deletions

@ -32,9 +32,5 @@ BASE_FEATURE(kPdfXfaSupport,
"PdfXfaSupport", "PdfXfaSupport",
base::FEATURE_DISABLED_BY_DEFAULT); base::FEATURE_DISABLED_BY_DEFAULT);
BASE_FEATURE(kTabAcrossPDFAnnotations,
"TabAcrossPDFAnnotations",
base::FEATURE_ENABLED_BY_DEFAULT);
} // namespace features } // namespace features
} // namespace chrome_pdf } // namespace chrome_pdf

@ -18,7 +18,6 @@ BASE_DECLARE_FEATURE(kPdfIncrementalLoading);
BASE_DECLARE_FEATURE(kPdfPartialLoading); BASE_DECLARE_FEATURE(kPdfPartialLoading);
BASE_DECLARE_FEATURE(kPdfUseSkiaRenderer); BASE_DECLARE_FEATURE(kPdfUseSkiaRenderer);
BASE_DECLARE_FEATURE(kPdfXfaSupport); BASE_DECLARE_FEATURE(kPdfXfaSupport);
BASE_DECLARE_FEATURE(kTabAcrossPDFAnnotations);
} // namespace features } // namespace features
} // namespace chrome_pdf } // namespace chrome_pdf

@ -2959,8 +2959,7 @@ void PDFiumEngine::LoadForm() {
kFormHighlightColor); kFormHighlightColor);
FPDF_SetFormFieldHighlightAlpha(form(), kFormHighlightAlpha); FPDF_SetFormFieldHighlightAlpha(form(), kFormHighlightAlpha);
if (base::FeatureList::IsEnabled(features::kTabAcrossPDFAnnotations) && if (!client_->IsPrintPreview()) {
!client_->IsPrintPreview()) {
static constexpr FPDF_ANNOTATION_SUBTYPE kFocusableAnnotSubtypes[] = { static constexpr FPDF_ANNOTATION_SUBTYPE kFocusableAnnotSubtypes[] = {
FPDF_ANNOT_LINK, FPDF_ANNOT_HIGHLIGHT, FPDF_ANNOT_WIDGET}; FPDF_ANNOT_LINK, FPDF_ANNOT_HIGHLIGHT, FPDF_ANNOT_WIDGET};
FPDF_BOOL ret = FPDFAnnot_SetFocusableSubtypes( FPDF_BOOL ret = FPDFAnnot_SetFocusableSubtypes(

@ -1004,11 +1004,6 @@ TEST_P(PDFiumEngineTabbingTest, LinkUnderCursor) {
* ++++ Highlight annotation * ++++ Highlight annotation
* ++++ Link annotation * ++++ Link annotation
*/ */
// Enable feature flag.
base::test::ScopedFeatureList scoped_feature_list;
scoped_feature_list.InitAndEnableFeature(
chrome_pdf::features::kTabAcrossPDFAnnotations);
NiceMock<MockTestClient> client; NiceMock<MockTestClient> client;
std::unique_ptr<PDFiumEngine> engine = std::unique_ptr<PDFiumEngine> engine =
InitializeEngine(&client, FILE_PATH_LITERAL("annots.pdf")); InitializeEngine(&client, FILE_PATH_LITERAL("annots.pdf"));
@ -1093,12 +1088,6 @@ TEST_P(PDFiumEngineTabbingTest, TabbingSupportedAnnots) {
* ++++ Highlight annotation * ++++ Highlight annotation
* ++++ Link annotation * ++++ Link annotation
*/ */
// Enable feature flag.
base::test::ScopedFeatureList scoped_feature_list;
scoped_feature_list.InitAndEnableFeature(
chrome_pdf::features::kTabAcrossPDFAnnotations);
TestClient client; TestClient client;
std::unique_ptr<PDFiumEngine> engine = std::unique_ptr<PDFiumEngine> engine =
InitializeEngine(&client, FILE_PATH_LITERAL("annots.pdf")); InitializeEngine(&client, FILE_PATH_LITERAL("annots.pdf"));