chromium/src
0
Fork 0
Code Activity

saved_desks: Update save desk for later button tooltip

Browse Source 
Update save desk for later button tooltip given final UI string.

Bug: 1323407
Change-Id: I3f3049a55b65a1645f35b47dab18bb44529625d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3632077
Reviewed-by: Daniel Andersson <dandersson@chromium.org>
Commit-Queue: Yongshun Liu <yongshun@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1001238}
This commit is contained in:
Yongshun Liu
2022-05-09 23:37:15 +00:00
committed by Chromium LUCI CQ
parent 04676bd45c
commit 0c7a05bb68
3 changed files with 5 additions and 3 deletions

3
ash/ash_strings.grd

@ -1829,6 +1829,9 @@ This file contains the strings for ash.
<message name="IDS_ASH_DESKS_TEMPLATES_MAX_TEMPLATES_TOOLTIP" desc="The disabled Save Desk as Template button tooltip text when maximum number of templates has been reached."> <message name="IDS_ASH_DESKS_TEMPLATES_MAX_TEMPLATES_TOOLTIP" desc="The disabled Save Desk as Template button tooltip text when maximum number of templates has been reached.">
Only 6 templates allowed. Remove a template to save a new one. Only 6 templates allowed. Remove a template to save a new one.
</message> </message>
<message name="IDS_ASH_DESKS_TEMPLATES_MAX_SAVED_DESKS_TOOLTIP" desc="The disabled Save Desk for later button tooltip text when maximum number of saved desks has been reached.">
Only 6 saved desks allowed. Remove a desk to save a new one.
</message>
<message name="IDS_ASH_DESKS_TEMPLATES_DESKS_BAR_BUTTON" desc="The text of the desks templates button in the overview desks bar."> <message name="IDS_ASH_DESKS_TEMPLATES_DESKS_BAR_BUTTON" desc="The text of the desks templates button in the overview desks bar.">
Templates Templates
</message> </message>

1
ash/ash_strings_grd/IDS_ASH_DESKS_TEMPLATES_MAX_SAVED_DESKS_TOOLTIP.png.sha1 Normal file

@ -0,0 +1 @@
aa8097830d04f4b2de716c1d82409bacfb489120

4
ash/wm/desks/templates/save_desk_template_button_container.cc

@ -28,7 +28,6 @@ enum class TooltipStatus {
kNumberOfTooltipStatus, kNumberOfTooltipStatus,
}; };
// TODO(yongshun): Update when specs are ready.
constexpr std::array<int, constexpr std::array<int,
static_cast<int>(TooltipStatus::kNumberOfTooltipStatus)> static_cast<int>(TooltipStatus::kNumberOfTooltipStatus)>
kSaveAsTemplateButtonTooltipIDs = { kSaveAsTemplateButtonTooltipIDs = {
@ -39,12 +38,11 @@ constexpr std::array<int,
IDS_ASH_DESKS_TEMPLATES_UNSUPPORTED_LINUX_APPS_AND_INCOGNITO_TOOLTIP, IDS_ASH_DESKS_TEMPLATES_UNSUPPORTED_LINUX_APPS_AND_INCOGNITO_TOOLTIP,
}; };
// TODO(yongshun): Update when specs are ready.
constexpr std::array<int, constexpr std::array<int,
static_cast<int>(TooltipStatus::kNumberOfTooltipStatus)> static_cast<int>(TooltipStatus::kNumberOfTooltipStatus)>
kSaveForLaterButtonTooltipIDs = { kSaveForLaterButtonTooltipIDs = {
IDS_ASH_DESKS_TEMPLATES_SAVE_DESK_FOR_LATER_BUTTON, IDS_ASH_DESKS_TEMPLATES_SAVE_DESK_FOR_LATER_BUTTON,
IDS_ASH_DESKS_TEMPLATES_MAX_TEMPLATES_TOOLTIP, IDS_ASH_DESKS_TEMPLATES_MAX_SAVED_DESKS_TOOLTIP,
IDS_ASH_DESKS_TEMPLATES_UNSUPPORTED_INCOGNITO_TOOLTIP, IDS_ASH_DESKS_TEMPLATES_UNSUPPORTED_INCOGNITO_TOOLTIP,
IDS_ASH_DESKS_TEMPLATES_UNSUPPORTED_LINUX_APPS_TOOLTIP, IDS_ASH_DESKS_TEMPLATES_UNSUPPORTED_LINUX_APPS_TOOLTIP,
IDS_ASH_DESKS_TEMPLATES_UNSUPPORTED_LINUX_APPS_AND_INCOGNITO_TOOLTIP, IDS_ASH_DESKS_TEMPLATES_UNSUPPORTED_LINUX_APPS_AND_INCOGNITO_TOOLTIP,