chromium/src
0
Fork 0
Code Activity

Update a guideline about Owners-Override

Browse Source 
The CL updates the guideline per discussion on
lsc-owners-override@chromium.org.

Bug: None
Change-Id: Ib04194afc376765c60d74b09745c19ca25b29a3f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3218841
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Bartek Nowierski <bartekn@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/main@{#931795}
This commit is contained in:
Kentaro Hara
2021-10-15 00:35:16 +00:00
committed by Chromium LUCI CQ
parent 93f9d48a97
commit 0cdc607333
2 changed files with 32 additions and 14 deletions

13
docs/code_review_owners.md

@@ -34,6 +34,15 @@ duration, using a special label `Owners-Override`. However, these changes will
still need a second human (anyone with committers `Code-Review +1` powers) to still need a second human (anyone with committers `Code-Review +1` powers) to
vote. vote.
### What should I do when I need to get Owners-Override for one-off CLs?
One-off CLs do not need to go through Large Scale Changes. If the CLs make
only mechanical changes associated with changes in //base/ APIs, //build/ APIs,
//content/ APIs, //url/ APIs or //third_party/blink/public/APIs, the API owners can set `Owners-Override`.
For other one-off CLs, [Chrome Eng Review members](https://chromium.googlesource.com/chromium/src/+/HEAD/ENG_REVIEW_OWNERS)
can set `Owners-Override`.
### How does Rubber Stamper bot work? ### How does Rubber Stamper bot work?
Rubber Stamper applies the Bot-Commit label to conforming CLs, allowing them to Rubber Stamper applies the Bot-Commit label to conforming CLs, allowing them to
@@ -47,6 +56,10 @@ that would allow anyone who can create a revert or cherry-pick to land it
without any other person being involved (e.g. the silent revert of security without any other person being involved (e.g. the silent revert of security
patches). patches).
When you need to get Owners-Override for sheriffing CLs, reach out to Active
Sheriffs or Release Program Managers. If they are not available, send an email
to lsc-owners-override@chromium.org.
### Will trivial files require code-review? ### Will trivial files require code-review?
Rubber Stamper auto-reviewer (described above) reviews CLs that meet strict Rubber Stamper auto-reviewer (described above) reviews CLs that meet strict

33
docs/code_reviews.md

@@ -176,22 +176,27 @@ Setting the `Owners-Override +1` label will bypass OWNERS enforcement. Active
have this capability. The power to use Owners-Override should be restricted have this capability. The power to use Owners-Override should be restricted
as follows: as follows:
* Active sheriffs can set Owners-Override only on changes needed for * Active sheriffs can set Owners-Override only on sheriffing CLs (e.g.,
sheriffing (e.g., revert, reland, test fix). revert, reland, test fix).
* Release Program Managers can set Owners-Override only on changes needed * Release Program Managers can set Owners-Override only on sheriffing CLs and
for releasing (e.g., revert, reland, test fix, cherry-pick). CLs needed for releasing (e.g., cherry-pick).
* Large Scale Change reviewers can set Owners-Override only on changes * Large Scale Change reviewers can set Owners-Override only on sheriffing CLs
about the approved Large Scale Change. and CLs about the approved Large Scale Change.
* Global approvers can set Owners-Override only on mechanical changes * Global approvers can set Owners-Override only on sheriffing CLs and
associated with their API changes. For example, //base/OWNERS can set mechanical CLs associated with their API changes. For example,
Owners-Override only on mechanical changes associated with //base/ API //base/OWNERS can set Owners-Override on mechanical CLs associated with
changes. //base/ API changes.
* Chrome Eng Review members can set Owners-Override on any changes to help * Chrome Eng Review members can set Owners-Override on any changes to help
with cases that cannot be handled by the above groups. However, please with cases that cannot be handled by the above groups and expedite CLs
use one of the above groups before asking Chrome Eng Review members. when LSC is too heavyweight.. However, please use one of the above groups
before asking Chrome Eng Review members.
When you need Owners-Override on sheriffing CLs, please reach out to the
Active Sheriffs and Release Program Managers first. If none of them is
available, please send an email to lsc-owners-override@chromium.org for help.
Note that Owners-Override by itself is not enough on your own CLs. Where this Note that Owners-Override by itself is not enough on your own CLs. Where this
matters is when you're sheriffing. For example, if you want to revert or matters is when you are sheriffing. For example, if you want to revert or
disable a test, your Owners-Override on the CL is not enough. You need disable a test, your Owners-Override on the CL is not enough. You need
another committer to LGTM the CL. another committer to LGTM the CL.