ash: Remove crosapi's NetworkSettingsService and related code
Remove NetworkSettingsService and related crosapi interfaces as well as their implementations. They are no longer needed. This includes deprecating the ash.lacros_proxy_controlling_extension preference. No change in behavior intended. Bug: b:365741912 Change-Id: I2abd425d5e0c87f4ddcd97b1d068e420d47e4857 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6054898 Reviewed-by: Erik Chen <erikchen@chromium.org> Reviewed-by: Andreea Costinas <acostinas@google.com> Reviewed-by: Colin Blundell <blundell@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/main@{#1390781}
This commit is contained in:

committed by
Chromium LUCI CQ

parent
c67ddb2c19
commit
0d09fe492e
ash/constants
chrome/browser
ash
crosapi
BUILD.gnDEPScrosapi_ash.cccrosapi_ash.hcrosapi_util.ccnetwork_settings_service_ash.ccnetwork_settings_service_ash.hnetwork_settings_service_ash_browsertest.ccnetwork_settings_translation.hnetwork_settings_translation_unittest.ccprefs_ash.ccprefs_ash.hprefs_ash_unittest.cctranslate_crosapi_to_proxy_config.cctranslate_proxy_config_to_crosapi.cc
net
extensions
api
settings_private
prefs
chromeos/crosapi/mojom
components/prefs
@ -713,16 +713,6 @@ void PrefService::SetStandaloneBrowserPref(std::string_view path,
|
||||
path, value.Clone(), WriteablePrefStore::DEFAULT_PREF_WRITE_FLAGS);
|
||||
}
|
||||
|
||||
void PrefService::RemoveStandaloneBrowserPref(std::string_view path) {
|
||||
if (!standalone_browser_pref_store_) {
|
||||
LOG(WARNING) << "Failure to remove value of " << path
|
||||
<< " in standalone browser store";
|
||||
return;
|
||||
}
|
||||
standalone_browser_pref_store_->RemoveValue(
|
||||
path, WriteablePrefStore::DEFAULT_PREF_WRITE_FLAGS);
|
||||
}
|
||||
|
||||
void PrefService::RemoveAllStandaloneBrowserPrefs() {
|
||||
if (!standalone_browser_pref_store_) {
|
||||
LOG(WARNING) << "standalone_browser_pref_store_ is null";
|
||||
|
@ -413,8 +413,6 @@ class COMPONENTS_PREFS_EXPORT PrefService {
|
||||
// Write extension-controlled prefs from Lacros in ash.
|
||||
void SetStandaloneBrowserPref(std::string_view path,
|
||||
const base::Value& value);
|
||||
// Clear extension-controlled prefs from Lacros in ash.
|
||||
void RemoveStandaloneBrowserPref(std::string_view path);
|
||||
|
||||
// Clear all prefs in standalone_browser_pref_store_. Use it when rolling back
|
||||
// to Ash (i.e. disabling Lacros).
|
||||
|
Reference in New Issue
Block a user