Updated info logged when with typed url unrecoverable errors
This should allow us to more easily debug some unrecoverable errors marc is seeing on the canary channel. BUG=none TEST=none Review URL: http://codereview.chromium.org/8008004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102437 0039d316-1c4b-4281-b951-d872f2087c98
This commit is contained in:
@ -144,6 +144,14 @@ bool TypedUrlModelAssociator::AssociateModels(SyncError* error) {
|
||||
ix != typed_urls.end(); ++ix) {
|
||||
std::string tag = ix->url().spec();
|
||||
|
||||
// Should never see an empty tag.
|
||||
if (tag.empty()) {
|
||||
error->Reset(FROM_HERE,
|
||||
"Encountered history entry with an empty url.",
|
||||
model_type());
|
||||
return false;
|
||||
}
|
||||
|
||||
history::VisitVector& visits = visit_vectors[ix->id()];
|
||||
|
||||
sync_api::ReadNode node(&trans);
|
||||
@ -211,7 +219,7 @@ bool TypedUrlModelAssociator::AssociateModels(SyncError* error) {
|
||||
if (!node.InitUniqueByCreation(syncable::TYPED_URLS,
|
||||
typed_url_root, tag)) {
|
||||
error->Reset(FROM_HERE,
|
||||
"Failed to create typed_url sync node.",
|
||||
"Failed to create typed_url sync node: " + tag,
|
||||
model_type());
|
||||
return false;
|
||||
}
|
||||
|
Reference in New Issue
Block a user