Another attempt at enabling stderr logging for ERROR and FATAL logs. This will break a few layout tests. (I'll add them to the fixable list shortly)
BUG=1343647 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1385 0039d316-1c4b-4281-b951-d872f2087c98
This commit is contained in:
@ -413,7 +413,8 @@ LogMessage::~LogMessage() {
|
|||||||
logging_destination == LOG_TO_BOTH_FILE_AND_SYSTEM_DEBUG_LOG) {
|
logging_destination == LOG_TO_BOTH_FILE_AND_SYSTEM_DEBUG_LOG) {
|
||||||
#if defined(OS_WIN)
|
#if defined(OS_WIN)
|
||||||
OutputDebugStringA(str_newline.c_str());
|
OutputDebugStringA(str_newline.c_str());
|
||||||
#elif defined(OS_POSIX)
|
if (severity_ >= kAlwaysPrintErrorLevel)
|
||||||
|
#endif
|
||||||
// TODO(erikkay): this interferes with the layout tests since it grabs
|
// TODO(erikkay): this interferes with the layout tests since it grabs
|
||||||
// stderr and stdout and diffs them against known data. Our info and warn
|
// stderr and stdout and diffs them against known data. Our info and warn
|
||||||
// logs add noise to that. Ideally, the layout tests would set the log
|
// logs add noise to that. Ideally, the layout tests would set the log
|
||||||
@ -424,7 +425,6 @@ LogMessage::~LogMessage() {
|
|||||||
// they won't be able to pass any layout tests that have info or warn logs.
|
// they won't be able to pass any layout tests that have info or warn logs.
|
||||||
// See http://b/1343647
|
// See http://b/1343647
|
||||||
fprintf(stderr, "%s", str_newline.c_str());
|
fprintf(stderr, "%s", str_newline.c_str());
|
||||||
#endif
|
|
||||||
} else if (severity_ >= kAlwaysPrintErrorLevel) {
|
} else if (severity_ >= kAlwaysPrintErrorLevel) {
|
||||||
// When we're only outputting to a log file, above a certain log level, we
|
// When we're only outputting to a log file, above a certain log level, we
|
||||||
// should still output to stderr so that we can better detect and diagnose
|
// should still output to stderr so that we can better detect and diagnose
|
||||||
|
Reference in New Issue
Block a user