Remove the uncertain field from the cache entry

We never store uncertain results in the cache so the field is redundant.

Change-Id: I886c786059211a8453b55e3d6719c6c46e38bd32
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5826136
Reviewed-by: Tomek Jurkiewicz <tju@google.com>
Commit-Queue: Tomek Jurkiewicz <tju@google.com>
Auto-Submit: James Lee <ljjlee@google.com>
Cr-Commit-Position: refs/heads/main@{#1349112}

components/safe_search_api/url_checker.cc

@@ -39,10 +39,8 @@ URLChecker::Check::Check(const GURL& url, CheckCallback callback) : url(url) {
 
 URLChecker::Check::~Check() = default;
 
-URLChecker::CheckResult::CheckResult(Classification classification,
-                                     bool uncertain)
+URLChecker::CheckResult::CheckResult(Classification classification)
     : classification(classification),
-      uncertain(uncertain),
       timestamp(base::TimeTicks::Now()) {}
 
 URLChecker::URLChecker(std::unique_ptr<URLCheckerClient> async_checker)
@@ -83,8 +81,8 @@ bool URLChecker::CheckURL(const GURL& url, CheckCallback callback) {
     if (age < cache_timeout_) {
       DVLOG(1) << "Cache hit! " << url.spec() << " is "
                << (result.classification == Classification::UNSAFE ? "NOT" : "")
-               << " safe; certain: " << !result.uncertain;
-      std::move(callback).Run(url, result.classification, result.uncertain);
+               << " safe";
+      std::move(callback).Run(url, result.classification, /*uncertain=*/false);
 
       base::UmaHistogramEnumeration(kCacheHitMetricKey,
                                     CacheAccessStatus::kHit);
@@ -120,7 +118,7 @@ void URLChecker::OnAsyncCheckComplete(CheckList::iterator it,
   checks_in_progress_.erase(it);
 
   if (!uncertain) {
-    cache_.Put(url, CheckResult(classification, uncertain));
+    cache_.Put(url, CheckResult(classification));
   }
 
   for (CheckCallback& callback : callbacks) {

components/safe_search_api/url_checker.h

@@ -64,9 +64,8 @@ class URLChecker {
   struct Check;
   struct CheckResult {
     CheckResult() = delete;
-    CheckResult(Classification classification, bool uncertain);
+    explicit CheckResult(Classification classification);
     Classification classification;
-    bool uncertain;
     base::TimeTicks timestamp;
   };
   using CheckList = std::list<std::unique_ptr<Check>>;