chromium/src
0
Fork 0
Code Activity

[M135 Merge] Removing Tab checks to resolve autofill OTP authentication crash.

Browse Source 
These Checks are causing crash during card retrieval OTP authentication flow if the Send OTP step is failing. While removing them is an immediate fix, we are actively investigating a long term solution.

Bug:
Screencast: https://screencast.googleplex.com/cast/NjExNjQzNzA4NDA3ODA4MHw3ODljYjU5OC1kOA
Stack trace: https://paste.googleplex.com/5541588825276416

Fix: https://screencast.googleplex.com/cast/NjE5MzY4MzQ5Mjc2NTY5Nnw2NWFjNDg4My1lNA

(cherry picked from commit 5813d8fb02)

Bug: 404277098
Change-Id: I328f178c9e467c85861e8416e007f07c9806df99
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6349544
Reviewed-by: Erik Chen <erikchen@chromium.org>
Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Commit-Queue: Harsh Shukla <hvs@google.com>
Reviewed-by: Vinny Persky <vinnypersky@google.com>
Cr-Original-Commit-Position: refs/heads/main@{#1432277}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6361935
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/7049@{#881}
Cr-Branched-From: 2dab7846d0951a552bdc4f350dad497f986e6fed-refs/heads/main@{#1427262}
This commit is contained in:
Harsh Shukla
2025-03-17 18:52:44 -07:00
committed by Chromium LUCI CQ
parent ddc0379d8a
commit 1199021d19
2 changed files with 0 additions and 3 deletions
chrome/browser/ui/tabs
tab_dialog_manager.cctab_model.cc

2
chrome/browser/ui/tabs/tab_dialog_manager.cc

@ -245,8 +245,6 @@ std::unique_ptr<views::Widget> TabDialogManager::CreateTabScopedDialog(
}
void TabDialogManager::ShowDialogAndBlockTabInteraction(views::Widget* widget) {
CHECK(tab_interface_->CanShowModalUI());
CHECK(!widget_);
widget_ = widget;
auto* browser_window_interface = tab_interface_->GetBrowserWindowInterface();
ConfigureDesiredBoundsDelegate(widget_.get(), browser_window_interface);

1
chrome/browser/ui/tabs/tab_model.cc

@ -296,7 +296,6 @@ TabStripModel* TabModel::GetModelForTabInterface() const {
TabModel::ScopedTabModalUIImpl::ScopedTabModalUIImpl(TabModel* tab)
: tab_(tab->weak_factory_.GetWeakPtr()) {
CHECK(!tab_->showing_modal_ui_);
tab_->showing_modal_ui_ = true;
tab_->modal_ui_changed_callback_list_.Notify(tab_.get());
}