chromium/src
0
Fork 0
Code Activity

SMB: Change padding from top only when using full dialog

Browse Source 
Then component <add-smb-share-dialog> when used from the system settings
page doesn't have the dialog title, thus it should have the normal
padding at the top. This CL changes so only when this component is used
from inside the SmbShareDialog it will have a small padding a the top.

See crbug.com/992827#c44 for screenshot of before and after.

Bug: 992827
Change-Id: I0a613d03a8e6cd3539723725ebabc2b65cb67bee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239132
Auto-Submit: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Anand Mistry <amistry@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Anand Mistry <amistry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#777098}
This commit is contained in:
Luciano Pacheco
2020-06-10 20:57:45 +00:00
committed by Commit Bot
parent b0eef82571
commit 1385202161
2 changed files with 5 additions and 5 deletions
chrome/browser/resources/chromeos/smb_shares
smb_share_dialog.html
ui/webui/resources/cr_components/chromeos/smb_shares
add_smb_share_dialog.html

4
chrome/browser/resources/chromeos/smb_shares/smb_share_dialog.html

@ -4,6 +4,10 @@
height: 100%;
width: 100%;
}
add-smb-share-dialog::part(title) {
padding-top: 4px;
}
</style>
<add-smb-share-dialog on-close="onDialogClose_">

6
ui/webui/resources/cr_components/chromeos/smb_shares/add_smb_share_dialog.html

@ -23,10 +23,6 @@
padding: calc(24px - 20px);
}
[slot='title'] {
padding-top: 4px;
}
[slot='button-container'] {
padding-bottom: 20px;
padding-top: 32px;
@ -75,7 +71,7 @@
</style>
<cr-dialog id="dialog" exportparts="dialog">
<div slot="title">[[i18n('addSmbShare')]]</div>
<div slot="title" part="title">[[i18n('addSmbShare')]]</div>
<div slot="body" spellcheck="false">
<div id="general-error-container">
<div hidden="[[!shouldShowGeneralError_(currentMountError_)]]">