From 167540f76ed2e36c7f11a12f8305254bb965b7ed Mon Sep 17 00:00:00 2001 From: Javier Ernesto Flores Robles <javierrobles@chromium.org> Date: Mon, 10 May 2021 22:17:20 +0000 Subject: [PATCH] [iOS][Sheriff] Disable failing omnibox tests Bug: 1207651 Change-Id: I008950f5cb3b228031ce5e5fa0e9ac09063b8105 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2885067 Reviewed-by: Javier Flores <javierrobles@chromium.org> Reviewed-by: Chris Lu <thegreenfrog@chromium.org> Owners-Override: Javier Flores <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#881267} --- ios/chrome/browser/ui/omnibox/popup/omnibox_popup_egtest.mm | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/ios/chrome/browser/ui/omnibox/popup/omnibox_popup_egtest.mm b/ios/chrome/browser/ui/omnibox/popup/omnibox_popup_egtest.mm index 4153251f51605..7133ef7dd02c2 100644 --- a/ios/chrome/browser/ui/omnibox/popup/omnibox_popup_egtest.mm +++ b/ios/chrome/browser/ui/omnibox/popup/omnibox_popup_egtest.mm @@ -108,7 +108,8 @@ std::unique_ptr<net::test_server::HttpResponse> StandardResponse( // Tests that tapping the switch to open tab button, switch to the open tab, // doesn't close the tab. -- (void)testSwitchToOpenTab { +// TODO(crbug.com/1207651): This test doesn't pass on iPhone SE 1st gen. +- (void)DISABLED_testSwitchToOpenTab { // TODO(crbug.com/1067817): Test won't pass on iPad devices. #if !TARGET_IPHONE_SIMULATOR if ([ChromeEarlGrey isIPadIdiom]) { @@ -320,7 +321,8 @@ std::unique_ptr<net::test_server::HttpResponse> StandardResponse( // Tests that switching to closed tab opens the tab in foreground, except if it // is from NTP without history. -- (void)testSwitchToClosedTab { +// TODO(crbug.com/1207651): This test doesn't pass on iPhone SE 1st gen. +- (void)DISABLED_testSwitchToClosedTab { if (@available(iOS 13, *)) { if ([ChromeEarlGrey isIPadIdiom]) { // TODO(crbug.com/992480):test fails on iPad.