chromium/src
0
Fork 0
Code Activity

Correct callback arity in |attachImpl$| for OOPIF based guests.

Browse Source 
In the OOPIF based guest version of |attachImpl$| the callback for
|AttachIframeGuest| takes "contentWindow" as an argument, but
|GuestViewAttachIframeRequest::HandleResponse| does not call it
with any arguments.

Bug: None
Change-Id: I9ab5a719814fff549f6d6880d63aba39489cfeae
Reviewed-on: https://chromium-review.googlesource.com/861183
Reviewed-by: James MacLean <wjmaclean@chromium.org>
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528631}
This commit is contained in:
Kevin McNee
2018-01-11 15:31:13 +00:00
committed by Commit Bot
parent b90afab2c4
commit 1923a62fbb
1 changed files with 3 additions and 4 deletions

7
extensions/renderer/resources/guest_view/guest_view_iframe.js

@ -38,12 +38,11 @@ GuestViewImpl.prototype.attachImpl$ = function(
return;
}
// Callback wrapper function to store the contentWindow from the attachGuest()
// callback, handle potential attaching failure, register an automatic detach,
// Callback wrapper function to set the contentWindow following attachment,
// and advance the queue.
var callbackWrapper = function(callback, contentWindow) {
var callbackWrapper = function(callback) {
var contentWindow = getIframeContentWindow(viewInstanceId);
// Check if attaching failed.
contentWindow = getIframeContentWindow(viewInstanceId);
if (!contentWindow) {
this.state = GuestViewImpl.GuestState.GUEST_STATE_CREATED;
this.internalInstanceId = 0;