diff --git a/build/config/unsafe_buffers_paths.txt b/build/config/unsafe_buffers_paths.txt index 7faa929fa24ef..0d0d9fc616eb5 100644 --- a/build/config/unsafe_buffers_paths.txt +++ b/build/config/unsafe_buffers_paths.txt @@ -77,9 +77,6 @@ # as system headers when building with DEPOT_TOOLS_WIN_TOOLCHAIN=0 ? -Program Files (x86)/Windows Kits/ -# Please check 'linux-v4l2-codec-rel' bot before removing this opt-out. --media/gpu/v4l2/ - # //codelabs is a directory that contains examples for developers to modify as # they learn about chromium development. This is indefinitely opt-out because # it is not part of the main build, and we don't want developers to be blocked diff --git a/media/gpu/chromeos/image_processor_test.cc b/media/gpu/chromeos/image_processor_test.cc index eebf12f957825..d0a34d3c94f79 100644 --- a/media/gpu/chromeos/image_processor_test.cc +++ b/media/gpu/chromeos/image_processor_test.cc @@ -2,6 +2,11 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +#ifdef UNSAFE_BUFFERS_BUILD +// TODO(crbug.com/40285824): Remove this and spanify to fix the errors. +#pragma allow_unsafe_buffers +#endif + #include "media/gpu/chromeos/image_processor.h" #include <sys/mman.h> diff --git a/media/gpu/chromeos/vulkan_overlay_adaptor_test.cc b/media/gpu/chromeos/vulkan_overlay_adaptor_test.cc index 123eb717c201a..bbc3d308cb62b 100644 --- a/media/gpu/chromeos/vulkan_overlay_adaptor_test.cc +++ b/media/gpu/chromeos/vulkan_overlay_adaptor_test.cc @@ -2,6 +2,11 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +#ifdef UNSAFE_BUFFERS_BUILD +// TODO(crbug.com/40285824): Remove this and spanify to fix the errors. +#pragma allow_unsafe_buffers +#endif + #include "media/gpu/chromeos/vulkan_overlay_adaptor.h" #include <linux/videodev2.h> @@ -420,7 +425,6 @@ scoped_refptr<VideoFrame> ProcessFrameLibyuv(scoped_refptr<VideoFrame> in_frame, break; default: NOTREACHED() << "Invalid overlay transform: " << transform; - return nullptr; } // Assemble a graph of the available LibYUV conversion functions. @@ -794,7 +798,7 @@ TEST_P(VulkanOverlayAdaptorTest, Correctness) { VulkanOverlayAdaptor::Create(/*is_protected=*/false, GetParam().tiling); bool performed_cleanup = false; - auto fence_helper = + auto* fence_helper = vulkan_overlay_adaptor->GetVulkanDeviceQueue()->GetFenceHelper(); fence_helper->EnqueueCleanupTaskForSubmittedWork(base::BindOnce( [](bool* cleanup_flag, gpu::VulkanDeviceQueue* device_queue, diff --git a/media/gpu/v4l2/legacy/v4l2_video_decode_accelerator.cc b/media/gpu/v4l2/legacy/v4l2_video_decode_accelerator.cc index 312f2ddc29197..89aa43be9af78 100644 --- a/media/gpu/v4l2/legacy/v4l2_video_decode_accelerator.cc +++ b/media/gpu/v4l2/legacy/v4l2_video_decode_accelerator.cc @@ -2,6 +2,11 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +#ifdef UNSAFE_BUFFERS_BUILD +// TODO(crbug.com/40285824): Remove this and spanify to fix the errors. +#pragma allow_unsafe_buffers +#endif + #include "media/gpu/v4l2/legacy/v4l2_video_decode_accelerator.h" #include <dlfcn.h> diff --git a/media/gpu/v4l2/legacy/v4l2_video_decoder_backend_stateful.cc b/media/gpu/v4l2/legacy/v4l2_video_decoder_backend_stateful.cc index 00878c2b0807a..08d5da269093c 100644 --- a/media/gpu/v4l2/legacy/v4l2_video_decoder_backend_stateful.cc +++ b/media/gpu/v4l2/legacy/v4l2_video_decoder_backend_stateful.cc @@ -2,6 +2,11 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +#ifdef UNSAFE_BUFFERS_BUILD +// TODO(crbug.com/40285824): Remove this and spanify to fix the errors. +#pragma allow_unsafe_buffers +#endif + #include "media/gpu/v4l2/legacy/v4l2_video_decoder_backend_stateful.h" #include <cstddef> diff --git a/media/gpu/v4l2/test/h264_decoder.cc b/media/gpu/v4l2/test/h264_decoder.cc index 91316ec0b045c..acfb85925124c 100644 --- a/media/gpu/v4l2/test/h264_decoder.cc +++ b/media/gpu/v4l2/test/h264_decoder.cc @@ -2,6 +2,11 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +#ifdef UNSAFE_BUFFERS_BUILD +// TODO(crbug.com/40285824): Remove this and spanify to fix the errors. +#pragma allow_unsafe_buffers +#endif + #include "media/gpu/v4l2/test/h264_decoder.h" #include <linux/v4l2-controls.h> diff --git a/media/gpu/v4l2/test/h265_decoder.cc b/media/gpu/v4l2/test/h265_decoder.cc index 54ddd2933b9ae..9731fd9b397a9 100644 --- a/media/gpu/v4l2/test/h265_decoder.cc +++ b/media/gpu/v4l2/test/h265_decoder.cc @@ -2,6 +2,11 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +#ifdef UNSAFE_BUFFERS_BUILD +// TODO(crbug.com/40285824): Remove this and spanify to fix the errors. +#pragma allow_unsafe_buffers +#endif + #include "media/gpu/v4l2/test/h265_decoder.h" #include <linux/videodev2.h> diff --git a/media/gpu/v4l2/test/v4l2_ioctl_shim.cc b/media/gpu/v4l2/test/v4l2_ioctl_shim.cc index d8184851df3c1..2aaac94315042 100644 --- a/media/gpu/v4l2/test/v4l2_ioctl_shim.cc +++ b/media/gpu/v4l2/test/v4l2_ioctl_shim.cc @@ -2,6 +2,11 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +#ifdef UNSAFE_BUFFERS_BUILD +// TODO(crbug.com/40285824): Remove this and spanify to fix the errors. +#pragma allow_unsafe_buffers +#endif + #include "media/gpu/v4l2/test/v4l2_ioctl_shim.h" #include <fcntl.h> diff --git a/media/gpu/v4l2/test/v4l2_ioctl_shim.h b/media/gpu/v4l2/test/v4l2_ioctl_shim.h index 7bdbb9c96f16c..91deee3141fc6 100644 --- a/media/gpu/v4l2/test/v4l2_ioctl_shim.h +++ b/media/gpu/v4l2/test/v4l2_ioctl_shim.h @@ -5,6 +5,11 @@ #ifndef MEDIA_GPU_V4L2_TEST_V4L2_IOCTL_SHIM_H_ #define MEDIA_GPU_V4L2_TEST_V4L2_IOCTL_SHIM_H_ +#ifdef UNSAFE_BUFFERS_BUILD +// TODO(crbug.com/40285824): Remove this and spanify to fix the errors. +#pragma allow_unsafe_buffers +#endif + #include <linux/videodev2.h> #include <string.h> diff --git a/media/gpu/v4l2/test/v4l2_stateless_decoder.cc b/media/gpu/v4l2/test/v4l2_stateless_decoder.cc index 47e35131360f5..0999affa62511 100644 --- a/media/gpu/v4l2/test/v4l2_stateless_decoder.cc +++ b/media/gpu/v4l2/test/v4l2_stateless_decoder.cc @@ -2,6 +2,11 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +#ifdef UNSAFE_BUFFERS_BUILD +// TODO(crbug.com/40285824): Remove this and spanify to fix the errors. +#pragma allow_unsafe_buffers +#endif + #include <iostream> #include <sstream> #include <string> diff --git a/media/gpu/v4l2/test/video_decoder.cc b/media/gpu/v4l2/test/video_decoder.cc index ede5f52c2040b..2c936d938b1a0 100644 --- a/media/gpu/v4l2/test/video_decoder.cc +++ b/media/gpu/v4l2/test/video_decoder.cc @@ -2,6 +2,11 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +#ifdef UNSAFE_BUFFERS_BUILD +// TODO(crbug.com/40285824): Remove this and spanify to fix the errors. +#pragma allow_unsafe_buffers +#endif + #include "media/gpu/v4l2/test/video_decoder.h" #include <linux/videodev2.h> diff --git a/media/gpu/v4l2/test/vp9_decoder.cc b/media/gpu/v4l2/test/vp9_decoder.cc index 594fe97badae3..53cc836def131 100644 --- a/media/gpu/v4l2/test/vp9_decoder.cc +++ b/media/gpu/v4l2/test/vp9_decoder.cc @@ -2,6 +2,11 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +#ifdef UNSAFE_BUFFERS_BUILD +// TODO(crbug.com/40285824): Remove this and spanify to fix the errors. +#pragma allow_unsafe_buffers +#endif + #include "media/gpu/v4l2/test/vp9_decoder.h" #include <linux/v4l2-controls.h> diff --git a/media/gpu/v4l2/v4l2_device.cc b/media/gpu/v4l2/v4l2_device.cc index 8ac19fab6faf8..4bf5cf2ff7587 100644 --- a/media/gpu/v4l2/v4l2_device.cc +++ b/media/gpu/v4l2/v4l2_device.cc @@ -2,6 +2,11 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +#ifdef UNSAFE_BUFFERS_BUILD +// TODO(crbug.com/40285824): Remove this and spanify to fix the errors. +#pragma allow_unsafe_buffers +#endif + #include "media/gpu/v4l2/v4l2_device.h" #include <errno.h> diff --git a/media/gpu/v4l2/v4l2_image_processor_backend.cc b/media/gpu/v4l2/v4l2_image_processor_backend.cc index 1b6227c7c30f4..b844c24786e0b 100644 --- a/media/gpu/v4l2/v4l2_image_processor_backend.cc +++ b/media/gpu/v4l2/v4l2_image_processor_backend.cc @@ -2,6 +2,11 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +#ifdef UNSAFE_BUFFERS_BUILD +// TODO(crbug.com/40285824): Remove this and spanify to fix the errors. +#pragma allow_unsafe_buffers +#endif + #include "media/gpu/v4l2/v4l2_image_processor_backend.h" #include <errno.h> diff --git a/media/gpu/v4l2/v4l2_queue.cc b/media/gpu/v4l2/v4l2_queue.cc index f7909fa12d21a..06c34649318c6 100644 --- a/media/gpu/v4l2/v4l2_queue.cc +++ b/media/gpu/v4l2/v4l2_queue.cc @@ -2,6 +2,11 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +#ifdef UNSAFE_BUFFERS_BUILD +// TODO(crbug.com/40285824): Remove this and spanify to fix the errors. +#pragma allow_unsafe_buffers +#endif + #include "media/gpu/v4l2/v4l2_queue.h" #include <errno.h> diff --git a/media/gpu/v4l2/v4l2_stateful_video_decoder.cc b/media/gpu/v4l2/v4l2_stateful_video_decoder.cc index fcf017b17ffae..b305de6ca5ad1 100644 --- a/media/gpu/v4l2/v4l2_stateful_video_decoder.cc +++ b/media/gpu/v4l2/v4l2_stateful_video_decoder.cc @@ -2,6 +2,11 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +#ifdef UNSAFE_BUFFERS_BUILD +// TODO(crbug.com/40285824): Remove this and spanify to fix the errors. +#pragma allow_unsafe_buffers +#endif + #include "media/gpu/v4l2/v4l2_stateful_video_decoder.h" #include <fcntl.h> diff --git a/media/gpu/v4l2/v4l2_utils.cc b/media/gpu/v4l2/v4l2_utils.cc index 1fcb59dc0524e..4675f6024e982 100644 --- a/media/gpu/v4l2/v4l2_utils.cc +++ b/media/gpu/v4l2/v4l2_utils.cc @@ -2,6 +2,11 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +#ifdef UNSAFE_BUFFERS_BUILD +// TODO(crbug.com/40285824): Remove this and spanify to fix the errors. +#pragma allow_unsafe_buffers +#endif + #include "media/gpu/v4l2/v4l2_utils.h" #include <fcntl.h> diff --git a/media/gpu/v4l2/v4l2_utils_unittest.cc b/media/gpu/v4l2/v4l2_utils_unittest.cc index a0aa42a9ec6a6..5c226b6afe2a8 100644 --- a/media/gpu/v4l2/v4l2_utils_unittest.cc +++ b/media/gpu/v4l2/v4l2_utils_unittest.cc @@ -2,6 +2,11 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +#ifdef UNSAFE_BUFFERS_BUILD +// TODO(crbug.com/40285824): Remove this and spanify to fix the errors. +#pragma allow_unsafe_buffers +#endif + #include "media/gpu/v4l2/v4l2_utils.h" #include <cstring> diff --git a/media/gpu/v4l2/v4l2_video_decoder_backend_stateless.cc b/media/gpu/v4l2/v4l2_video_decoder_backend_stateless.cc index ec4cc2c771536..4356aeb436ffb 100644 --- a/media/gpu/v4l2/v4l2_video_decoder_backend_stateless.cc +++ b/media/gpu/v4l2/v4l2_video_decoder_backend_stateless.cc @@ -2,6 +2,11 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +#ifdef UNSAFE_BUFFERS_BUILD +// TODO(crbug.com/40285824): Remove this and spanify to fix the errors. +#pragma allow_unsafe_buffers +#endif + #include "media/gpu/v4l2/v4l2_video_decoder_backend_stateless.h" #include <fcntl.h> diff --git a/media/gpu/v4l2/v4l2_video_decoder_delegate_h264.cc b/media/gpu/v4l2/v4l2_video_decoder_delegate_h264.cc index 92ca5ee18810c..a9ec44e24250d 100644 --- a/media/gpu/v4l2/v4l2_video_decoder_delegate_h264.cc +++ b/media/gpu/v4l2/v4l2_video_decoder_delegate_h264.cc @@ -2,6 +2,11 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +#ifdef UNSAFE_BUFFERS_BUILD +// TODO(crbug.com/40285824): Remove this and spanify to fix the errors. +#pragma allow_unsafe_buffers +#endif + #include "media/gpu/v4l2/v4l2_video_decoder_delegate_h264.h" #include <linux/v4l2-controls.h> diff --git a/media/gpu/v4l2/v4l2_video_decoder_delegate_h265.cc b/media/gpu/v4l2/v4l2_video_decoder_delegate_h265.cc index ccdb6a46bfc34..e2cfa22d78ff2 100644 --- a/media/gpu/v4l2/v4l2_video_decoder_delegate_h265.cc +++ b/media/gpu/v4l2/v4l2_video_decoder_delegate_h265.cc @@ -2,6 +2,11 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +#ifdef UNSAFE_BUFFERS_BUILD +// TODO(crbug.com/40285824): Remove this and spanify to fix the errors. +#pragma allow_unsafe_buffers +#endif + #include "media/gpu/v4l2/v4l2_video_decoder_delegate_h265.h" #include <linux/v4l2-controls.h> diff --git a/media/gpu/v4l2/v4l2_video_decoder_delegate_vp8.cc b/media/gpu/v4l2/v4l2_video_decoder_delegate_vp8.cc index d6e413394232c..b9e17a240d216 100644 --- a/media/gpu/v4l2/v4l2_video_decoder_delegate_vp8.cc +++ b/media/gpu/v4l2/v4l2_video_decoder_delegate_vp8.cc @@ -2,6 +2,11 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +#ifdef UNSAFE_BUFFERS_BUILD +// TODO(crbug.com/40285824): Remove this and spanify to fix the errors. +#pragma allow_unsafe_buffers +#endif + #include "v4l2_video_decoder_delegate_vp8.h" #include <linux/v4l2-controls.h> diff --git a/media/gpu/v4l2/v4l2_video_decoder_delegate_vp9.cc b/media/gpu/v4l2/v4l2_video_decoder_delegate_vp9.cc index f60564d30c898..bb8b6488765d6 100644 --- a/media/gpu/v4l2/v4l2_video_decoder_delegate_vp9.cc +++ b/media/gpu/v4l2/v4l2_video_decoder_delegate_vp9.cc @@ -2,6 +2,11 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +#ifdef UNSAFE_BUFFERS_BUILD +// TODO(crbug.com/40285824): Remove this and spanify to fix the errors. +#pragma allow_unsafe_buffers +#endif + #include "media/gpu/v4l2/v4l2_video_decoder_delegate_vp9.h" #include <linux/v4l2-controls.h> diff --git a/media/gpu/v4l2/v4l2_vp9_helpers.cc b/media/gpu/v4l2/v4l2_vp9_helpers.cc index a8e49406d72ad..c7785b0a4965a 100644 --- a/media/gpu/v4l2/v4l2_vp9_helpers.cc +++ b/media/gpu/v4l2/v4l2_vp9_helpers.cc @@ -2,6 +2,11 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +#ifdef UNSAFE_BUFFERS_BUILD +// TODO(crbug.com/40285824): Remove this and spanify to fix the errors. +#pragma allow_unsafe_buffers +#endif + #include "media/gpu/v4l2/v4l2_vp9_helpers.h" #include "base/containers/heap_array.h" diff --git a/media/gpu/v4l2/v4l2_vp9_helpers_unittest.cc b/media/gpu/v4l2/v4l2_vp9_helpers_unittest.cc index aae362699c433..fdbf0da450204 100644 --- a/media/gpu/v4l2/v4l2_vp9_helpers_unittest.cc +++ b/media/gpu/v4l2/v4l2_vp9_helpers_unittest.cc @@ -2,6 +2,11 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +#ifdef UNSAFE_BUFFERS_BUILD +// TODO(crbug.com/40285824): Remove this and spanify to fix the errors. +#pragma allow_unsafe_buffers +#endif + #include "media/gpu/v4l2/v4l2_vp9_helpers.h" #include <vector>