chromium/src
0
Fork 0
Code Activity

build: Add windows_manifest sources to inputs

Browse Source 
As the manifest files are necessary for lld-link commands,
this CL adds them to inputs.
Also, the dependency to the targets that generate manifest file need
to be propagated as `public_deps`. e.g. `//chrome/app/version_assembly:chrome_exe_version_manifest`

Bug: 415155400
Change-Id: Ifd46ec2619a427054c3afd8df547ec2589a62732
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6508005
Commit-Queue: Gabriel Charette <gab@chromium.org>
Auto-Submit: Junji Watanabe <jwata@google.com>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1456878}
This commit is contained in:
Junji Watanabe
2025-05-07 04:48:13 -07:00
committed by Chromium LUCI CQ
parent b3cd9b27ac
commit 20fe59fa75
2 changed files with 3 additions and 2 deletions
build/config/win
manifest.gni
chrome/app/version_assembly
BUILD.gn

3
build/config/win/manifest.gni

@ -90,6 +90,7 @@ if (is_win) {
# We handle UAC by adding explicit .manifest files instead. # We handle UAC by adding explicit .manifest files instead.
"/manifestuac:no", "/manifestuac:no",
] + manifests ] + manifests
inputs = invoker.sources
} }
# This group only exists to add a dep on the invoker's deps and to # This group only exists to add a dep on the invoker's deps and to
@ -100,7 +101,7 @@ if (is_win) {
# Apply any dependencies from the invoker to this target, since those # Apply any dependencies from the invoker to this target, since those
# dependencies may have created the input manifest files. # dependencies may have created the input manifest files.
forward_variables_from(invoker, [ "deps" ]) forward_variables_from(invoker, [ "public_deps" ])
} }
} }
} else { } else {

2
chrome/app/version_assembly/BUILD.gn

@ -32,7 +32,7 @@ windows_manifest("chrome_exe_manifest") {
sources += [ segment_heap_manifest ] sources += [ segment_heap_manifest ]
} }
deps = [ ":chrome_exe_version_manifest" ] public_deps = [ ":chrome_exe_version_manifest" ]
} }
# Generates the manifest for the version assembly, which is the versioned # Generates the manifest for the version assembly, which is the versioned