From 29f5dab2c39f213753a61bcf7e1b4786c42ced04 Mon Sep 17 00:00:00 2001 From: Antonio Sartori <antoniosartori@chromium.org> Date: Wed, 7 May 2025 06:14:38 -0700 Subject: [PATCH] Revert "Roll libc++ from a01c02c9d4ac to a9cc573e7c59 (8 revisions)" This reverts commit dba214ab9573a2b1bc137e11e80ed27cf6e038b1. Reason for revert: Failure of PartitionAllocPageAllocatorTest.DecommitAndZero and telemetry.page.cache_temperature_unittest.CacheTemperatureTests.testEnsureHotAfterColdRun. Original change's description: > Roll libc++ from a01c02c9d4ac to a9cc573e7c59 (8 revisions) > > https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/a01c02c9d4ac..a9cc573e7c59 > > 2025-05-06 winner245@hotmail.com [libc++][NFC] Improve test readability for std::fill_n (#133771) > 2025-05-06 nikolasklauser@berlin.de [libc++][NFC] Remove a bunch of redundant ASan existence checks (#128504) > 2025-05-06 de34@live.cn [libc++][test] Test `flat_meow` with proper underlying iterators (#131290) > 2025-05-06 raul@tambre.ee [libcxx][CMake] Use the right variable in the C library error message (#138458) > 2025-05-06 ldionne.2@gmail.com [libc++] Remove redundant and somewhat confusing assertions around advance() (#133276) > 2025-05-06 ldionne.2@gmail.com [libc++] Improve the test coverage for std::vector::emplace (#132440) > 2025-05-06 ldionne.2@gmail.com [libc++] Enable sized deallocation when building operator new shims on Apple (#134152) > 2025-05-06 nikolasklauser@berlin.de [libc++][C++03] Remove code that is not used in C++03 (#134045) > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/libcxx-chromium > Please CC hans@chromium.org,thakis@chromium.org on the revert to ensure that a human > is aware of the problem. > > To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry > > To report a problem with the AutoRoller itself, please file a bug: > https://issues.skia.org/issues/new?component=1389291&template=1850622 > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md > > Tbr: hans@chromium.org,thakis@chromium.org > Change-Id: I3b7e2453635e302222c01c358d67a59eeb56fd4a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6517219 > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/main@{#1456697} Bug: 414813537, 416151077 No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: Ieeadf900b3d5a29509116ae78f8841d334c91598 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6519632 Auto-Submit: Antonio Sartori <antoniosartori@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1456943} --- DEPS | 2 +- buildtools/deps_revisions.gni | 2 +- third_party/libc++/src | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/DEPS b/DEPS index 02ca2e8283afe..07fd9e077194d 100644 --- a/DEPS +++ b/DEPS @@ -527,7 +527,7 @@ vars = { # If you change this, also update the libc++ revision in # //buildtools/deps_revisions.gni. - 'libcxx_revision': 'a9cc573e7c591795d11b72d8323ba0e573b55bd6', + 'libcxx_revision': 'a01c02c9d4acbdae3b7e8a2f3ee58579a9c29f96', # GN CIPD package version. 'gn_version': 'git_revision:487f8353f15456474437df32bb186187b0940b45', diff --git a/buildtools/deps_revisions.gni b/buildtools/deps_revisions.gni index 72dff7bef2694..ab4de6f7148ad 100644 --- a/buildtools/deps_revisions.gni +++ b/buildtools/deps_revisions.gni @@ -5,5 +5,5 @@ declare_args() { # Used to cause full rebuilds on libc++ rolls. This should be kept in sync # with the libcxx_revision var in //DEPS. - libcxx_revision = "a9cc573e7c591795d11b72d8323ba0e573b55bd6" + libcxx_revision = "a01c02c9d4acbdae3b7e8a2f3ee58579a9c29f96" } diff --git a/third_party/libc++/src b/third_party/libc++/src index a9cc573e7c591..a01c02c9d4acb 160000 --- a/third_party/libc++/src +++ b/third_party/libc++/src @@ -1 +1 @@ -Subproject commit a9cc573e7c591795d11b72d8323ba0e573b55bd6 +Subproject commit a01c02c9d4acbdae3b7e8a2f3ee58579a9c29f96