chromium/src
0
Fork 0
Code Activity

Minor net/http unit test cleanup

Browse Source 
Minor cleanup that I came across

 #cleanup

Bug: None
Change-Id: Ib2d3ae596f92b1f22b667b24f189fcc359b00403
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5601172
Commit-Queue: Andrew Williams <awillia@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1313168}
This commit is contained in:
Andrew Williams
2024-06-11 01:33:17 +00:00
committed by Chromium LUCI CQ
parent 3c10d19e3e
commit 3516fb9213
2 changed files with 4 additions and 12 deletions

8
net/http/http_network_transaction_unittest.cc

@@ -6458,14 +6458,6 @@ TEST_P(HttpNetworkTransactionTest, HttpProxyLoadTimingWithPacTwoRequests) {
// Make sure that NetworkAnonymizationKeys are passed down to the proxy layer. // Make sure that NetworkAnonymizationKeys are passed down to the proxy layer.
TEST_P(HttpNetworkTransactionTest, ProxyResolvedWithNetworkAnonymizationKey) { TEST_P(HttpNetworkTransactionTest, ProxyResolvedWithNetworkAnonymizationKey) {
const SchemefulSite kSite(GURL("https://foo.test/"));
const SchemefulSite kOtherSite(GURL("https://bar.test/"));
const NetworkIsolationKey kNetworkIsolationKey =
NetworkIsolationKey(kSite, kOtherSite);
const NetworkAnonymizationKey kNetworkAnonymizationKey =
NetworkAnonymizationKey::CreateFromNetworkIsolationKey(
kNetworkIsolationKey);
ProxyConfig proxy_config; ProxyConfig proxy_config;
proxy_config.set_auto_detect(true); proxy_config.set_auto_detect(true);
proxy_config.set_pac_url(GURL("http://fooproxyurl")); proxy_config.set_pac_url(GURL("http://fooproxyurl"));

8
net/http/http_stream_factory_unittest.cc

@@ -709,8 +709,8 @@ TEST_F(HttpStreamFactoryTest, PreconnectNetworkIsolationKey) {
peer.SetClientSocketPoolManager(std::move(mock_pool_manager)); peer.SetClientSocketPoolManager(std::move(mock_pool_manager));
const GURL kURL("http://foo.test/"); const GURL kURL("http://foo.test/");
SchemefulSite kSiteFoo(GURL("http://foo.test")); const SchemefulSite kSiteFoo(GURL("http://foo.test"));
SchemefulSite kSiteBar(GURL("http://bar.test")); const SchemefulSite kSiteBar(GURL("http://bar.test"));
const auto kKey1 = NetworkAnonymizationKey::CreateSameSite(kSiteFoo); const auto kKey1 = NetworkAnonymizationKey::CreateSameSite(kSiteFoo);
const auto kKey2 = NetworkAnonymizationKey::CreateSameSite(kSiteBar); const auto kKey2 = NetworkAnonymizationKey::CreateSameSite(kSiteBar);
PreconnectHelperForURL(1, kURL, kKey1, SecureDnsPolicy::kAllow, PreconnectHelperForURL(1, kURL, kKey1, SecureDnsPolicy::kAllow,
@@ -747,8 +747,8 @@ TEST_F(HttpStreamFactoryTest, PreconnectDisableSecureDns) {
peer.SetClientSocketPoolManager(std::move(mock_pool_manager)); peer.SetClientSocketPoolManager(std::move(mock_pool_manager));
const GURL kURL("http://foo.test/"); const GURL kURL("http://foo.test/");
SchemefulSite kSiteFoo(GURL("http://foo.test")); const SchemefulSite kSiteFoo(GURL("http://foo.test"));
SchemefulSite kSiteBar(GURL("http://bar.test")); const SchemefulSite kSiteBar(GURL("http://bar.test"));
PreconnectHelperForURL(1, kURL, NetworkAnonymizationKey(), PreconnectHelperForURL(1, kURL, NetworkAnonymizationKey(),
SecureDnsPolicy::kAllow, session.get()); SecureDnsPolicy::kAllow, session.get());
EXPECT_EQ(1, transport_conn_pool->last_num_streams()); EXPECT_EQ(1, transport_conn_pool->last_num_streams());