Migrate base::Value::GetList() to base::Value::GetListDeprecated(): 1/N.
GetList() will be reimplemented in a future CL with an updated signature, so existing uses need to be renamed out of the way. Unlike TakeList() and TakeDict(), GetList() is used quite widely. This CL migrates a number of uses using the following set of automated steps: sed -i "s|->GetList()|->GetListDeprecated()|g" \ $(git gs "GetList()" --name-only) git checkout -- base/values_unittest.cc third_party/dom_distiller_js git cl format Bug: 1291666 Change-Id: I1b7a92fcb4874e7afb82d4bd092c1c9de2cc3d05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3430698 Reviewed-by: danakj chromium <danakj@chromium.org> Owners-Override: danakj chromium <danakj@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/main@{#966487}
This commit is contained in:

committed by
Chromium LUCI CQ

parent
c8cd30c553
commit
354945de1f
android_webview/nonembedded/component_updater
ash
components
display
quick_pair
repository
fast_pair
session
wallpaper
webui
common
backend
connectivity_diagnostics
diagnostics_ui
backend
projector_app
scanning
wm
base
json
metrics
test
trace_event
cc
chrome
browser
accessibility
android
bookmarks
contextualsearch
explore_sites
oom_intervention
apps
ash
app_mode
arc
accessibility
enterprise
fileapi
input_overlay
policy
survey
tracing
base
cert_provisioning
child_accounts
parent_access_code
time_limit_override.cctime_limits
app_activity_registry.ccapp_time_limits_allowlist_policy_wrapper.ccapp_time_policy_helpers.ccpersisted_app_info.cc
usage_time_limit_processor.cccrosapi
crostini
customization
dbus
enhanced_network_tts
file_system_provider
operations
abort_unittest.ccadd_watcher_unittest.ccclose_file_unittest.ccconfigure_unittest.cccopy_entry_unittest.cccreate_directory_unittest.cccreate_file_unittest.ccdelete_entry_unittest.ccexecute_action_unittest.ccget_actions_unittest.ccget_metadata_unittest.ccmove_entry_unittest.ccopen_file_unittest.ccread_directory_unittest.ccread_file_unittest.ccremove_watcher_unittest.cctruncate_unittest.ccunmount_unittest.ccwrite_file_unittest.cc
provided_file_system_unittest.ccregistry.ccregistry_unittest.ccguest_os
input_method
kerberos
lock_screen_apps
login
easy_unlock
enterprise_enrollment_browsertest.ccexisting_user_controller.cclock_screen_utils.cclogin_manager_test.ccquick_unlock
saml
screens
session
test
ui
users
wizard_controller_browsertest.ccnet
rollback_network_config
ownership
policy
affiliation
core
external_data
handlers
networking
reporting
arc_app_install_event_log_uploader_unittest.ccarc_app_install_event_logger.ccextension_install_event_log_uploader_unittest.cc
status_collector
uploading
printing
settings
smb_client
system_logs
wallpaper_handlers
web_applications
personalization_app
autofill
bookmarks
browser_switcher
browsing_data
cart
chrome_browser_main.ccchrome_content_browser_client.ccchrome_navigation_browsertest.ccchromeos
component_updater
content_settings
device_api
devtools
domain_reliability
download
enterprise
connectors
extensions
activity_log
api
autofill_private
automation
certificate_provider
chrome_extensions_api_client.cccookies
cryptotoken_private
declarative_content
declarative_net_request
declarative_webrequest
developer_private
downloads
enterprise_platform_keys
enterprise_reporting_private
extension_action
font_settings
force_installed_affiliated_extension_apitest.ccidentity
image_writer_private
language_settings_private
management
mdns
messaging
chrome_messaging_delegate.ccnative_message_process_host_unittest.ccnative_messaging_host_manifest.cc
notifications
omnibox
passwords_private
permissions
preference
printing
proxy
quick_unlock_private
safe_browsing_private
sessions
signed_in_devices
tab_groups
tabs
top_sites
web_authentication_proxy
web_request
webstore_private
updater
window_controller.ccexternal_protocol
federated_learning
font_prewarmer_tab_helper.cclacros
account_manager
lifetime
media
media_galleries
metrics
nearby_sharing
net
cert_verify_proc_browsertest.ccconvert_explicitly_allowed_network_ports_pref.ccexplicitly_allowed_network_ports_policy_handler_unittest.cclog_net_log_browsertest.ccprofile_network_context_service.ccreporting_browsertest.ccsystem_network_context_manager.cc
new_tab_page
modules
notifications
page_load_metrics
integration_tests
permissions
plugins
policy
messaging_layer
public
upload
networking
network_configuration_updater.ccnetwork_configuration_updater_ash_unittest.ccpolicy_cert_service_factory.ccpolicy_cert_service_factory_ash_unittest.cc
system_features_disable_list_policy_handler.cctest
component_updater_policy_browsertest.ccssl_error_overriding_allowed_policy_browsertest.ccurl_blocklist_policy_browsertest.ccweb_rtc_local_ips_allowed_urls_policy_browsertest.cc
webusb_allow_devices_for_urls_policy_handler.ccwebusb_allow_devices_for_urls_policy_handler_unittest.ccprefetch
no_state_prefetch
prefs
printing
profile_resetter
profiles
renderer_preferences_util.ccsafe_browsing
serial
sessions
sharing
signin
speech
extension_api
spellchecker
spellcheck_language_blocklist_policy_handler.ccspellcheck_language_policy_handler.ccspellcheck_language_policy_handlers_unittest.ccspellcheck_service.ccspellcheck_service_browsertest.cc
ssl
supervised_user
child_accounts
sync_file_system
tracing
ui
app_list
arc
search
arc
files
search_result_ranker
ash
cocoa
applescript
startup
tabs
views
webui
bookmarks
browser_switch
certificate_provisioning_ui_handler.cccertificate_provisioning_ui_handler_unittest.cccertificate_viewer_webui.cccertificates_handler.ccchromeos
account_manager
arc_graphics_tracing
arc_power_control
edu_coexistence
in_session_password_change
confirm_password_change_handler.ccpassword_change_handler.ccurgent_password_expiry_notification_handler.cc
login
app_downloading_screen_handler.cccore_oobe_handler.ccgaia_screen_handler.ccl10n_util.ccl10n_util_unittest.ccnetwork_dropdown_handler.ccrecommend_apps_screen_handler.ccsaml_challenge_key_handler.ccwelcome_screen_handler.cc
multidevice_internals
multidevice_setup
network_logs_message_handler.ccnetwork_ui.cconc_import_message_handler.ccpower_ui.ccset_time_ui.ccsmb_shares
sync
sys_internals
commander
components
conflicts
constrained_web_dialog_ui.ccdevice_log_ui.ccdomain_reliability_internals_ui.ccdownload_internals
extensions
family_link_user_internals
flags
gcm_internals_ui.cchelp
history
browsing_history_handler.ccbrowsing_history_handler_unittest.ccforeign_session_handler.ccnavigation_handler.cc
identity_internals_ui.ccinspect_ui.ccinternals
lens
notifications
query_tiles
management
media
media_router
memory_internals_ui.ccmetrics_handler.ccnacl_ui.ccnearby_internals
nearby_share
net_export_ui.ccnet_internals
new_tab_page
ntp
app_icon_webui_handler.ccapp_launcher_handler.cccookie_controls_handler.cccore_app_launcher_handler.cc
offline
plural_string_handler.ccpolicy
predictors
print_preview
extension_printer_handler.ccextension_printer_handler_unittest.ccprint_preview_handler.ccprint_preview_handler_chromeos.ccprint_preview_handler_chromeos_unittest.ccprint_preview_handler_unittest.ccprint_preview_metrics.ccprint_preview_utils.ccprint_preview_utils_unittest.cc
sandbox
settings
about_handler.ccbrowser_lifetime_handler.ccchrome_cleanup_handler_win.cc
chromeos
accessibility_handler.ccaccessibility_handler_browsertest.ccaccount_manager_handler_browsertest.ccambient_mode_handler.ccambient_mode_handler_unittest.ccandroid_apps_handler.ccbluetooth_handler.ccchange_picture_handler.cccrostini_handler.cccups_printers_handler.ccdate_time_handler.ccdevice_display_handler.ccdevice_name_handler.ccdevice_power_handler.ccdevice_stylus_handler.ccfingerprint_handler.ccgoogle_assistant_handler.ccguest_os_handler.ccinternet_handler.ccinternet_handler_unittest.cckerberos_accounts_handler.ccmultidevice_handler.ccparental_controls_handler.ccperipheral_data_access_handler.ccplugin_vm_handler.ccquick_unlock_handler.cctts_handler.ccwallpaper_handler.cc
downloads_handler.ccextension_control_handler.ccfont_handler.cchats_handler.ccimport_data_handler.ccincompatible_applications_handler_win.cclanguages_handler.ccmetrics_reporting_handler.ccon_startup_handler.ccprivacy_sandbox_handler.ccprofile_info_handler.ccprotocol_handlers_handler.ccreset_settings_handler.ccsafety_check_handler.ccsearch_engines_handler.ccsettings_clear_browsing_data_handler_browsertest.ccsettings_cookies_view_handler.ccsettings_cookies_view_handler_unittest.ccsettings_default_browser_handler.ccsettings_manage_profile_handler.ccsettings_manage_profile_handler_unittest.ccsettings_media_devices_selection_handler.ccsettings_secure_dns_handler.ccsettings_secure_dns_handler_browsertest.ccsettings_security_key_handler.ccsite_settings_handler.ccsite_settings_handler_unittest.ccsite_settings_helper.ccsite_settings_helper_unittest.ccurl_handlers_handler.ccsignin
dice_web_signin_intercept_handler.ccenterprise_profile_welcome_handler.ccinline_login_handler.ccinline_login_handler_chromeos.ccinline_login_handler_chromeos_browsertest.ccprofile_customization_handler.ccprofile_picker_handler.ccprofile_picker_handler_unittest.ccsignin_reauth_handler.ccsignin_utils.ccsync_confirmation_handler.cc
signin_internals_ui.ccsync_file_system_internals
dump_database_handler.ccextension_statuses_handler.ccfile_metadata_handler.ccsync_file_system_internals_handler.cc
system_info_ui.ccversion
webapks
welcome
whats_new
upgrade_detector
usb
web_applications
webauthn
webid
common
chromeos
extensions
api
manifest_handlers
printing
credential_provider
gaiacp
installer
renderer
test
base
chromedriver
capabilities.cc
chrome
chrome_android_impl.ccconsole_logger.ccdevtools_http_client.cclog.ccnetwork_conditions.ccweb_view_impl.cc
commands_unittest.ccelement_commands.ccelement_util.cclogging.cclogging_unittest.ccperformance_logger.ccperformance_logger_unittest.ccsession_commands.ccsession_commands_unittest.ccutil.ccwebauthn_commands.ccwindow_commands.ccdata
webui
utility
importer
chromecast
browser
extensions
api
crash
media
chromeos
components
onc
onc_parsed_certificates.cconc_parsed_certificates_unittest.cconc_utils.cconc_utils_unittest.cconc_validator.ccvariable_expander.ccvariable_expander_unittest.cc
quick_answers
dbus
cros_disks
power
shill
network
cellular_esim_profile_handler_impl.ccgeolocation_handler.ccmanaged_network_configuration_handler_impl.ccmanaged_network_configuration_handler_unittest.ccnetwork_metadata_store.ccnetwork_state.cc
onc
network_onc_utils.ccnetwork_onc_utils_unittest.cconc_merger.cconc_translator_onc_to_shill.cconc_translator_shill_to_onc.cc
policy_applicator.ccprinting
services
device_sync
network_config
system
components
accuracy_tips
app_restore
autofill
core
browser
pattern_provider
payments
common
logging
ios
browser
autofill_assistant
bookmarks
browser
managed
browsing_data
core
counters
cast_streaming
cdm
common
client_hints
common
cloud_devices
content_capture
android
test_support
content_creation
notes
core
content_settings
core
cronet
custom_handlers
desks_storage
digital_asset_links
dom_distiller
domain_reliability
embedder_support
enterprise
feed
core
v2
flags_ui
heap_profiling
multi_process
history
core
browser
language
content
browser
core
browser
login
lookalikes
media_router
browser
presentation
metrics
mirroring
net_log
no_state_prefetch
ntp_snippets
ntp_tiles
omnibox
browser
password_manager
core
payments
content
utility
core
performance_manager
permissions
policy
core
prefs
printing
safe_browsing
android
content
browser
common
core
safe_search_api
safe_search
search_engines
security_interstitials
services
app_service
heap_profiling
signin
internal
site_isolation
soda
spellcheck
browser
sync
base
driver
protocol
test
fake_server
sync_device_info
translate
core
translate_internals
ukm
update_client
url_matcher
user_manager
variations
viz
common
service
webapps
services
web_app_origin_association
webcrypto
content
browser
accessibility
accessibility_tree_formatter_auralinux.ccaccessibility_tree_formatter_blink.ccaccessibility_tree_formatter_win.cc
android
devtools
font_unique_name_lookup
gpu
interest_group
media
renderer_host
service_worker
speech
tracing
ukm_internals_ui.ccwebid
webrtc
webrtc_getusermedia_browsertest.ccwebrtc_internals_browsertest.ccwebrtc_internals_message_handler.ccwebrtc_internals_unittest.cc
webui
common
public
renderer
java
skia_benchmarking_extension_unittest.ccv8_value_converter_impl.ccv8_value_converter_impl_unittest.ccservices
test
web_test
device/fido
extensions
browser
api
alarms
audio
content_settings
declarative
declarative_webrequest
device_permissions_manager.cclock_screen_data
socket
system_network
web_request
common
event_matcher.ccextension.ccextension_api.ccextension_l10n_util.ccextension_l10n_util_unittest.cc
manifest_handlers
action_handlers_handler.ccapp_isolation_info.ccbackground_info.ccfile_handler_info.cckiosk_mode_info.ccmime_types_handler.ccnacl_modules_handler.ccpermissions_parser.ccsandboxed_page_info.ccwebview_info.cc
permissions
url_pattern_set.ccvalue_builder_unittest.ccrenderer
fuchsia
google_apis
common
drive
gaia
gpu/tools/compositor_model_bench
headless/test
ios
chrome
browser
autofill
follow
signin
chrome_account_manager_service.mmpattern_account_restriction.mmuser_approved_account_list_manager.mm
ui
authentication
enterprise
webui
test
web
favicon
js_messaging
navigation
webui
web_view
internal
ipc
media
base
cast
cdm
gpu
net
base
cert
dns
http
http_server_properties_manager.cchttp_server_properties_manager_unittest.cchttp_stream_factory_unittest.cctransport_security_state_unittest.cc
log
network_error_logging
quic
reporting
spdy
tools
transport_security_state_generator
printing
remoting
client
host
it2me
pairing_registry_delegate_linux_unittest.ccpairing_registry_delegate_win_unittest.ccremoting_me2me_host.ccprotocol
rlz/chromeos/lib
services
data_decoder
device
image_annotation
network
third_party/blink/renderer
tools
json_schema_compiler
privacy_budget
font_indexer
ui
accessibility
platform
inspect
base
webui
display
manager
web_dialogs
weblayer/browser
@ -52,11 +52,12 @@ bool ParseResponse(const std::string& response, bool* is_porn) {
|
||||
DLOG(WARNING) << "ParseResponse failed to parse classifications list";
|
||||
return false;
|
||||
}
|
||||
if (classifications_list->GetList().size() != 1) {
|
||||
if (classifications_list->GetListDeprecated().size() != 1) {
|
||||
DLOG(WARNING) << "ParseResponse expected exactly one result";
|
||||
return false;
|
||||
}
|
||||
const base::Value& classification_value = classifications_list->GetList()[0];
|
||||
const base::Value& classification_value =
|
||||
classifications_list->GetListDeprecated()[0];
|
||||
if (!classification_value.is_dict()) {
|
||||
DLOG(WARNING) << "ParseResponse failed to parse classification dict";
|
||||
return false;
|
||||
|
Reference in New Issue
Block a user