0

Migrate base::Value::GetList() to base::Value::GetListDeprecated(): 1/N.

GetList() will be reimplemented in a future CL with an updated
signature, so existing uses need to be renamed out of the way.

Unlike TakeList() and TakeDict(), GetList() is used quite widely. This
CL migrates a number of uses using the following set of automated steps:

sed -i "s|->GetList()|->GetListDeprecated()|g" \
    $(git gs "GetList()" --name-only)
git checkout -- base/values_unittest.cc third_party/dom_distiller_js
git cl format

Bug: 1291666
Change-Id: I1b7a92fcb4874e7afb82d4bd092c1c9de2cc3d05
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3430698
Reviewed-by: danakj chromium <danakj@chromium.org>
Owners-Override: danakj chromium <danakj@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/main@{#966487}
This commit is contained in:
Daniel Cheng
2022-02-02 23:39:17 +00:00
committed by Chromium LUCI CQ
parent c8cd30c553
commit 354945de1f
983 changed files with 3995 additions and 3547 deletions
android_webview/nonembedded/component_updater
ash
base
cc
chrome
browser
accessibility
android
apps
ash
app_mode
arc
base
cert_provisioning
child_accounts
crosapi
crostini
customization
dbus
enhanced_network_tts
file_system_provider
guest_os
input_method
kerberos
lock_screen_apps
login
net
rollback_network_config
note_taking_helper.cc
ownership
policy
printing
settings
smb_client
system_logs
wallpaper_handlers
web_applications
autofill
bookmarks
browser_switcher
browsing_data
cart
chrome_browser_main.ccchrome_content_browser_client.ccchrome_navigation_browsertest.cc
chromeos
component_updater
content_settings
device_api
devtools
domain_reliability
download
enterprise
extensions
activity_log
api
autofill_private
automation
certificate_provider
chrome_extensions_api_client.cc
cookies
cryptotoken_private
declarative_content
declarative_net_request
declarative_webrequest
developer_private
downloads
enterprise_platform_keys
enterprise_reporting_private
extension_action
font_settings
force_installed_affiliated_extension_apitest.cc
identity
image_writer_private
language_settings_private
management
mdns
messaging
notifications
omnibox
passwords_private
permissions
preference
printing
proxy
quick_unlock_private
safe_browsing_private
sessions
signed_in_devices
tab_groups
tabs
top_sites
web_authentication_proxy
web_request
webstore_private
extension_assets_manager_chromeos.ccextension_browsertest.ccextension_function_test_utils.ccextension_management.ccextension_management_internal.ccextension_management_test_util.ccextension_override_apitest.ccextension_prefs_unittest.ccextension_web_ui.ccextension_web_ui_unittest.ccexternal_provider_impl.ccinstall_signer.ccmenu_manager.ccmenu_manager_unittest.ccpolicy_handlers.cc
updater
window_controller.cc
external_protocol
federated_learning
font_prewarmer_tab_helper.cc
lacros
lifetime
media
media_galleries
metrics
nearby_sharing
net
new_tab_page
notifications
page_load_metrics
permissions
plugins
policy
prefetch
prefs
printing
profile_resetter
profiles
renderer_preferences_util.cc
safe_browsing
serial
sessions
sharing
signin
speech
spellchecker
ssl
supervised_user
sync_file_system
tracing
ui
app_list
ash
cocoa
startup
tabs
views
webui
bookmarks
browser_switch
certificate_provisioning_ui_handler.cccertificate_provisioning_ui_handler_unittest.cccertificate_viewer_webui.cccertificates_handler.cc
chromeos
commander
components
conflicts
constrained_web_dialog_ui.ccdevice_log_ui.ccdomain_reliability_internals_ui.cc
download_internals
extensions
family_link_user_internals
flags
gcm_internals_ui.cc
help
history
identity_internals_ui.ccinspect_ui.cc
internals
management
media
media_router
memory_internals_ui.ccmetrics_handler.ccnacl_ui.cc
nearby_internals
nearby_share
net_export_ui.cc
net_internals
new_tab_page
ntp
offline
plural_string_handler.cc
policy
predictors
print_preview
sandbox
settings
about_handler.ccbrowser_lifetime_handler.ccchrome_cleanup_handler_win.cc
chromeos
downloads_handler.ccextension_control_handler.ccfont_handler.cchats_handler.ccimport_data_handler.ccincompatible_applications_handler_win.cclanguages_handler.ccmetrics_reporting_handler.ccon_startup_handler.ccprivacy_sandbox_handler.ccprofile_info_handler.ccprotocol_handlers_handler.ccreset_settings_handler.ccsafety_check_handler.ccsearch_engines_handler.ccsettings_clear_browsing_data_handler_browsertest.ccsettings_cookies_view_handler.ccsettings_cookies_view_handler_unittest.ccsettings_default_browser_handler.ccsettings_manage_profile_handler.ccsettings_manage_profile_handler_unittest.ccsettings_media_devices_selection_handler.ccsettings_secure_dns_handler.ccsettings_secure_dns_handler_browsertest.ccsettings_security_key_handler.ccsite_settings_handler.ccsite_settings_handler_unittest.ccsite_settings_helper.ccsite_settings_helper_unittest.ccurl_handlers_handler.cc
signin
signin_internals_ui.cc
sync_file_system_internals
system_info_ui.cc
version
webapks
welcome
whats_new
upgrade_detector
usb
web_applications
webauthn
webid
common
credential_provider
installer
renderer
test
utility
chromecast
chromeos
components
accuracy_tips
app_restore
autofill
autofill_assistant
bookmarks
browsing_data
core
cast_streaming
cdm
client_hints
cloud_devices
content_capture
content_creation
notes
content_settings
cronet
custom_handlers
desks_storage
digital_asset_links
dom_distiller
domain_reliability
embedder_support
enterprise
feed
core
flags_ui
heap_profiling
multi_process
history
language
login
lookalikes
media_router
metrics
mirroring
net_log
no_state_prefetch
ntp_snippets
ntp_tiles
omnibox
password_manager
payments
performance_manager
permissions
policy
prefs
printing
safe_browsing
safe_search_api
search_engines
security_interstitials
services
signin
site_isolation
soda
spellcheck
sync
sync_device_info
translate
ukm
update_client
url_matcher
user_manager
variations
viz
webapps
services
web_app_origin_association
webcrypto
content
device/fido
extensions
fuchsia
google_apis
gpu/tools/compositor_model_bench
headless/test
ios
ipc
media
net
printing
remoting
rlz/chromeos/lib
services
third_party/blink/renderer
modules
platform
instrumentation
tools
json_schema_compiler
privacy_budget
font_indexer
ui
accessibility
base
display
web_dialogs
weblayer/browser

@ -52,11 +52,12 @@ bool ParseResponse(const std::string& response, bool* is_porn) {
DLOG(WARNING) << "ParseResponse failed to parse classifications list";
return false;
}
if (classifications_list->GetList().size() != 1) {
if (classifications_list->GetListDeprecated().size() != 1) {
DLOG(WARNING) << "ParseResponse expected exactly one result";
return false;
}
const base::Value& classification_value = classifications_list->GetList()[0];
const base::Value& classification_value =
classifications_list->GetListDeprecated()[0];
if (!classification_value.is_dict()) {
DLOG(WARNING) << "ParseResponse failed to parse classification dict";
return false;