Reland "Android: Make official build symbolization work"
Original CL: https://crrev.com/c/5477688 Fixed: - Removed crashpad_database_util as it results in local crashes. Although dump_syms can be downloaded from BinaryManager, it is better and more reliable for symbolization if it is always built. This CL adds it as a data dep of official builds. Bug: 332553182 Fixed: 332553182 Change-Id: I158ab52b44c164bdf78c392d39038f4c7d55f0b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5497836 Reviewed-by: Egor Pasko <pasko@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/main@{#1293878}
This commit is contained in:

committed by
Chromium LUCI CQ

parent
4e78465001
commit
3ab66b00c9
@@ -557,6 +557,12 @@ template("chrome_common_apk_or_module_tmpl") {
|
|||||||
data_deps += [ "//chrome/android:android_lint" ]
|
data_deps += [ "//chrome/android:android_lint" ]
|
||||||
}
|
}
|
||||||
|
|
||||||
|
# Official builds need the dump_syms binary for symbolizing. This is a small
|
||||||
|
# binary necessary for debugging official builds. Ensure it is built.
|
||||||
|
if (is_official_build) {
|
||||||
|
data_deps += [ "//third_party/breakpad:dump_syms" ]
|
||||||
|
}
|
||||||
|
|
||||||
shared_libraries = []
|
shared_libraries = []
|
||||||
loadable_modules = []
|
loadable_modules = []
|
||||||
if (android_64bit_target_cpu) {
|
if (android_64bit_target_cpu) {
|
||||||
|
@@ -259,10 +259,8 @@ class ClankCompiler:
|
|||||||
self._step_recorder.RunCommand(
|
self._step_recorder.RunCommand(
|
||||||
['gn', 'gen',
|
['gn', 'gen',
|
||||||
str(self._out_dir), '--args=' + ' '.join(gn_args)])
|
str(self._out_dir), '--args=' + ' '.join(gn_args)])
|
||||||
# Always build dump_syms as it's required by
|
|
||||||
# generate_breakpad_symbols.GetDumpSymsBinary in order to symbolize stacks.
|
|
||||||
self._step_recorder.RunCommand(self._ninja_command +
|
self._step_recorder.RunCommand(self._ninja_command +
|
||||||
[str(self._out_dir), target, 'dump_syms'])
|
[str(self._out_dir), target])
|
||||||
|
|
||||||
def _ForceRelink(self):
|
def _ForceRelink(self):
|
||||||
"""Forces libmonochrome.so to be re-linked.
|
"""Forces libmonochrome.so to be re-linked.
|
||||||
|
Reference in New Issue
Block a user