Revert "jni_zero: Fixing up more broken multiplexing instances"
This reverts commit 43c68b0aad
.
Reason for revert: Breaks internal build
See https://ci.chromium.org/ui/p/chrome/builders/ci/chromium-internal-arm-builder-rel/9905/overview
java.io.IOException: error reading obj/ui/base/select_file_dialog_jni_headers_java.processed.jar
at com.google.turbine.binder.ClassPathBinder.bindClasspath(ClassPathBinder.java:69)
at com.google.turbine.main.Main.bind(Main.java:272)
at com.google.turbine.main.Main.compile(Main.java:158)
at com.google.turbine.main.Main.compile(Main.java:133)
at com.google.turbine.main.Main.main(Main.java:89)
Caused by: java.nio.file.NoSuchFileException: obj/ui/base/select_file_dialog_jni_headers_java.processed.jar
Original change's description:
> jni_zero: Fixing up more broken multiplexing instances
>
> These are a non-exhaustive set of cases where multiplexing broke
> because we are depending on a generate_jni target without depending on
> the corresponding .cc file which includes the _jni.h file.
>
>
> Bug: 40612925
> Change-Id: I9ce6261998ab0614ee33ba0895b9dee510ce02f7
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5478018
> Owners-Override: Andrew Grieve <agrieve@chromium.org>
> Commit-Queue: Sam Maier <smaier@chromium.org>
> Reviewed-by: Andrew Grieve <agrieve@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1291845}
Bug: 40612925
Change-Id: If966d17bbd232f683d1c2e2beae9035890aa1f5e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5483669
Auto-Submit: Patrick Noland <pnoland@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Owners-Override: Patrick Noland <pnoland@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1291935}
This commit is contained in:

committed by
Chromium LUCI CQ

parent
09a4d5376d
commit
3bff690c50
chrome/browser
components/search_engines
gpu/vulkan
net
services/device
ui
android
base
shell_dialogs
@@ -8493,6 +8493,7 @@ static_library("test_support") {
|
|||||||
"fast_checkout/mock_fast_checkout_capabilities_fetcher.cc",
|
"fast_checkout/mock_fast_checkout_capabilities_fetcher.cc",
|
||||||
"fast_checkout/mock_fast_checkout_capabilities_fetcher.h",
|
"fast_checkout/mock_fast_checkout_capabilities_fetcher.h",
|
||||||
]
|
]
|
||||||
|
deps += [ "//chrome/android:test_support_jni_headers" ]
|
||||||
} else {
|
} else {
|
||||||
sources += [
|
sources += [
|
||||||
"apps/intent_helper/preferred_apps_test_util.cc",
|
"apps/intent_helper/preferred_apps_test_util.cc",
|
||||||
|
@@ -147,6 +147,7 @@ static_library("test_support") {
|
|||||||
"mock_manual_filling_view.h",
|
"mock_manual_filling_view.h",
|
||||||
]
|
]
|
||||||
deps += [
|
deps += [
|
||||||
|
"//chrome/android:test_support_jni_headers",
|
||||||
"//chrome/browser",
|
"//chrome/browser",
|
||||||
"//chrome/browser/autofill",
|
"//chrome/browser/autofill",
|
||||||
"//chrome/browser/keyboard_accessory/test_utils/android",
|
"//chrome/browser/keyboard_accessory/test_utils/android",
|
||||||
|
@@ -149,6 +149,10 @@ source_set("search_engine_utils") {
|
|||||||
]
|
]
|
||||||
|
|
||||||
deps = [ "//url" ]
|
deps = [ "//url" ]
|
||||||
|
|
||||||
|
if (is_android) {
|
||||||
|
deps += [ "//components/search_engines/android:jni_headers" ]
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
source_set("search_engine_type") {
|
source_set("search_engine_type") {
|
||||||
|
@@ -219,7 +219,10 @@ if (enable_vulkan) {
|
|||||||
|
|
||||||
if (is_android) {
|
if (is_android) {
|
||||||
sources += [ "tests/native_window_android.cc" ]
|
sources += [ "tests/native_window_android.cc" ]
|
||||||
deps += [ "//ui/gl" ]
|
deps += [
|
||||||
|
"//ui/android:ui_java",
|
||||||
|
"//ui/gl",
|
||||||
|
]
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@@ -3173,11 +3173,11 @@ test("net_unittests") {
|
|||||||
deps += [
|
deps += [
|
||||||
":net_jni_headers",
|
":net_jni_headers",
|
||||||
"//base:base_unittest_support_java",
|
"//base:base_unittest_support_java",
|
||||||
"//net/android:dummy_spnego_authenticator_java",
|
|
||||||
"//net/android:dummy_spnego_authenticator_jni",
|
|
||||||
"//net/android:net_java",
|
"//net/android:net_java",
|
||||||
"//net/android:net_java_test_support",
|
"//net/android:net_java_test_support",
|
||||||
"//net/android:net_test_support_jni",
|
"//net/android:net_test_support_jni",
|
||||||
|
"//net/android:net_test_support_provider_java",
|
||||||
|
"//net/android:net_test_support_provider_jni",
|
||||||
"//net/android:net_tests_java",
|
"//net/android:net_tests_java",
|
||||||
"//net/android:net_tests_jni",
|
"//net/android:net_tests_jni",
|
||||||
"//net/android:net_unittests_apk_resources",
|
"//net/android:net_unittests_apk_resources",
|
||||||
|
@@ -102,17 +102,17 @@ android_library("net_java_test_support") {
|
|||||||
|
|
||||||
generate_jni("net_test_support_provider_jni") {
|
generate_jni("net_test_support_provider_jni") {
|
||||||
testonly = true
|
testonly = true
|
||||||
sources = [ "../test/android/javatests/src/org/chromium/net/test/EmbeddedTestServerImpl.java" ]
|
sources = [
|
||||||
}
|
"../test/android/javatests/src/org/chromium/net/test/DummySpnegoAuthenticator.java",
|
||||||
|
"../test/android/javatests/src/org/chromium/net/test/EmbeddedTestServerImpl.java",
|
||||||
generate_jni("dummy_spnego_authenticator_jni") {
|
]
|
||||||
testonly = true
|
|
||||||
sources = [ "../test/android/javatests/src/org/chromium/net/test/DummySpnegoAuthenticator.java" ]
|
|
||||||
}
|
}
|
||||||
|
|
||||||
android_library("net_test_support_provider_java") {
|
android_library("net_test_support_provider_java") {
|
||||||
testonly = true
|
testonly = true
|
||||||
sources = [
|
sources = [
|
||||||
|
"../test/android/javatests/src/org/chromium/net/test/DummySpnegoAuthenticator.java",
|
||||||
|
"../test/android/javatests/src/org/chromium/net/test/DummySpnegoAuthenticatorService.java",
|
||||||
"../test/android/javatests/src/org/chromium/net/test/EmbeddedTestServerImpl.java",
|
"../test/android/javatests/src/org/chromium/net/test/EmbeddedTestServerImpl.java",
|
||||||
"../test/android/javatests/src/org/chromium/net/test/EmbeddedTestServerService.java",
|
"../test/android/javatests/src/org/chromium/net/test/EmbeddedTestServerService.java",
|
||||||
]
|
]
|
||||||
@@ -129,24 +129,6 @@ android_library("net_test_support_provider_java") {
|
|||||||
data_deps = [ "//net:test_support" ]
|
data_deps = [ "//net:test_support" ]
|
||||||
}
|
}
|
||||||
|
|
||||||
android_library("dummy_spnego_authenticator_java") {
|
|
||||||
testonly = true
|
|
||||||
sources = [
|
|
||||||
"../test/android/javatests/src/org/chromium/net/test/DummySpnegoAuthenticator.java",
|
|
||||||
"../test/android/javatests/src/org/chromium/net/test/DummySpnegoAuthenticatorService.java",
|
|
||||||
]
|
|
||||||
srcjar_deps = [ ":dummy_spnego_authenticator_jni" ]
|
|
||||||
|
|
||||||
deps = [
|
|
||||||
":net_java",
|
|
||||||
"//base:base_java",
|
|
||||||
"//base:base_java_url_utils_for_test",
|
|
||||||
"//third_party/jni_zero:jni_zero_java",
|
|
||||||
]
|
|
||||||
|
|
||||||
data_deps = [ "//net:test_support" ]
|
|
||||||
}
|
|
||||||
|
|
||||||
source_set("java_test_native_support") {
|
source_set("java_test_native_support") {
|
||||||
testonly = true
|
testonly = true
|
||||||
sources = [
|
sources = [
|
||||||
|
@@ -6,7 +6,7 @@
|
|||||||
#include "base/android/jni_android.h"
|
#include "base/android/jni_android.h"
|
||||||
#include "base/android/jni_string.h"
|
#include "base/android/jni_string.h"
|
||||||
#include "base/base64.h"
|
#include "base/base64.h"
|
||||||
#include "net/android/dummy_spnego_authenticator_jni/DummySpnegoAuthenticator_jni.h"
|
#include "net/android/net_test_support_provider_jni/DummySpnegoAuthenticator_jni.h"
|
||||||
#include "testing/gtest/include/gtest/gtest.h"
|
#include "testing/gtest/include/gtest/gtest.h"
|
||||||
|
|
||||||
using base::android::JavaParamRef;
|
using base::android::JavaParamRef;
|
||||||
|
@@ -259,6 +259,8 @@ source_set("tests") {
|
|||||||
]
|
]
|
||||||
deps += [
|
deps += [
|
||||||
":device_service_jni_headers",
|
":device_service_jni_headers",
|
||||||
|
"//services/device/public/java:geolocation_java_test_support",
|
||||||
|
"//services/device/usb:java",
|
||||||
"//services/device/vibration/android:vibration_jni_headers",
|
"//services/device/vibration/android:vibration_jni_headers",
|
||||||
]
|
]
|
||||||
} else {
|
} else {
|
||||||
|
@@ -110,8 +110,10 @@ static_library("test_support") {
|
|||||||
generate_jni("ui_android_jni_headers") {
|
generate_jni("ui_android_jni_headers") {
|
||||||
sources = [
|
sources = [
|
||||||
"java/src/org/chromium/ui/OverscrollRefreshHandler.java",
|
"java/src/org/chromium/ui/OverscrollRefreshHandler.java",
|
||||||
|
"java/src/org/chromium/ui/base/Clipboard.java",
|
||||||
"java/src/org/chromium/ui/base/EventForwarder.java",
|
"java/src/org/chromium/ui/base/EventForwarder.java",
|
||||||
"java/src/org/chromium/ui/base/LocalizationUtils.java",
|
"java/src/org/chromium/ui/base/LocalizationUtils.java",
|
||||||
|
"java/src/org/chromium/ui/base/SelectFileDialog.java",
|
||||||
"java/src/org/chromium/ui/base/UiAndroidFeatureMap.java",
|
"java/src/org/chromium/ui/base/UiAndroidFeatureMap.java",
|
||||||
"java/src/org/chromium/ui/base/ViewAndroidDelegate.java",
|
"java/src/org/chromium/ui/base/ViewAndroidDelegate.java",
|
||||||
"java/src/org/chromium/ui/base/WindowAndroid.java",
|
"java/src/org/chromium/ui/base/WindowAndroid.java",
|
||||||
@@ -450,8 +452,6 @@ android_library("ui_no_recycler_view_java") {
|
|||||||
"//third_party/androidx:androidx_vectordrawable_vectordrawable_animated_java",
|
"//third_party/androidx:androidx_vectordrawable_vectordrawable_animated_java",
|
||||||
"//third_party/jni_zero:jni_zero_java",
|
"//third_party/jni_zero:jni_zero_java",
|
||||||
"//ui/accessibility:ax_base_java",
|
"//ui/accessibility:ax_base_java",
|
||||||
"//ui/base:clipboard_jni_headers_java",
|
|
||||||
"//ui/base:select_file_dialog_jni_headers_java",
|
|
||||||
"//ui/base/cursor/mojom:cursor_type_java",
|
"//ui/base/cursor/mojom:cursor_type_java",
|
||||||
"//ui/base/ime/mojom:mojom_java",
|
"//ui/base/ime/mojom:mojom_java",
|
||||||
"//url:gurl_java",
|
"//url:gurl_java",
|
||||||
|
@@ -925,20 +925,15 @@ static_library("test_support") {
|
|||||||
if (is_android) {
|
if (is_android) {
|
||||||
generate_jni("ui_base_jni_headers") {
|
generate_jni("ui_base_jni_headers") {
|
||||||
sources = [
|
sources = [
|
||||||
|
"../android/java/src/org/chromium/ui/base/Clipboard.java",
|
||||||
"../android/java/src/org/chromium/ui/base/DeviceFormFactor.java",
|
"../android/java/src/org/chromium/ui/base/DeviceFormFactor.java",
|
||||||
"../android/java/src/org/chromium/ui/base/IdleDetector.java",
|
"../android/java/src/org/chromium/ui/base/IdleDetector.java",
|
||||||
"../android/java/src/org/chromium/ui/base/LocalizationUtils.java",
|
"../android/java/src/org/chromium/ui/base/LocalizationUtils.java",
|
||||||
"../android/java/src/org/chromium/ui/base/ResourceBundle.java",
|
"../android/java/src/org/chromium/ui/base/ResourceBundle.java",
|
||||||
|
"../android/java/src/org/chromium/ui/base/SelectFileDialog.java",
|
||||||
"../android/java/src/org/chromium/ui/base/TouchDevice.java",
|
"../android/java/src/org/chromium/ui/base/TouchDevice.java",
|
||||||
]
|
]
|
||||||
}
|
}
|
||||||
generate_jni("select_file_dialog_jni_headers") {
|
|
||||||
sources =
|
|
||||||
[ "../android/java/src/org/chromium/ui/base/SelectFileDialog.java" ]
|
|
||||||
}
|
|
||||||
generate_jni("clipboard_jni_headers") {
|
|
||||||
sources = [ "../android/java/src/org/chromium/ui/base/Clipboard.java" ]
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
|
|
||||||
bundle_data("ui_base_unittests_bundle_data") {
|
bundle_data("ui_base_unittests_bundle_data") {
|
||||||
|
@@ -178,7 +178,7 @@ component("clipboard") {
|
|||||||
}
|
}
|
||||||
|
|
||||||
if (is_android) {
|
if (is_android) {
|
||||||
deps += [ "//ui/base:clipboard_jni_headers" ]
|
deps += [ "//ui/base:ui_base_jni_headers" ]
|
||||||
}
|
}
|
||||||
|
|
||||||
if (is_mac) {
|
if (is_mac) {
|
||||||
|
@@ -31,8 +31,8 @@
|
|||||||
#include "ui/base/clipboard/clipboard_format_type.h"
|
#include "ui/base/clipboard/clipboard_format_type.h"
|
||||||
#include "ui/base/clipboard/clipboard_metrics.h"
|
#include "ui/base/clipboard/clipboard_metrics.h"
|
||||||
#include "ui/base/clipboard/clipboard_util.h"
|
#include "ui/base/clipboard/clipboard_util.h"
|
||||||
#include "ui/base/clipboard_jni_headers/Clipboard_jni.h"
|
|
||||||
#include "ui/base/data_transfer_policy/data_transfer_endpoint.h"
|
#include "ui/base/data_transfer_policy/data_transfer_endpoint.h"
|
||||||
|
#include "ui/base/ui_base_jni_headers/Clipboard_jni.h"
|
||||||
#include "ui/gfx/android/java_bitmap.h"
|
#include "ui/gfx/android/java_bitmap.h"
|
||||||
#include "ui/gfx/codec/png_codec.h"
|
#include "ui/gfx/codec/png_codec.h"
|
||||||
#include "ui/gfx/image/image.h"
|
#include "ui/gfx/image/image.h"
|
||||||
|
@@ -114,7 +114,7 @@ component("shell_dialogs") {
|
|||||||
]
|
]
|
||||||
deps += [
|
deps += [
|
||||||
"//ui/android",
|
"//ui/android",
|
||||||
"//ui/base:select_file_dialog_jni_headers",
|
"//ui/base:ui_base_jni_headers",
|
||||||
]
|
]
|
||||||
include_dirs = [ "$root_gen_dir/ui" ]
|
include_dirs = [ "$root_gen_dir/ui" ]
|
||||||
libs = [ "jnigraphics" ]
|
libs = [ "jnigraphics" ]
|
||||||
|
@@ -14,7 +14,7 @@
|
|||||||
#include "base/strings/string_util.h"
|
#include "base/strings/string_util.h"
|
||||||
#include "base/strings/utf_string_conversions.h"
|
#include "base/strings/utf_string_conversions.h"
|
||||||
#include "ui/android/window_android.h"
|
#include "ui/android/window_android.h"
|
||||||
#include "ui/base/select_file_dialog_jni_headers/SelectFileDialog_jni.h"
|
#include "ui/base/ui_base_jni_headers/SelectFileDialog_jni.h"
|
||||||
#include "ui/shell_dialogs/select_file_policy.h"
|
#include "ui/shell_dialogs/select_file_policy.h"
|
||||||
#include "ui/shell_dialogs/selected_file_info.h"
|
#include "ui/shell_dialogs/selected_file_info.h"
|
||||||
#include "url/gurl.h"
|
#include "url/gurl.h"
|
||||||
|
Reference in New Issue
Block a user