Fix SameSite WPT window.open() tests
These two tests had a typo in which the `origin` was used as the start and the target of the test navigations. The `target` argument was unused. This CL corrects that and updates the expected results for a couple affected tests. (Plus some comments changes.) Change-Id: I913f927c755ef21f2c6632bc84fca7b624a894a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3290927 Reviewed-by: Mike Taylor <miketaylr@chromium.org> Commit-Queue: Steven Bingler <bingler@chromium.org> Cr-Commit-Position: refs/heads/main@{#943722}
This commit is contained in:

committed by
Chromium LUCI CQ

parent
e836c1e6de
commit
405e57fdbf
third_party/blink/web_tests/external/wpt/cookies/samesite
@@ -17,7 +17,7 @@
|
||||
return resetSameSiteCookies(origin, value)
|
||||
.then(_ => {
|
||||
return new Promise((resolve, reject) => {
|
||||
var w = window.open(origin + "/cookies/resources/postToParent.py");
|
||||
var w = window.open(target + "/cookies/resources/postToParent.py");
|
||||
|
||||
var reloaded = false;
|
||||
var msgHandler = e => {
|
||||
@@ -48,5 +48,5 @@
|
||||
// The reload status is always strictly same-site because this is a site-initiated reload, as opposed to a reload triggered by a user interface element.
|
||||
create_test(SECURE_ORIGIN, SECURE_ORIGIN, SameSiteStatus.STRICT, SameSiteStatus.STRICT, "Reloaded same-host auxiliary navigations are strictly same-site.");
|
||||
create_test(SECURE_SUBDOMAIN_ORIGIN, SECURE_SUBDOMAIN_ORIGIN, SameSiteStatus.STRICT, SameSiteStatus.STRICT, "Reloaded subdomain auxiliary navigations are strictly same-site.");
|
||||
create_test(SECURE_CROSS_SITE_ORIGIN, SECURE_CROSS_SITE_ORIGIN, SameSiteStatus.LAX, SameSiteStatus.STRICT, "Reloaded cross-site auxiliary navigations are laxly same-site");
|
||||
create_test(SECURE_CROSS_SITE_ORIGIN, SECURE_CROSS_SITE_ORIGIN, SameSiteStatus.LAX, SameSiteStatus.STRICT, "Reloaded cross-site auxiliary navigations are strictly same-site");
|
||||
</script>
|
||||
|
@@ -11,7 +11,7 @@
|
||||
return resetSameSiteCookies(origin, value)
|
||||
.then(_ => {
|
||||
return new Promise((resolve, reject) => {
|
||||
var w = window.open(origin + "/cookies/resources/postToParent.py");
|
||||
var w = window.open(target + "/cookies/resources/postToParent.py");
|
||||
|
||||
var msgHandler = e => {
|
||||
window.removeEventListener("message", msgHandler);
|
||||
@@ -40,12 +40,12 @@
|
||||
// Redirect from {same-host,subdomain,cross-site} to same-host:
|
||||
create_test(SECURE_ORIGIN, redirectTo(SECURE_ORIGIN, SECURE_ORIGIN), SameSiteStatus.STRICT, "Same-host redirecting to same-host auxiliary navigations are strictly same-site");
|
||||
create_test(SECURE_ORIGIN, redirectTo(SECURE_SUBDOMAIN_ORIGIN, SECURE_ORIGIN), SameSiteStatus.STRICT, "Subdomain redirecting to same-host auxiliary navigations are strictly same-site");
|
||||
create_test(SECURE_ORIGIN, redirectTo(SECURE_CROSS_SITE_ORIGIN, SECURE_ORIGIN), SameSiteStatus.STRICT, "Cross-site redirecting to same-host auxiliary navigations are strictly same-site");
|
||||
create_test(SECURE_ORIGIN, redirectTo(SECURE_CROSS_SITE_ORIGIN, SECURE_ORIGIN), SameSiteStatus.LAX, "Cross-site redirecting to same-host auxiliary navigations are laxly same-site");
|
||||
|
||||
// Redirect from {same-host,subdomain,cross-site} to same-host:
|
||||
create_test(SECURE_SUBDOMAIN_ORIGIN, redirectTo(SECURE_ORIGIN, SECURE_SUBDOMAIN_ORIGIN), SameSiteStatus.STRICT, "Same-host redirecting to subdomain auxiliary navigations are strictly same-site");
|
||||
create_test(SECURE_SUBDOMAIN_ORIGIN, redirectTo(SECURE_SUBDOMAIN_ORIGIN, SECURE_SUBDOMAIN_ORIGIN), SameSiteStatus.STRICT, "Subdomain redirecting to subdomain auxiliary navigations are strictly same-site");
|
||||
create_test(SECURE_SUBDOMAIN_ORIGIN, redirectTo(SECURE_CROSS_SITE_ORIGIN, SECURE_SUBDOMAIN_ORIGIN), SameSiteStatus.STRICT, "Cross-site redirecting to subdomain auxiliary navigations are strictly same-site");
|
||||
create_test(SECURE_SUBDOMAIN_ORIGIN, redirectTo(SECURE_CROSS_SITE_ORIGIN, SECURE_SUBDOMAIN_ORIGIN), SameSiteStatus.LAX, "Cross-site redirecting to subdomain auxiliary navigations are laxly same-site");
|
||||
|
||||
// Redirect from {same-host,subdomain,cross-site} to cross-site:
|
||||
create_test(SECURE_CROSS_SITE_ORIGIN, redirectTo(SECURE_ORIGIN, SECURE_CROSS_SITE_ORIGIN), SameSiteStatus.LAX, "Same-host redirecting to cross-site auxiliary navigations are laxly same-site");
|
||||
|
Reference in New Issue
Block a user