0

Consistently refer to ISO 32000-1:2008.

Stay consistent with https://pdfium-review.googlesource.com/85978

Change-Id: I12df3c20e373fc70e640ca9e4e9e98412e7319dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3229082
Reviewed-by: Daniel Hosseinian <dhoss@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/main@{#932569}
This commit is contained in:
Lei Zhang
2021-10-18 17:29:53 +00:00
committed by Chromium LUCI CQ
parent 52899ceff2
commit 448c429ba3
4 changed files with 12 additions and 12 deletions

@ -40,7 +40,7 @@ enum class FormType {
// Document properties, including those specified in the document information // Document properties, including those specified in the document information
// dictionary (see section 14.3.3 "Document Information Dictionary" of the ISO // dictionary (see section 14.3.3 "Document Information Dictionary" of the ISO
// 32000-1 standard). // 32000-1:2008 spec).
struct DocumentMetadata { struct DocumentMetadata {
DocumentMetadata(); DocumentMetadata();
DocumentMetadata(const DocumentMetadata&) = delete; DocumentMetadata(const DocumentMetadata&) = delete;
@ -57,15 +57,15 @@ struct DocumentMetadata {
size_t page_count = 0; size_t page_count = 0;
// Whether the document is optimized by linearization (see annex F "Linearized // Whether the document is optimized by linearization (see annex F "Linearized
// PDF" of the ISO 32000-1 standard). // PDF" of the ISO 32000-1:2008 spec).
bool linearized = false; bool linearized = false;
// Whether the document contains file attachments (see section 12.5.6.15 "File // Whether the document contains file attachments (see section 12.5.6.15 "File
// Attachment Annotations" of the ISO 32000-1 standard). // Attachment Annotations" of the ISO 32000-1:2008 spec).
bool has_attachments = false; bool has_attachments = false;
// Whether the document is tagged (see section 14.8 "Tagged PDF" of the ISO // Whether the document is tagged (see section 14.8 "Tagged PDF" of the ISO
// 32000-1 standard). // 32000-1:2008 spec).
bool tagged = false; bool tagged = false;
// The type of form contained in the document. // The type of form contained in the document.

@ -69,9 +69,9 @@ class DateDeserializer final {
}; };
// Parses the offset info in `deserializer`, which is the time offset portion of // Parses the offset info in `deserializer`, which is the time offset portion of
// the date format provided in section 7.9.4 "Dates" of the ISO 32000-1 // the date format provided in section 7.9.4 "Dates" of the ISO 32000-1:2008
// standard. An input is expected to look like "HH'mm", such that "HH" is the // spec. An input is expected to look like "HH'mm", such that "HH" is the hour
// hour and "mm" is the minute. // and "mm" is the minute.
base::TimeDelta ParseOffset(DateDeserializer& deserializer) { base::TimeDelta ParseOffset(DateDeserializer& deserializer) {
base::TimeDelta offset; base::TimeDelta offset;

@ -14,8 +14,8 @@ class Time;
namespace chrome_pdf { namespace chrome_pdf {
// Parses a string in the PDF date format (see section 7.9.4 "Dates" of the ISO // Parses a string in the PDF date format (see section 7.9.4 "Dates" of the ISO
// 32000-1 standard). If `date` cannot be parsed, returns a "null" time (one for // 32000-1:2008 spec). If `date` cannot be parsed, returns a "null" time (one
// which `base::Time::is_null()` returns `true`). // for which `base::Time::is_null()` returns `true`).
base::Time ParsePdfDate(base::StringPiece date); base::Time ParsePdfDate(base::StringPiece date);
} // namespace chrome_pdf } // namespace chrome_pdf

@ -1282,9 +1282,9 @@ void PDFiumPage::PopulateHighlight(FPDF_ANNOTATION annot) {
highlight.color = MakeARGB(255, 255, 255, 0); highlight.color = MakeARGB(255, 255, 255, 0);
} }
// Retrieve the contents of the popup note associated with highlight. // Retrieve the contents of the popup note associated with highlight. See
// See table 164 in ISO 32000-1 standard for more details around "Contents" // table 164 in ISO 32000-1:2008 spec for more details around "Contents" key
// key in a highlight annotation. // in a highlight annotation.
static constexpr char kContents[] = "Contents"; static constexpr char kContents[] = "Contents";
highlight.note_text = base::UTF16ToUTF8(CallPDFiumWideStringBufferApi( highlight.note_text = base::UTF16ToUTF8(CallPDFiumWideStringBufferApi(
base::BindRepeating(&FPDFAnnot_GetStringValue, annot, kContents), base::BindRepeating(&FPDFAnnot_GetStringValue, annot, kContents),