chromium/src
0
Fork 0
Code Activity

[PDF Ink Signatures] Add a feature param for text annotations

Browse Source 
Bug: 402547554
Change-Id: I734b67bd84a96fef3db234606934b1b16af48339
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6394364
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Auto-Submit: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1438832}
This commit is contained in:
rbpotter
2025-03-27 09:57:02 -07:00
committed by Chromium LUCI CQ
parent 865e0e310e
commit 480bfec7ad
3 changed files with 8 additions and 0 deletions

3
chrome/browser/pdf/pdf_extension_util.cc

@@ -261,6 +261,9 @@ void AddAdditionalData(bool enable_printing,
annotations_enabled = enable_annotations; annotations_enabled = enable_annotations;
} }
dict->Set("pdfInk2Enabled", use_ink2); dict->Set("pdfInk2Enabled", use_ink2);
bool text_annotations_enabled =
use_ink2 && chrome_pdf::features::kPdfInk2TextAnnotations.Get();
dict->Set("pdfTextAnnotationsEnabled", text_annotations_enabled);
#endif // BUILDFLAG(ENABLE_PDF_INK2) #endif // BUILDFLAG(ENABLE_PDF_INK2)
dict->Set("printingEnabled", printing_enabled); dict->Set("printingEnabled", printing_enabled);
dict->Set("pdfAnnotationsEnabled", annotations_enabled); dict->Set("pdfAnnotationsEnabled", annotations_enabled);

4
pdf/pdf_features.cc

@@ -75,6 +75,10 @@ BASE_FEATURE(kPdfXfaSupport,
#if BUILDFLAG(ENABLE_PDF_INK2) #if BUILDFLAG(ENABLE_PDF_INK2)
BASE_FEATURE(kPdfInk2, "PdfInk2", base::FEATURE_DISABLED_BY_DEFAULT); BASE_FEATURE(kPdfInk2, "PdfInk2", base::FEATURE_DISABLED_BY_DEFAULT);
// Enables text annotations.
const base::FeatureParam<bool> kPdfInk2TextAnnotations{
&kPdfInk2, "text-annotations", false};
// Enables text highlighting with the Ink highlighter brush. // Enables text highlighting with the Ink highlighter brush.
const base::FeatureParam<bool> kPdfInk2TextHighlighting{ const base::FeatureParam<bool> kPdfInk2TextHighlighting{
&kPdfInk2, "text-highlighting", false}; &kPdfInk2, "text-highlighting", false};

1
pdf/pdf_features.h

@@ -33,6 +33,7 @@ BASE_DECLARE_FEATURE(kPdfXfaSupport);
#if BUILDFLAG(ENABLE_PDF_INK2) #if BUILDFLAG(ENABLE_PDF_INK2)
BASE_DECLARE_FEATURE(kPdfInk2); BASE_DECLARE_FEATURE(kPdfInk2);
extern const base::FeatureParam<bool> kPdfInk2TextAnnotations;
extern const base::FeatureParam<bool> kPdfInk2TextHighlighting; extern const base::FeatureParam<bool> kPdfInk2TextHighlighting;
#endif #endif