0

DanglingPtr: Mark all of them as untriaged [20/N]

This patch is a no-op with all the common build flags.

Add the "DanglingUntriaged" raw_ptr annotation. It indicates a raw_ptr
becomes dangling, and it should be triaged/fixed. This will also disable
dangling detection for those pointers, once enabled.

These were identified by running the lacros-arm-generic-rel CQ bot with
DPD activated (both build + runtime here: https://crrev.com/c/3941825)

Bug: 1291138
Change-Id: I794fc28f0a9ace8b2cf5dfd14e9391896ac1fd55
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4083425
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Owners-Override: Arthur Sonzogni <arthursonzogni@chromium.org>
Commit-Queue: Ali Hijazi <ahijazi@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1080246}
This commit is contained in:
Ali Hijazi
2022-12-07 09:33:58 +00:00
committed by Chromium LUCI CQ
parent 8323d1c115
commit 4d98c3e55f
3 changed files with 4 additions and 4 deletions
dbus
gpu/command_buffer/service/shared_image

@@ -333,7 +333,7 @@ class CHROME_DBUS_EXPORT ObjectManager final
std::string service_name_owner_; std::string service_name_owner_;
std::string match_rule_; std::string match_rule_;
ObjectPath object_path_; ObjectPath object_path_;
raw_ptr<ObjectProxy> object_proxy_; raw_ptr<ObjectProxy, DanglingUntriaged> object_proxy_;
bool setup_success_; bool setup_success_;
bool cleanup_called_; bool cleanup_called_;
@@ -349,7 +349,7 @@ class CHROME_DBUS_EXPORT ObjectManager final
Object(); Object();
~Object(); ~Object();
raw_ptr<ObjectProxy> object_proxy; raw_ptr<ObjectProxy, DanglingUntriaged> object_proxy;
// Maps the name of an interface to the specific PropertySet structure // Maps the name of an interface to the specific PropertySet structure
// of that interface's properties. // of that interface's properties.

@@ -333,7 +333,7 @@ class CHROME_DBUS_EXPORT PropertySet {
// Pointer to object proxy for making method calls, no ownership is taken // Pointer to object proxy for making method calls, no ownership is taken
// so this must outlive this class. // so this must outlive this class.
raw_ptr<ObjectProxy> object_proxy_; raw_ptr<ObjectProxy, DanglingUntriaged> object_proxy_;
// Interface of property, e.g. "org.chromium.ExampleService", this is // Interface of property, e.g. "org.chromium.ExampleService", this is
// distinct from the interface of the method call itself which is the // distinct from the interface of the method call itself which is the

@@ -43,7 +43,7 @@ class GLOzoneImageRepresentationShared {
bool context_lost_ = false; bool context_lost_ = false;
std::unique_ptr<ui::NativePixmapGLBinding> binding_; std::unique_ptr<ui::NativePixmapGLBinding> binding_;
raw_ptr<gles2::Texture> texture_ = nullptr; raw_ptr<gles2::Texture, DanglingUntriaged> texture_ = nullptr;
scoped_refptr<gles2::TexturePassthrough> texture_passthrough_; scoped_refptr<gles2::TexturePassthrough> texture_passthrough_;
}; };