Updates lacros.md slightly.
- Now OS_CHROMEOS macros are being replaced by BUILDFLAG(IS_CHROMEOS). - Text decoration update. - Removed unneeded trailing white spaces. BUG=None TEST=None Change-Id: Iafda8a4b4b57aace6fa89fd064fe5925a11b9d42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3478998 Auto-Submit: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by: Andrew Moylan <amoylan@chromium.org> Commit-Queue: Andrew Moylan <amoylan@chromium.org> Cr-Commit-Position: refs/heads/main@{#973619}
This commit is contained in:

committed by
Chromium LUCI CQ

parent
161398713a
commit
51292b5e41
@@ -51,9 +51,9 @@ The ash-side implementation lives in
|
|||||||
[//chrome/browser/ash/crosapi](https://chromium.googlesource.com/chromium/src.git/+/main/chrome/browser/ash/crosapi).
|
[//chrome/browser/ash/crosapi](https://chromium.googlesource.com/chromium/src.git/+/main/chrome/browser/ash/crosapi).
|
||||||
|
|
||||||
Code can be conditionally compiled into lacros via
|
Code can be conditionally compiled into lacros via
|
||||||
BUILDFLAG(IS_CHROMEOS_LACROS).
|
`BUILDFLAG(IS_CHROMEOS_LACROS)`.
|
||||||
|
|
||||||
## Filing bugs
|
## Filing bugs
|
||||||
|
|
||||||
Lacros bugs should be filed under OS=Lacros
|
Lacros bugs should be filed under OS=Lacros
|
||||||
|
|
||||||
@@ -61,31 +61,31 @@ Bugs in the ash-chrome binary that only affect ash-chrome should be labeled OS=C
|
|||||||
|
|
||||||
Bugs in the lacros-chrome binary that only affect lacros-chrome should be labeled OS=Lacros.
|
Bugs in the lacros-chrome binary that only affect lacros-chrome should be labeled OS=Lacros.
|
||||||
|
|
||||||
Bugs in the ash-chrome binary that affect lacros-chrome should be labeled with both OS=Chrome and OS=Lacros.
|
Bugs in the ash-chrome binary that affect lacros-chrome should be labeled with both OS=Chrome and OS=Lacros.
|
||||||
These should not block ash-chrome releases in the short term, but should block ash-chrome releases in the long term.
|
These should not block ash-chrome releases in the short term, but should block ash-chrome releases in the long term.
|
||||||
|
|
||||||
Bug in the lacros-chrome binary that affects ash-chrome: should not be possible. If lacros-chrome causes bugs in ash-chrome, then there must be a corresponding bug in ash-chrome as well.
|
Bug in the lacros-chrome binary that affects ash-chrome: should not be possible. If lacros-chrome causes bugs in ash-chrome, then there must be a corresponding bug in ash-chrome as well.
|
||||||
The lacros-chrome bug should be labeled OS=Lacros and the ash-chrome bug should be labeled OS=Chrome.
|
The lacros-chrome bug should be labeled OS=Lacros and the ash-chrome bug should be labeled OS=Chrome.
|
||||||
|
|
||||||
Cross-platform browser bugs e.g. Blink bug should set both OS=Lacros and OS=Chrome in the short term, since we are supporting both ash and lacros as browsers in the short term.
|
Cross-platform browser bugs e.g. Blink bug should set both OS=Lacros and OS=Chrome in the short term, since we are supporting both ash and lacros as browsers in the short term.
|
||||||
Once Lacros launches, the plan to use Lacros vs Chrome will be finalized.
|
Once Lacros launches, the plan to use Lacros vs Chrome will be finalized.
|
||||||
|
|
||||||
|
|
||||||
## GN var and C++ macros
|
## GN var and C++ macros
|
||||||
|
|
||||||
Both lacros and ash are built with gn arg `target_os="chromeos"`. This means
|
Both lacros and ash are built with gn arg `target_os="chromeos"`. This means
|
||||||
that C++ macro defined(OS_CHROMEOS) and gn variable is_chromeos are set true for
|
that C++ macro `BUILDFLAG(IS_CHROMEOS)` (and `defined(OS_CHROMEOS)` for old code)
|
||||||
both lacros and ash.
|
and gn variable is_chromeos are set true for both lacros and ash.
|
||||||
|
|
||||||
### Targeting ash or lacros
|
### Targeting ash or lacros
|
||||||
To target lacros or ash separately, use BUILDFLAG(IS_CHROMEOS_LACROS),
|
To target lacros or ash separately, use `BUILDFLAG(IS_CHROMEOS_LACROS)`,
|
||||||
BUILDFLAG(IS_CHROMEOS_ASH) in C++ files and is_chromeos_lacros and
|
`BUILDFLAG(IS_CHROMEOS_ASH)` in C++ files and is_chromeos_lacros and
|
||||||
is_chromeos_ash in gn files.
|
is_chromeos_ash in gn files.
|
||||||
|
|
||||||
Note that these are not defined globally and must be included manually.
|
Note that these are not defined globally and must be included manually.
|
||||||
|
|
||||||
To use the buildflags in C++ files, add #include "build/chromeos_buildflags.h"
|
To use the buildflags in C++ files, add `#include "build/chromeos_buildflags.h"`
|
||||||
and then also add "//build:chromeos_buildflags" to deps of the target that is
|
and then also add `"//build:chromeos_buildflags"` to deps of the target that is
|
||||||
using the update C++ files inside gn files. See e.g. crrev.com/c/2494186.
|
using the update C++ files inside gn files. See e.g. crrev.com/c/2494186.
|
||||||
|
|
||||||
To use the gn variables add `import("//build/config/chromeos/ui_mode.gni")`.
|
To use the gn variables add `import("//build/config/chromeos/ui_mode.gni")`.
|
||||||
@@ -118,5 +118,5 @@ If you're sshing to your desktop, please prefix the command with
|
|||||||
|
|
||||||
For sheriffs: Test failures that should have been caught by the CQ should be
|
For sheriffs: Test failures that should have been caught by the CQ should be
|
||||||
treated like test failures on any other platform: investigated and fixed or
|
treated like test failures on any other platform: investigated and fixed or
|
||||||
disabled. Use BUILDFLAG(IS_LACROS) to disable a test just for lacros. See the
|
disabled. Use `BUILDFLAG(IS_CHROMEOS_LACROS)` to disable a test just for lacros. See the
|
||||||
[sheriffing how-to](http://go/chrome-sheriffing-how-to#test-failed).
|
[sheriffing how-to](http://go/chrome-sheriffing-how-to#test-failed).
|
||||||
|
Reference in New Issue
Block a user