0

[tracing] Hoist (over)scroll unused delta tracing

This CL removes the following arguments from
InputHandlerProxy::DidOverscroll():

  debug.dx
  debug.dy

and adds the following arguments to
InputHandlerProxy::HandleGestureScrollUpdate_Result instead:

  scroll_deltas.did_overscroll_root
  scroll_deltas.unused_delta_x
  scroll_deltas.unused_delta_y

This has two benefits:

  1. We will be able to get unused deltas from field traces.
  2. The unused delta will be logged together with other scroll
     delta-related information (so less work will be required at
     analysis time).

PERFETTO_TESTS=`autoninja -C out/Default perfetto_diff_tests && out/Default/bin/run_perfetto_diff_tests`

Bug: b:394015537
Change-Id: I4db6a11cbc8c0fe5df7a6c8573e9b3f1ee0391ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6225802
Commit-Queue: Petr Cermak <petrcermak@chromium.org>
Auto-Submit: Petr Cermak <petrcermak@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1416157}
This commit is contained in:
Petr Cermak
2025-02-05 07:50:44 -08:00
committed by Chromium LUCI CQ
parent 362b373187
commit 5a940d8407
3 changed files with 18 additions and 11 deletions
base/tracing/protos
services/tracing/perfetto
third_party/blink/renderer/platform/widget/input

@ -380,8 +380,8 @@ constexpr MessageInfo kTabSwitchMeasurement = {kTabSwitchMeasurementIndices,
nullptr};
// Proto Message: ScrollDeltas
constexpr int kScrollDeltasIndices[] = {1, 2, 3, 4, 5, 6, 7, 8,
9, 10, 11, 12, 13, 14, -1};
constexpr int kScrollDeltasIndices[] = {1, 2, 3, 4, 5, 6, 7, 8, 9,
10, 11, 12, 13, 14, 15, 16, 17, -1};
constexpr MessageInfo kScrollDeltas = {kScrollDeltasIndices, nullptr};
// Proto Message: WinRenderAudioFromSource