0

Update references to "Tools/Scripts"

All code in third_party/WebKit/Tools/Scripts was moved to
third_party/blink/tools.
This CL also fixes references to old names of scripts in Tools/Scripts.

* third_party/WebKit/PRESUBMIT.py:
 Remove dead code. This PRESUBMIT.py doesn't use
 |audit_non_blink_usage|.

Bug: 829697
Change-Id: I6c482a795708fa207124cb2030a4fdaa8ceac343
Reviewed-on: https://chromium-review.googlesource.com/1038863
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555366}
This commit is contained in:
Kent Tamura
2018-05-02 13:05:00 +00:00
committed by Commit Bot
parent 21c872843e
commit 5e69e91171
10 changed files with 15 additions and 28 deletions
BUILD.gn
docs/testing
third_party
WebKit
blink
sqlite

@@ -872,7 +872,7 @@ if (!is_ios) {
} }
# Layout tests runner # Layout tests runner
# third_party/WebKit/Tools/Scripts/run-webkit-tests # third_party/blink/tools/run_web_tests.py
group("run_webkit_tests") { group("run_webkit_tests") {
testonly = true testonly = true
deps = [ deps = [

@@ -93,7 +93,7 @@ For maintainers:
- The exporter runs continuously under the - The exporter runs continuously under the
[chromium.infra.cron master](https://build.chromium.org/p/chromium.infra.cron/builders/wpt-exporter). [chromium.infra.cron master](https://build.chromium.org/p/chromium.infra.cron/builders/wpt-exporter).
- The source lives in - The source lives in
[third_party/WebKit/Tools/Scripts/wpt-export](../../third_party/WebKit/Tools/Scripts/wpt-export). [third_party/blink/tools/wpt_export.py](../../third_party/blink/tools/wpt_export.py).
- If the exporter starts misbehaving - If the exporter starts misbehaving
(for example, creating the same PR over and over again) (for example, creating the same PR over and over again)
put it in "dry run" mode by landing [this CL](https://crrev.com/c/462381/). put it in "dry run" mode by landing [this CL](https://crrev.com/c/462381/).
@@ -133,7 +133,7 @@ unauthenticated requests, so it is recommended that you let `wpt-export` and
To pull the latest versions of the tests that are currently being imported, you To pull the latest versions of the tests that are currently being imported, you
can also directly invoke the can also directly invoke the
[wpt-import](../../third_party/WebKit/Tools/Scripts/wpt-import) script. [wpt-import](../../third_party/blink/tools/wpt_import.py) script.
That script will pull the latest version of the tests from our mirrors of the That script will pull the latest version of the tests from our mirrors of the
upstream repositories. If any new versions of tests are found, they will be upstream repositories. If any new versions of tests are found, they will be

@@ -587,7 +587,7 @@ crbug.com/538697 [ Win ] printing/webgl-oversized-printing.html [ Failure Crash
# development, just marking failed tests here is fine enough for tests under # development, just marking failed tests here is fine enough for tests under
# virtual/outofblink-cors. # virtual/outofblink-cors.
# #
# ./Tools/Scripts/run_web_tests.py virtual/outofblink-cors # ./tools/run_web_tests.py virtual/outofblink-cors
# Found 2061 tests; running 2060, skipping 1. # Found 2061 tests; running 2060, skipping 1.
# 2060 tests ran as expected (1968 passed, 92 didn't). # 2060 tests ran as expected (1968 passed, 92 didn't).

@@ -4,8 +4,8 @@ The tests in wpt are imported from https://github.com/w3c/web-platform-tests,
and changes in the wpt directory are automatically upstreamed, usually within and changes in the wpt directory are automatically upstreamed, usually within
24 hours. 24 hours.
Use Tools/Scripts/wpt-import to update the tests from the tip of tree Use tools/wpt_import.py to update the tests from the tip of tree in those
in those repositories. repositories.
It is safe and okay to check in generic baselines for any tests that fail. It is safe and okay to check in generic baselines for any tests that fail.
The baselines will not be overwritten or upstreamed. The baselines will not be overwritten or upstreamed.

@@ -8,20 +8,7 @@ See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
for more details about the presubmit API built into gcl. for more details about the presubmit API built into gcl.
""" """
import imp
import inspect
import os import os
import re
try:
# pylint: disable=C0103
audit_non_blink_usage = imp.load_source(
'audit_non_blink_usage',
os.path.join(os.path.dirname(inspect.stack()[0][1]), 'Tools/Scripts/audit-non-blink-usage.py'))
except IOError:
# One of the presubmit upload tests tries to exec this script, which doesn't interact so well
# with the import hack... just ignore the exception here and hope for the best.
pass
def _CommonChecks(input_api, output_api): def _CommonChecks(input_api, output_api):

@@ -4,7 +4,7 @@
<body> <body>
<p>Same-document navigation in onload triggered by back navigation.</p> <p>Same-document navigation in onload triggered by back navigation.</p>
<ol> <ol>
<li>Start the layout test web server with Tools/Scripts/run-webkit-httpd.</li> <li>Start the layout test web server with tools/run_blink_httpd.py.</li>
<li>Click <a href="resources/navigation-during-onload-container.html">here</a>.</li> <li>Click <a href="resources/navigation-during-onload-container.html">here</a>.</li>
<li>Click Back.</li> <li>Click Back.</li>
</ol> </ol>

@@ -95,7 +95,7 @@ defined in Chromium. For example, Blink should not use std::vector
(except places where a conversion between std::vector and WTF::Vector is needed). (except places where a conversion between std::vector and WTF::Vector is needed).
To prevent use of random types, we control allowed types by whitelisting To prevent use of random types, we control allowed types by whitelisting
them in DEPS and a [presubmit script](../Tools/Scripts/audit-non-blink-usage.py). them in DEPS and a [presubmit script](../tools/audit_non_blink_usage.py).
## Mojo ## Mojo

@@ -42,10 +42,10 @@ import sys
import types import types
# Since we execute this script directly as part of the unit tests, we need to ensure # Since we execute this script directly as part of the unit tests, we need to ensure
# that Tools/Scripts is in sys.path for the next imports to work correctly. # that blink/tools is in sys.path for the next imports to work correctly.
script_dir = os.path.dirname(os.path.dirname(os.path.dirname(os.path.dirname(os.path.abspath(__file__))))) tools_dir = os.path.dirname(os.path.dirname(os.path.dirname(os.path.dirname(os.path.abspath(__file__)))))
if script_dir not in sys.path: if tools_dir not in sys.path:
sys.path.append(script_dir) sys.path.append(tools_dir)
from blinkpy.common import exit_codes from blinkpy.common import exit_codes
from blinkpy.common import read_checksum_from_png from blinkpy.common import read_checksum_from_png

@@ -28,8 +28,8 @@
"""A utility module for making standalone scripts to start servers. """A utility module for making standalone scripts to start servers.
Scripts in Tools/Scripts can use this module to start servers that Scripts in tools/ can use this module to start servers that are normally used
are normally used for layout tests, outside of the layout test runner. for layout tests, outside of the layout test runner.
""" """
import argparse import argparse

@@ -217,7 +217,7 @@ ninja -C out/Default
# Only "_fini" and "_init" should be unprefixed. # Only "_fini" and "_init" should be unprefixed.
nm -B out/Default/libchromium_sqlite3.so | cut -c 18- | sort | grep '^T' nm -B out/Default/libchromium_sqlite3.so | cut -c 18- | sort | grep '^T'
out/Default/sql_unittests out/Default/sql_unittests
third_party/WebKit/Tools/Scripts/run-webkit-tests -t Default storage/websql/* third_party/blink/tools/run_web_tests.py -t Default storage/websql/*
cd third_party/sqlite cd third_party/sqlite
#### Create the review. #### Create the review.