Rename WebsiteSettings code to PageInfo.
This was automated using a script [1] that does the following: - Rename relevant files in the following folders from website_settings* to page_info*: - chrome/browser/ui/page_info - chrome/browser/ui/cocoa/page_info - chrome/browser/ui/views/page_info - chrome/browser/ui/android/page_info - chrome/android/java/res/layout - Run `./tools/git/mass-rename.py` to update e.g. includes, build files, header guards. - mass-rename.py does not handle test files (https://crbug.com/701529) or Java, so those are handled separately, either in an early step are as part of the later renames. - `page_info_bubble_controller.h` needs a separate header guard fix. - Use `sed` to rename classes, enums, non-UMA strings, and comments *WebsiteSettings* to *PageInfo* across the entire Chromium project. - Since several content settings classes are also called "WebsiteSettings", this is done by taking a full list of all occurrences of full tokens containing "WebsiteSettings", "website_settings", or "website settings" and whitelisting individual replacements. - To avoid modifying strings, all lines containing the relevant tokens *following at least one quote mark on the same line* are preserved, except two individually handled cases. There do not appear to be any affected multi-line strings. - `git cl format` - Remove two long-standing TODO comments about this rename, in: - PageInfoPopup.java - page_info_bubble_controller.h This CL does not attempt to reflow comments; all changes stay within 80 lines, though. [1] https://github.com/lgarron/website-settings-to-page-info/blob/master/page_info.fish BUG=571506 TBR=jochen@chromium.org Review-Url: https://codereview.chromium.org/2754383004 Cr-Commit-Position: refs/heads/master@{#459562}
This commit is contained in:
build/android/pylib/gtest/filter
chrome
BUILD.gn
android
BUILD.gn
java
java_sources.gniapp
browser
BUILD.gn
android
chromeos
ui
BUILD.gn
android
page_info
autofill
browser_commands.ccbrowser_commands.hbrowser_dialogs.hbrowser_window.hcocoa
browser_window_cocoa.hbrowser_window_cocoa.mm
location_bar
page_info
page_info_bubble_controller.hpage_info_bubble_controller.mmpage_info_bubble_controller_unittest.mmpage_info_utils_cocoa.hpage_info_utils_cocoa.mmpermission_selector_button.hpermission_selector_button.mmpermission_selector_button_unittest.mmwebsite_settings_utils_cocoa.h
permission_bubble
login
page_info
page_info.ccpage_info.hpage_info_infobar_delegate.ccpage_info_infobar_delegate.hpage_info_ui.ccpage_info_ui.hpage_info_unittest.ccpermission_menu_model.ccpermission_menu_model.hpermission_menu_model_unittest.cc
views
browser_dialogs_views_mac.cc
frame
location_bar
page_info
chosen_object_row.ccchosen_object_row.hchosen_object_row_observer.hpage_info_popup_view.ccpage_info_popup_view.hpage_info_popup_view_interactive_uitest.ccpage_info_popup_view_unittest.ccpermission_selector_row.ccpermission_selector_row.hpermission_selector_row_observer.h
permission_bubble
toolbar
webui
vr_shell
test
components
docs/ui/views
ios/chrome/browser/ui/dialogs
tools/metrics
@ -35,7 +35,7 @@ dialogs are:
|
||||
5. One-click signin
|
||||
6. Site permissions bubble
|
||||
7. "Card unmask prompt" (TODO(ellyjones): what is this?)
|
||||
8. Website settings dialog
|
||||
8. Page info dialog
|
||||
|
||||
Once all of these dialogs are converted and tested behind the feature, we can
|
||||
ship to canary and dev channels and watch for any performance or crash rate
|
||||
|
Reference in New Issue
Block a user