chromium/src
0
Fork 0
Code Activity

Set v8_use_external_startup_data for GN Windows build.

Browse Source 
This matches GYP.

BUG=545641
R=dpranke@chromium.org

Review URL: https://codereview.chromium.org/1495673002

Cr-Commit-Position: refs/heads/master@{#362804}
This commit is contained in:
brettw
2015-12-02 14:03:27 -08:00
committed by Commit bot
parent 7ff79f9569
commit 62fbdbc1e9
2 changed files with 12 additions and 12 deletions
build_overrides
v8.gni
chrome/installer/mini_installer
BUILD.gn

3
build_overrides/v8.gni

@@ -11,9 +11,8 @@ enable_correct_v8_arch = false
# TODO: Set v8_use_external_startup_data to true on Windows and iOS to match # TODO: Set v8_use_external_startup_data to true on Windows and iOS to match
# GYP. # GYP.
# Windows - http://crbug.com/545641
# iOS - http://crbug.com/545676 # iOS - http://crbug.com/545676
v8_use_external_startup_data = !(is_win || is_ios) v8_use_external_startup_data = !is_ios
# V8 extras # V8 extras
# Adding V8 extras files requires API owners review # Adding V8 extras files requires API owners review

21
chrome/installer/mini_installer/BUILD.gn

@@ -115,6 +115,16 @@ action("archive") {
#'--verbose', #'--verbose',
] ]
deps = [
"//chrome",
"//chrome:main_dll",
"//chrome/browser/extensions/default_extensions",
"//chrome/installer/setup",
"//third_party/icu:icudata",
#"../chrome.gyp:chrome_nacl_win64", TODO(GYP) bug 512869.
]
if (enable_hidpi) { if (enable_hidpi) {
args += [ "--enable_hidpi=1" ] args += [ "--enable_hidpi=1" ]
} }
@@ -145,6 +155,7 @@ action("archive") {
"$root_out_dir/natives_blob.bin", "$root_out_dir/natives_blob.bin",
"$root_out_dir/snapshot_blob.bin", "$root_out_dir/snapshot_blob.bin",
] ]
deps += [ "//v8" ]
} }
depfile = "$target_gen_dir/archive.d" depfile = "$target_gen_dir/archive.d"
@@ -153,16 +164,6 @@ action("archive") {
rebase_path(depfile, root_build_dir), rebase_path(depfile, root_build_dir),
] ]
deps = [
"//chrome",
"//chrome:main_dll",
"//chrome/browser/extensions/default_extensions",
"//chrome/installer/setup",
"//third_party/icu:icudata",
#"../chrome.gyp:chrome_nacl_win64", TODO(GYP) bug 512869.
]
if (enable_nacl) { if (enable_nacl) {
deps += [ "//ppapi/native_client:irt" ] deps += [ "//ppapi/native_client:irt" ]
} }