chromium/src
0
Fork 0
Code Activity

webauthn: wire up residentKey=preferred on Windows.

Browse Source 
All the plumbing already existed for other platforms. This connects it
up for the Windows webauthn.dll API.

Change-Id: I40936e9a973bb74ff21982c7d0cc3d5dff0b55d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3269045
Commit-Queue: Adam Langley <agl@chromium.org>
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Auto-Submit: Adam Langley <agl@chromium.org>
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Cr-Commit-Position: refs/heads/main@{#939607}
This commit is contained in:
Adam Langley
2021-11-09 00:25:57 +00:00
committed by Chromium LUCI CQ
parent 88e55be071
commit 688fff9ef5
2 changed files with 3 additions and 1 deletions

1
device/fido/win/type_conversions.cc

@@ -83,6 +83,7 @@ ToAuthenticatorMakeCredentialResponse(
if (credential_attestation.dwVersion >= if (credential_attestation.dwVersion >=
WEBAUTHN_CREDENTIAL_ATTESTATION_VERSION_4) { WEBAUTHN_CREDENTIAL_ATTESTATION_VERSION_4) {
ret.enterprise_attestation_returned = credential_attestation.bEpAtt; ret.enterprise_attestation_returned = credential_attestation.bEpAtt;
ret.is_resident_key = credential_attestation.bResidentKey;
} }
return ret; return ret;

3
device/fido/win/webauthn_api.cc

@@ -355,7 +355,8 @@ AuthenticatorMakeCredentialBlocking(WinWebAuthnApi* webauthn_api,
&exclude_credential_list, &exclude_credential_list,
enterprise_attestation, enterprise_attestation,
WEBAUTHN_LARGE_BLOB_SUPPORT_NONE, WEBAUTHN_LARGE_BLOB_SUPPORT_NONE,
/*bPreferResidentKey=*/FALSE, /*bPreferResidentKey=*/request_options.resident_key ==
ResidentKeyRequirement::kPreferred,
}; };
WEBAUTHN_CREDENTIAL_ATTESTATION* credential_attestation = nullptr; WEBAUTHN_CREDENTIAL_ATTESTATION* credential_attestation = nullptr;