From 707a5224e63dbf18281a5c87b51a70590b89373e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bence=20B=C3=A9ky?= <bnc@chromium.org>
Date: Mon, 13 Jun 2022 20:46:47 +0000
Subject: [PATCH] Add two checks to help debug crash on iOS.
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Bug: 1335423
Change-Id: Iba915ca20870e7d27505e6b4a758404c51fba1d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3698876
Reviewed-by: David Schinazi <dschinazi@chromium.org>
Commit-Queue: Bence Béky <bnc@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1013640}
---
net/http/http_network_transaction.cc | 4 +++-
net/quic/quic_chromium_client_stream.cc | 4 ++++
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/net/http/http_network_transaction.cc b/net/http/http_network_transaction.cc
index 5f530c81fcc34..29fe1a6c7d62d 100644
--- a/net/http/http_network_transaction.cc
+++ b/net/http/http_network_transaction.cc
@@ -1281,7 +1281,9 @@ int HttpNetworkTransaction::DoReadHeadersComplete(int result) {
int HttpNetworkTransaction::DoReadBody() {
DCHECK(read_buf_.get());
- DCHECK_GT(read_buf_len_, 0);
+ // TODO(https://crbug.com/1335423): Change to DCHECK_GT() or remove after bug
+ // is fixed.
+ CHECK_GT(read_buf_len_, 0);
DCHECK(stream_ != nullptr);
next_state_ = STATE_READ_BODY_COMPLETE;
diff --git a/net/quic/quic_chromium_client_stream.cc b/net/quic/quic_chromium_client_stream.cc
index 11a2dd570d703..6392c94580706 100644
--- a/net/quic/quic_chromium_client_stream.cc
+++ b/net/quic/quic_chromium_client_stream.cc
@@ -665,6 +665,10 @@ void QuicChromiumClientStream::OnError(int error) {
}
int QuicChromiumClientStream::Read(IOBuffer* buf, int buf_len) {
+ // TODO(https://crbug.com/1335423): Change to DCHECK_GT() or remove after bug
+ // is fixed.
+ CHECK_GT(buf_len, 0);
+
if (IsDoneReading())
return 0; // EOF