Migrate remaining NOTREACHED()s in components/
NOTREACHED() and NOTREACHED_IN_MIGRATION() are both CHECK-fatal now. The former is [[noreturn]] so this CL also performs dead-code removal after the NOTREACHED(). This CL does not attempt to do additional rewrites of any surrounding code, like: if (!foo) { NOTREACHED(); } to CHECK(foo); Those transforms take a non-trivial amount of time (and there are thousands of instances). Cleanup can be left as an exercise for the reader. Bug: 40580068 Change-Id: I72205fb77747957c6bf33dbea93656fd20085a42 Low-Coverage-Reason: OTHER Should-be-unreachable code Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6010008 Reviewed-by: Rick Byers <rbyers@chromium.org> Owners-Override: Rick Byers <rbyers@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/main@{#1382618}
This commit is contained in:

committed by
Chromium LUCI CQ

parent
21b15227e9
commit
77d2135a33
components
account_id
account_manager_core
account_manager_facade_impl.ccaccount_manager_facade_impl_unittest.ccaccount_manager_util.ccaccount_manager_util_unittest.cc
android_autofill
arc
intent_helper
assist_ranker
background_fetch
background_sync
blocked_content
bookmarks
browser
bookmark_client.ccbookmark_codec.ccbookmark_model.ccbookmark_model_unittest.ccbookmark_node_data_ios.ccbookmark_utils.cc
managed
browser_ui
site_settings
android
browsing_data
content
core
browsing_topics
captive_portal
cast
message_port
fuchsia
cast_streaming
browser
renderer
cbor
cdm
chromeos_camera
cloud_devices
common
commerce
content_capture
content_settings
browser
core
browser
content_settings_default_provider.cccontent_settings_policy_provider.cccontent_settings_uma_util.cccontent_settings_utils.cchost_content_settings_map.ccprivate_network_settings.cc
common
renderer
crash
content
browser
core
cronet
desks_storage
device_event_log
device_signals
discardable_memory
dom_distiller
domain_reliability
drive
embedder_support
enterprise
browser
controller
reporting
client_certificates
connectors
core
data_controls
core
browser
error_page
favicon
favicon_base
feature_engagement
feed
core
find_in_page
flags_ui
gcm_driver
crypto
fake_gcm_profile_service.ccgcm_account_tracker.ccgcm_client_impl.ccgcm_desktop_utils.ccgcm_driver.ccgcm_driver_android.ccgcm_stats_recorder_impl.ccinstance_id
global_media_controls
public
guest_view
browser
headless
policy
heap_profiling
history_clusters
core
image_fetcher
invalidation
javascript_dialogs
android
ios
keep_alive_registry
keyed_service
leveldb_proto
internal
public
live_caption
local_state
lookalikes
media_message_center
memory_pressure
minidump_uploader
mirroring
nacl
browser
loader
renderer
named_mojo_ipc_server
navigation_interception
net_log
network_time
no_state_prefetch
browser
ntp_tiles
offline_pages
core
background
downloads
model
request_header
task
open_from_clipboard
openscreen_platform
os_crypt
page_content_annotations
core
page_load_metrics
browser
metrics_web_contents_observer.cc
observers
page_load_metrics_test_waiter.ccpage_load_tracker.ccrenderer
paint_preview
browser
paint_preview_base_service_unittest.ccpaint_preview_client.ccpaint_preview_client_unittest.ccpaint_preview_file_mixin.cc
common
player
renderer
pdf
browser
performance_manager
decorators
execution_context
graph
metrics
performance_manager_feature_observer_client.ccperformance_manager_impl.ccv8_memory
plugins
renderer
plus_addresses
policy
core
common
cloud
power_bookmarks
prefs
printing
privacy_sandbox
proxy_config
query_parser
reading_list
remote_cocoa
renderer_context_menu
reporting
client
rlz
safe_search_api
saved_tab_groups
search_engines
search_provider_logos
security_interstitials
content
captive_portal_blocking_page.cchttps_only_mode_blocking_page.ccinsecure_form_blocking_page.cc
renderer
security_interstitial_controller_client.ccssl_error_handler.ccstateful_ssl_host_state_delegate.cccore
security_state
segmentation_platform
internal
database
dummy_ukm_data_manager.ccexecution
optimization_guide
processing
metadata
migration
post_processor
selection
signals
stats.ccservices
paint_preview_compositor
sessions
core
ios
shared_highlighting
core
sharing_message
site_engagement
site_isolation
speech
spellcheck
browser
common
renderer
ssl_errors
startup_metric_utils
browser
storage_monitor
subresource_filter
content
core
supervised_user
core
sync_bookmarks
sync_device_info
sync_preferences
sync_sessions
sync_user_events
system_media_controls
tab_groups
translate
content
core
browser
translate_internals
trusted_vault
ui_devtools
url_formatter
tools
url_matcher
url_pattern_index
url_rewrite
common
user_education
common
feature_promo
help_bubble
views
webui
user_manager
value_store
variations
visitedlink
viz
common
frame_sinks
gpu
quads
resources
host
service
compositor_frame_fuzzer
display
direct_renderer.ccdisplay_resource_provider_skia_unittest.ccdisplay_scheduler.ccexternal_use_client.ccnull_renderer.ccoutput_surface.ccoverlay_processor_ozone.ccoverlay_processor_using_strategy.ccrenderer_pixeltest.ccskia_renderer.ccsoftware_renderer.ccsurface_aggregator_unittest.cc
display_embedder
output_surface_provider_impl.ccoutput_surface_unified.ccskia_output_device_buffer_queue_unittest.ccskia_output_device_vulkan.ccskia_output_surface_impl_on_gpu.cc
frame_sinks
compositor_frame_sink_support.ccexternal_begin_frame_source_ios.mmroot_compositor_frame_sink_impl.cc
video_capture
gl
performance_hint
transitions
test
web_package
webapps
browser
webauthn
webcrypto
webrtc
webxr
android
wifi
@ -108,8 +108,7 @@ void ForceYouTubeRestrict(const GURL& url,
|
||||
switch (mode) {
|
||||
case YOUTUBE_RESTRICT_OFF:
|
||||
case YOUTUBE_RESTRICT_COUNT:
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
break;
|
||||
NOTREACHED();
|
||||
|
||||
case YOUTUBE_RESTRICT_MODERATE:
|
||||
headers->SetHeader(kYouTubeRestrictHeaderName,
|
||||
|
Reference in New Issue
Block a user