[fuchsia] Rename //fuchsia_webengine to //fuchsia_web
Per discussion in https://crrev.com/c/3628363, slightly modify the purpose of this directory to contain code related to Fuchsia's `fuchsia.web` FIDL API with `webengine` as one of the subdirectories. Update READMEs accordingly. Also, add a BUILD.gn and update //:gn_all to reference it. Bug: 1081525 Change-Id: I806613c663ca50cc65046eae4f597bf312f9b2c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3668769 Auto-Submit: David Dorwin <ddorwin@chromium.org> Commit-Queue: Erik Staab <estaab@chromium.org> Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by: Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/main@{#1008287}
This commit is contained in:

committed by
Chromium LUCI CQ

parent
9f559850a5
commit
7adc701cdb
5
BUILD.gn
5
BUILD.gn
@ -260,12 +260,11 @@ group("gn_all") {
|
|||||||
}
|
}
|
||||||
|
|
||||||
if (is_fuchsia && !is_chromecast) {
|
if (is_fuchsia && !is_chromecast) {
|
||||||
|
# Add targets that only exist on Fuchsia.
|
||||||
deps += [
|
deps += [
|
||||||
":d8_fuchsia",
|
":d8_fuchsia",
|
||||||
"//build/fuchsia/cipd",
|
"//build/fuchsia/cipd",
|
||||||
"//fuchsia/engine:web_engine",
|
"//fuchsia_web:gn_all",
|
||||||
"//fuchsia/runners:cast_runner",
|
|
||||||
"//fuchsia/runners:web_runner",
|
|
||||||
"//tools/fuchsia/size_tests:fuchsia_sizes",
|
"//tools/fuchsia/size_tests:fuchsia_sizes",
|
||||||
|
|
||||||
# Ensure this target, used by cipd, is built in all configurations.
|
# Ensure this target, used by cipd, is built in all configurations.
|
||||||
|
@ -41,7 +41,7 @@ See [Debugging](debug_instructions.md)
|
|||||||
* [Running Telemetry Benchmarks on Fuchsia](telemetry.md)
|
* [Running Telemetry Benchmarks on Fuchsia](telemetry.md)
|
||||||
|
|
||||||
## Fuchsia WebEngine and Runners
|
## Fuchsia WebEngine and Runners
|
||||||
See [Fuchsia WebEngine and Runners](../../fuchsia_webengine/README.md).
|
See [Fuchsia WebEngine and Runners](../../fuchsia_web/README.md).
|
||||||
|
|
||||||
## Resources for developers working on Chromium for Fuchsia
|
## Resources for developers working on Chromium for Fuchsia
|
||||||
|
|
||||||
|
19
fuchsia_web/BUILD.gn
Normal file
19
fuchsia_web/BUILD.gn
Normal file
@ -0,0 +1,19 @@
|
|||||||
|
# Copyright 2022 The Chromium Authors. All rights reserved.
|
||||||
|
# Use of this source code is governed by a BSD-style license that can be
|
||||||
|
# found in the LICENSE file.
|
||||||
|
|
||||||
|
assert(is_fuchsia)
|
||||||
|
|
||||||
|
visibility = [ "//:gn_all" ]
|
||||||
|
|
||||||
|
# Ensures every target within this directory is reachable.
|
||||||
|
# Used by "//:gn_all".
|
||||||
|
# TODO(crbug.com/1081525): Update these to targets within this directory as
|
||||||
|
# they are moved.
|
||||||
|
group("gn_all") {
|
||||||
|
deps = [
|
||||||
|
"//fuchsia/engine:web_engine",
|
||||||
|
"//fuchsia/runners:cast_runner",
|
||||||
|
"//fuchsia/runners:web_runner",
|
||||||
|
]
|
||||||
|
}
|
@ -1,4 +1,4 @@
|
|||||||
include_rules = [
|
include_rules = [
|
||||||
# Require explicit include rules for sub-directories.
|
# Require explicit include rules for sub-directories.
|
||||||
"-fuchsia_webengine",
|
"-fuchsia_web",
|
||||||
]
|
]
|
@ -1,7 +1,9 @@
|
|||||||
# Fuchsia WebEngine and Runners
|
# `fuchsia.web` - Fuchsia WebEngine and Runners
|
||||||
|
|
||||||
This directory contains implementation code for Fuchsia WebEngine and code
|
This directory contains code related to the
|
||||||
specifically related to it, including the Runners that use it. Code in this
|
[`fuchsia.web`](https://fuchsia.dev/reference/fidl/fuchsia.web) FIDL API.
|
||||||
|
Specifically, it contains the implementation of Fuchsia WebEngine and code
|
||||||
|
related to it, including the Runners that use it. Code in this
|
||||||
directory must not be used outside it and its subdirectories.
|
directory must not be used outside it and its subdirectories.
|
||||||
|
|
||||||
General information about Chromium on Fuchsia is
|
General information about Chromium on Fuchsia is
|
||||||
@ -12,11 +14,19 @@ General information about Chromium on Fuchsia is
|
|||||||
## Code organization
|
## Code organization
|
||||||
Each of the following subdirectories contain code for a specific Fuchsia
|
Each of the following subdirectories contain code for a specific Fuchsia
|
||||||
service:
|
service:
|
||||||
* `./engine` contains the WebEngine implementation. WebEngine enables
|
* `./common` contains code shared by both WebEngine and Runners.
|
||||||
Fuchsia applications to embed Chromium frames for rendering web content.
|
|
||||||
* `./runners`contains implementations of Fuchsia `sys.runner`.
|
* `./runners`contains implementations of Fuchsia `sys.runner`.
|
||||||
* `./runners/cast` Enables the Fuchsia system to launch Cast applications.
|
* `./runners/cast` Enables the Fuchsia system to launch Cast applications.
|
||||||
* `./runners/web` Enables the Fuchsia system to launch HTTP or HTTPS URLs.
|
* `./runners/web` Enables the Fuchsia system to launch HTTP or HTTPS URLs.
|
||||||
|
* `./shell` contains WebEngineShell, a simple wrapper for launching URLs in
|
||||||
|
WebEngine from the command line.
|
||||||
|
* `./webengine` contains the WebEngine implementation. WebEngine is an
|
||||||
|
implementation of
|
||||||
|
[`fuchsia.web`](https://fuchsia.dev/reference/fidl/fuchsia.web) that enables
|
||||||
|
Fuchsia Components to render web content using Chrome's Content layer.
|
||||||
|
* `./webinstance_host` contains code for WebEngine clients to directly
|
||||||
|
instantiate a WebInstance Component (`web_instance.cm`) using the WebEngine
|
||||||
|
package.
|
||||||
|
|
||||||
### Test code
|
### Test code
|
||||||
|
|
||||||
@ -27,8 +37,8 @@ There are 3 major types of tests within this directory:
|
|||||||
code is run inside the browser process, allowing for full access to the
|
code is run inside the browser process, allowing for full access to the
|
||||||
browser code - but not other processes.
|
browser code - but not other processes.
|
||||||
* Integration tests: Exercise the published FIDL API of a Fuchsia Component. For
|
* Integration tests: Exercise the published FIDL API of a Fuchsia Component. For
|
||||||
instance, `//fuchsia_webengine/engine:web_engine_integration_tests` make use
|
instance, `//fuchsia_web/webengine:web_engine_integration_tests` make use
|
||||||
of the `//fuchsia_webengine/engine:web_engine` component. The test code runs
|
of the `//fuchsia_web/webengine:web_engine` component. The test code runs
|
||||||
in a separate process in a separate Fuchsia Component, allowing only access to
|
in a separate process in a separate Fuchsia Component, allowing only access to
|
||||||
the published API of the component under test.
|
the published API of the component under test.
|
||||||
|
|
||||||
@ -41,9 +51,9 @@ under test with an explicit file name, either `fake_*`, `test_*`,
|
|||||||
`*_unittest.cc`, `*_ browsertest.cc` or `*_integration_test.cc`.
|
`*_unittest.cc`, `*_ browsertest.cc` or `*_integration_test.cc`.
|
||||||
|
|
||||||
Test code that is shared across Components should live in `a dedicated ``test`
|
Test code that is shared across Components should live in `a dedicated ``test`
|
||||||
directory. For example, the `//fuchsia_webengine/engine/test` directory, which
|
directory. For example, the `//fuchsia_web/webengine/test` directory, which
|
||||||
contains code shared by all browser tests, and
|
contains code shared by all browser tests, and
|
||||||
`//fuchsia_webengine/common/test`, which contains code shared by tests for both
|
`//fuchsia_web/common/test`, which contains code shared by tests for both
|
||||||
WebEngine and Runners.
|
WebEngine and Runners.
|
||||||
|
|
||||||
## Building and deploying the WebRunner service
|
## Building and deploying the WebRunner service
|
Reference in New Issue
Block a user