0

Add SiteInstance isolated-sandbox status to process-internals.

When a SiteInstance is used for processr-isolating a sandboxed iframe,
reflect that status in chrome://process-internals.

Bug: 510122
Change-Id: Icbf5eb9aa66a29d378a48a57f7ebc1dcec387643
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3704316
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: James Maclean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1013677}
This commit is contained in:
W. James MacLean
2022-06-13 22:01:54 +00:00
committed by Chromium LUCI CQ
parent 468e46f825
commit 7dae2da57d
3 changed files with 8 additions and 0 deletions

@@ -24,6 +24,9 @@ struct SiteInstanceInfo {
// false otherwise.
bool requires_origin_keyed_process;
// Specifies if the SiteInstance is for sandboxed iframe isolation.
bool is_sandboxed;
// Specifies whether this SiteInstance is for a <webview> guest.
bool is_guest;

@@ -57,6 +57,8 @@ using IsolatedOriginSource = ChildProcessSecurityPolicy::IsolatedOriginSource;
? absl::make_optional(site_instance->GetSiteInfo().site_url())
: absl::nullopt;
frame_info->site_instance->is_guest = site_instance->IsGuest();
frame_info->site_instance->is_sandboxed =
site_instance->GetSiteInfo().is_sandboxed();
// If the SiteInstance has a non-default StoragePartition, include a basic
// string representation of it. Skip cases where the StoragePartition is

@@ -113,6 +113,9 @@ function frameToTreeItem(frame: FrameInfo):
if (frame.siteInstance.requiresOriginKeyedProcess) {
itemLabel += ', origin-keyed';
}
if (frame.siteInstance.isSandboxed) {
itemLabel += ', iframe-sandbox';
}
if (frame.siteInstance.isGuest) {
itemLabel += ', guest';
}