0

[tracing] Move record_host_app_package_name_ to TrackNameRecorder

It's only used in TrackNameRecorder, this is a small incremental step
in breaking down TraceLog.

Change-Id: I413f666b9b9ea7bba5d505321c3e4e3e882d11f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6402133
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1438831}
This commit is contained in:
Etienne Pierre-doray
2025-03-27 09:55:57 -07:00
committed by Chromium LUCI CQ
parent ee7ced32e4
commit 865e0e310e
7 changed files with 15 additions and 18 deletions
android_webview/lib
base/trace_event
content/browser/tracing
services/tracing/public/cpp/perfetto

@ -109,8 +109,7 @@ void TrackNameRecorder::SetProcessTrackDescriptor(
#if BUILDFLAG(IS_ANDROID)
// Host app package name is only recorded if the corresponding TraceLog
// setting is set to true.
if (base::trace_event::TraceLog::GetInstance()
->ShouldRecordHostAppPackageName()) {
if (record_host_app_package_name_) {
// Host app package name is used to group information from different
// processes that "belong" to the same WebView app.
if (process_type == ChromeProcessDescriptor::PROCESS_RENDERER ||
@ -200,4 +199,9 @@ void TrackNameRecorder::SetProcessTrackDescriptor() {
SetProcessTrackDescriptor(process_name, process_type);
}
void TrackNameRecorder::SetRecordHostAppPackageName(
bool record_host_app_package_name) {
record_host_app_package_name_ = record_host_app_package_name;
}
} // namespace tracing

@ -46,6 +46,8 @@ class COMPONENT_EXPORT(TRACING_CPP) TrackNameRecorder
void UpdateProcessLabel(int label_id, const std::string& current_label);
void RemoveProcessLabel(int label_id);
void SetRecordHostAppPackageName(bool record_host_app_package_name);
private:
friend class base::NoDestructor<TrackNameRecorder>;
using ChromeProcessDescriptor =
@ -66,6 +68,7 @@ class COMPONENT_EXPORT(TRACING_CPP) TrackNameRecorder
}
int64_t process_start_timestamp_;
bool record_host_app_package_name_{false};
// This lock protects `process_labels_` member accesses from arbitrary
// threads.