Document that chromium-third-party is for licensing review.
There has been confusion about the third-party review process. Try to clarify that chromium-third-party is about licensing review, that the reviewers may simply leave a comment, and that they are not expected to be able to approve a change. Change-Id: I8461f9b416f8d76542230beb770a2cf8f5c44d6f Reviewed-on: https://chromium-review.googlesource.com/c/1338477 Reviewed-by: Dirk Pranke <dpranke@chromium.org> Reviewed-by: Adam Langley <agl@chromium.org> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#609820}
This commit is contained in:
@ -136,10 +136,13 @@ Non-Googlers can email one of the people in
|
|||||||
sure to highlight risk to security@chromium.org. You may be asked to add
|
sure to highlight risk to security@chromium.org. You may be asked to add
|
||||||
a README.security or, in dangerous cases, README.SECURITY.URGENTLY file.
|
a README.security or, in dangerous cases, README.SECURITY.URGENTLY file.
|
||||||
* Add chromium-third-party@google.com as a reviewer on your change. This
|
* Add chromium-third-party@google.com as a reviewer on your change. This
|
||||||
will trigger an automatic round-robin assignment of the review to an
|
will trigger an automatic round-robin assignment to a reviewer who will check
|
||||||
appropriate reviewer. This list does not receive or deliver email, so only
|
licensing matters. These reviewers may not be able to +1 a change so look for
|
||||||
use it as a reviewer, not for other communication. (Internally, see
|
verbal approval in the comments. (This list does not receive or deliver
|
||||||
b/119558132 for details about how this is configured.)
|
email, so only use it as a reviewer, not for other communication. Internally,
|
||||||
|
see cl/221704656 for details about how this is configured.)
|
||||||
|
* Lastly, if all other steps are complete, get a positive code review from a
|
||||||
|
member of [//third_party/OWNERS](../third_party/OWNERS) to land the change.
|
||||||
|
|
||||||
Please send separate emails to the eng review and security lists.
|
Please send separate emails to the eng review and security lists.
|
||||||
|
|
||||||
|
Reference in New Issue
Block a user