[Omnibox] fix spellings on inlinable and potentially
This Cl changes spellings. There are no logic changes. (code health) Bug: None Change-Id: I28192930065af7a92fd3b4b4a47edc1eee84e989 Reviewed-on: https://chromium-review.googlesource.com/1042822 Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#555869}
This commit is contained in:

committed by
Commit Bot

parent
5625d718f3
commit
8f49bff3b0
components/omnibox/browser
@@ -517,7 +517,7 @@ void SearchProvider::LogFetchComplete(bool success, bool is_keyword) {
|
|||||||
void SearchProvider::UpdateMatches() {
|
void SearchProvider::UpdateMatches() {
|
||||||
// On-focus inputs display no suggestions, so we do not need to persist the
|
// On-focus inputs display no suggestions, so we do not need to persist the
|
||||||
// previous top suggestions, add new suggestions, or revise suggestions to
|
// previous top suggestions, add new suggestions, or revise suggestions to
|
||||||
// enforce constraints about inlineability in this case. Indeed, most of
|
// enforce constraints about inlinability in this case. Indeed, most of
|
||||||
// these steps would be bad, as they'd add a suggestion of some form, thus
|
// these steps would be bad, as they'd add a suggestion of some form, thus
|
||||||
// opening the dropdown (which we do not want to happen).
|
// opening the dropdown (which we do not want to happen).
|
||||||
if (!input_.from_omnibox_focus()) {
|
if (!input_.from_omnibox_focus()) {
|
||||||
@@ -752,10 +752,10 @@ void SearchProvider::CancelFetcher(std::unique_ptr<net::URLFetcher>* fetcher) {
|
|||||||
}
|
}
|
||||||
|
|
||||||
bool SearchProvider::IsQuerySuitableForSuggest(bool* query_is_private) const {
|
bool SearchProvider::IsQuerySuitableForSuggest(bool* query_is_private) const {
|
||||||
*query_is_private = IsQueryPotentionallyPrivate();
|
*query_is_private = IsQueryPotentiallyPrivate();
|
||||||
|
|
||||||
// Don't run Suggest in incognito mode, if the engine doesn't support it, or
|
// Don't run Suggest in incognito mode, if the engine doesn't support it, or
|
||||||
// if the user has disabled it. Also don't send potentionally private data
|
// if the user has disabled it. Also don't send potentially private data
|
||||||
// to the default search provider. (It's always okay to send explicit
|
// to the default search provider. (It's always okay to send explicit
|
||||||
// keyword input to a keyword suggest server, if any.)
|
// keyword input to a keyword suggest server, if any.)
|
||||||
const TemplateURL* default_url = providers_.GetDefaultProviderURL();
|
const TemplateURL* default_url = providers_.GetDefaultProviderURL();
|
||||||
@@ -766,7 +766,7 @@ bool SearchProvider::IsQuerySuitableForSuggest(bool* query_is_private) const {
|
|||||||
(keyword_url && !keyword_url->suggestions_url().empty()));
|
(keyword_url && !keyword_url->suggestions_url().empty()));
|
||||||
}
|
}
|
||||||
|
|
||||||
bool SearchProvider::IsQueryPotentionallyPrivate() const {
|
bool SearchProvider::IsQueryPotentiallyPrivate() const {
|
||||||
if (input_.text().empty())
|
if (input_.text().empty())
|
||||||
return false;
|
return false;
|
||||||
|
|
||||||
@@ -1511,15 +1511,15 @@ AutocompleteMatch SearchProvider::NavigationToMatch(
|
|||||||
match.inline_autocompletion =
|
match.inline_autocompletion =
|
||||||
match.fill_into_edit.substr(inline_autocomplete_offset);
|
match.fill_into_edit.substr(inline_autocomplete_offset);
|
||||||
}
|
}
|
||||||
// An inlineable navsuggestion can only be the default match when there
|
// An inlinable navsuggestion can only be the default match when there
|
||||||
// is no keyword provider active, lest it appear first and break the user
|
// is no keyword provider active, lest it appear first and break the user
|
||||||
// out of keyword mode. We also must have received the navsuggestion before
|
// out of keyword mode. We also must have received the navsuggestion before
|
||||||
// the last keystroke, to prevent asynchronous inline autocompletions changes.
|
// the last keystroke, to prevent asynchronous inline autocompletions changes.
|
||||||
// The navsuggestion can also only be default if either the inline
|
// The navsuggestion can also only be default if either the inline
|
||||||
// autocompletion is empty or we're not preventing inline autocompletion.
|
// autocompletion is empty or we're not preventing inline autocompletion.
|
||||||
// Finally, if we have an inlineable navsuggestion with an inline completion
|
// Finally, if we have an inlinable navsuggestion with an inline completion
|
||||||
// that we're not preventing, make sure we didn't trim any whitespace.
|
// that we're not preventing, make sure we didn't trim any whitespace.
|
||||||
// We don't want to claim http://foo.com/bar is inlineable against the
|
// We don't want to claim http://foo.com/bar is inlinable against the
|
||||||
// input "foo.com/b ".
|
// input "foo.com/b ".
|
||||||
match.allowed_to_be_default_match =
|
match.allowed_to_be_default_match =
|
||||||
(prefix != nullptr) && (providers_.GetKeywordProviderURL() == nullptr) &&
|
(prefix != nullptr) && (providers_.GetKeywordProviderURL() == nullptr) &&
|
||||||
|
@@ -234,7 +234,7 @@ class SearchProvider : public BaseSearchProvider,
|
|||||||
|
|
||||||
// Returns true when the current query can be sent to at least one suggest
|
// Returns true when the current query can be sent to at least one suggest
|
||||||
// service. This will be false for example when suggest is disabled. In
|
// service. This will be false for example when suggest is disabled. In
|
||||||
// the process, calculates whether the query may contain potentionally
|
// the process, calculates whether the query may contain potentially
|
||||||
// private data and stores the result in |is_query_private|; such queries
|
// private data and stores the result in |is_query_private|; such queries
|
||||||
// should not be sent to the default search engine.
|
// should not be sent to the default search engine.
|
||||||
bool IsQuerySuitableForSuggest(bool* query_is_private) const;
|
bool IsQuerySuitableForSuggest(bool* query_is_private) const;
|
||||||
@@ -243,7 +243,7 @@ class SearchProvider : public BaseSearchProvider,
|
|||||||
// information (and hence the suggest request shouldn't be sent). In
|
// information (and hence the suggest request shouldn't be sent). In
|
||||||
// particular, if the input type might be a URL, we take extra care so that
|
// particular, if the input type might be a URL, we take extra care so that
|
||||||
// it isn't sent to the server.
|
// it isn't sent to the server.
|
||||||
bool IsQueryPotentionallyPrivate() const;
|
bool IsQueryPotentiallyPrivate() const;
|
||||||
|
|
||||||
// Remove existing keyword results if the user is no longer in keyword mode,
|
// Remove existing keyword results if the user is no longer in keyword mode,
|
||||||
// and, if |minimal_changes| is false, revise the existing results to
|
// and, if |minimal_changes| is false, revise the existing results to
|
||||||
|
Reference in New Issue
Block a user