chromium/src
0
Fork 0
Code Activity

Rename MRUCache to LRUCache.

Browse Source 
https://en.wikipedia.org/wiki/Cache_replacement_policies indicates that
this implementation is actually an LRU cache, not an MRU cache. An MRU
cache evicts the most-recently-used item first.

This CL also renames some variables and an enum for consistency, since
it would be weird for an `mru_cache_` member to actually be an LRU
cache.

Change-Id: Ia52d7dbf18785620466d99d362633fe7ecf7fb41
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3214453
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Owners-Override: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Chris Fredrickson <cfredric@chromium.org>
Cr-Commit-Position: refs/heads/main@{#931363}
This commit is contained in:
cfredric
2021-10-14 03:24:00 +00:00
committed by Chromium LUCI CQ
parent 6ac3a31add
commit 8fdc224330
89 changed files with 277 additions and 279 deletions
base
BUILD.gn
containers
lru_cache.hlru_cache_unittest.cc
trace_event
memory_usage_estimator.h
cc
paint
paint_cache.h
tiles
gpu_image_decode_cache.hsoftware_image_decode_cache.ccsoftware_image_decode_cache.h
trees
layer_tree_host_impl.h
chrome
browser
bitmap_fetcher
bitmap_fetcher_service.h
lite_video
lite_video_decider.h
media
router
mojo
media_sink_service_status.ccmedia_sink_service_status.h
optimization_guide
prediction
prediction_manager.ccprediction_manager.h
subresource_redirect
origin_robots_rules_cache.h
ui
views
tabs
tab_hover_card_bubble_view.cc
renderer
instant_restricted_id_cache.h
subresource_redirect
robots_rules_parser_cache.h
chromecast/crypto
signature_cache.h
components
autofill
core
browser
geo
country_names.h
autofill_assistant
browser
starter.ccstarter.hstarter_unittest.cc
dom_distiller
core
distilled_content_store.h
favicon
core
favicon_backend_unittest.cc
history
core
browser
history_backend.h
nacl
browser
nacl_browser.hnacl_validation_cache.h
omnibox
browser
document_provider.hfavicon_cache.ccfavicon_cache.h
optimization_guide
content
browser
page_content_annotations_service.h
core
hint_cache.hhints_manager.h
password_manager
core
browser
password_requirements_service.h
safe_search_api
url_checker.h
security_interstitials
content
certificate_error_report.cccertificate_error_report_unittest.cc
services
storage
indexed_db
transactional_leveldb
transactional_leveldb_database.h
gpu/command_buffer/service
gr_shader_cache.hmemory_program_cache.ccmemory_program_cache.hpassthrough_discardable_manager.hpassthrough_program_cache.ccpassthrough_program_cache.hservice_discardable_manager.hservice_transfer_cache.hshared_context_state.h
ios
chrome
browser
favicon
large_icon_cache.h
snapshots
snapshot_lru_cache.mm
web
security
cert_verification_error.h
media
gpu
ipc
service
vda_video_decoder.h
test
video_encoder
bitstream_validator.h
video_player
test_vda_video_decoder.h
v4l2
v4l2_video_decoder.hv4l2_video_decoder_backend_stateless.h
vaapi
vaapi_video_decoder.h
mojo
clients
mojo_video_decoder.h
net
cert
internal
system_trust_store.cctrust_store_mac.cctrust_store_mac.htrust_store_mac_unittest.cc
http
broken_alternative_services.ccbroken_alternative_services.hhttp_server_properties.cchttp_server_properties.h
quic
quic_chromium_client_session.hquic_client_session_cache.hquic_stream_factory.h
reporting
reporting_endpoint_manager.cc
socket
ssl_client_socket_impl.h
ssl
ssl_client_session_cache.h
services
cert_verifier
public
mojom
trial_comparison_cert_verifier.mojom
trial_comparison_cert_verifier_mojo.cc
network
sct_auditing
sct_auditing_cache.h
storage/browser/blob
blob_memory_controller.ccblob_memory_controller.h
third_party/blink
renderer
modules
webgl
DEPSwebgl_rendering_context_base.ccwebgl_rendering_context_base.h
tools
blinkpy
presubmit
audit_non_blink_usage.py
ui
gfx
font_fallback_linux.ccfont_render_params_linux.ccharfbuzz_font_skia.ccicc_profile.ccrender_text_harfbuzz.cc
ozone
platform
drm
gpu
drm_overlay_manager.hdrm_overlay_validator.h

4
components/safe_search_api/url_checker.h

@ -9,7 +9,7 @@
#include <memory>
#include "base/callback_forward.h"
#include "base/containers/mru_cache.h"
#include "base/containers/lru_cache.h"
#include "base/memory/weak_ptr.h"
#include "base/time/time.h"
#include "components/safe_search_api/url_checker_client.h"
@ -72,7 +72,7 @@ class URLChecker {
std::unique_ptr<URLCheckerClient> async_checker_;
CheckList checks_in_progress_;
base::MRUCache<GURL, CheckResult> cache_;
base::LRUCache<GURL, CheckResult> cache_;
base::TimeDelta cache_timeout_;
base::WeakPtrFactory<URLChecker> weak_factory_{this};