diff --git a/chrome/app/profiles_strings.grdp b/chrome/app/profiles_strings.grdp index 06f0fc9652166..436531fc39624 100644 --- a/chrome/app/profiles_strings.grdp +++ b/chrome/app/profiles_strings.grdp @@ -1039,6 +1039,13 @@ other {Bookmarks ({SELECTED_ITEMS})} } </message> + <message name="IDS_BATCH_UPLOAD_SECTION_TITLE_READING_LIST" desc="Title of the Reading list section in the Batch Upload dialog. This dialog appears when the user clicks on an informational message about items saved only to their device. The title of the dialog is ‘Save items in account’. The list of items has sections for each applicable data type: Passwords, Bookmarks, and more. This section shows the number of selected items in the section of the dialog, if any."> + {SELECTED_ITEMS, plural, + =0 {Reading list} + =1 {Reading list ({SELECTED_ITEMS})} + other {Reading list ({SELECTED_ITEMS})} + } + </message> <message name="IDS_BATCH_UPLOAD_SECTION_TITLE_ADDRESSES" desc="Title of the Addresses section in the Batch Upload dialog. This dialog appears when the user clicks on an informational message about items saved only to their device. The title of the dialog is ‘Save items in account’. The list of items has sections for each applicable data type: Passwords, Bookmarks, and more. This section shows the number of selected items in the section of the dialog, if any."> {SELECTED_ITEMS, plural, =0 {Addresses} diff --git a/chrome/app/profiles_strings_grdp/IDS_BATCH_UPLOAD_SECTION_TITLE_READING_LIST.png.sha1 b/chrome/app/profiles_strings_grdp/IDS_BATCH_UPLOAD_SECTION_TITLE_READING_LIST.png.sha1 new file mode 100644 index 0000000000000..fac6113ad218c --- /dev/null +++ b/chrome/app/profiles_strings_grdp/IDS_BATCH_UPLOAD_SECTION_TITLE_READING_LIST.png.sha1 @@ -0,0 +1 @@ +fa546078bc537e6d11cb4d7b18c1e2367c6a6715 \ No newline at end of file diff --git a/chrome/browser/profiles/batch_upload/batch_upload_service.cc b/chrome/browser/profiles/batch_upload/batch_upload_service.cc index 50eb46bf219e0..61a87b9aa3d5a 100644 --- a/chrome/browser/profiles/batch_upload/batch_upload_service.cc +++ b/chrome/browser/profiles/batch_upload/batch_upload_service.cc @@ -35,11 +35,14 @@ constexpr base::TimeDelta kBatchUploadAvatarButtonOverrideTextDuration = // This list contains all the data types that are available for the Batch Upload // dialog. Data types should not be repeated and the list is ordered based on // the priority of showing in the dialog. -const std::array<syncer::DataType, 4> kBatchUploadAvailableTypesOrder{ +const std::array<syncer::DataType, 5> kBatchUploadAvailableTypesOrder{ + // clang-format off syncer::DataType::PASSWORDS, syncer::DataType::BOOKMARKS, + syncer::DataType::READING_LIST, syncer::DataType::CONTACT_INFO, syncer::DataType::THEMES, + // clang-format on }; // Returns the list of data descriptions in `local_data_descriptions_map` diff --git a/chrome/browser/profiles/batch_upload/batch_upload_service_unittest.cc b/chrome/browser/profiles/batch_upload/batch_upload_service_unittest.cc index c570f11469092..cdad5915dfb09 100644 --- a/chrome/browser/profiles/batch_upload/batch_upload_service_unittest.cc +++ b/chrome/browser/profiles/batch_upload/batch_upload_service_unittest.cc @@ -216,6 +216,7 @@ TEST_F(BatchUploadServiceTest, LocalDataForAllAvailableTypesMainOrder) { GetLocalDataDescriptions( syncer::DataTypeSet{ syncer::DataType::PASSWORDS, syncer::DataType::BOOKMARKS, + syncer::DataType::READING_LIST, syncer::DataType::CONTACT_INFO, syncer::DataType::THEMES}, _)) .Times(1); @@ -223,6 +224,7 @@ TEST_F(BatchUploadServiceTest, LocalDataForAllAvailableTypesMainOrder) { std::vector<syncer::LocalDataDescription> expected_descriptions{ GetReturnDescription(syncer::PASSWORDS), GetReturnDescription(syncer::BOOKMARKS), + GetReturnDescription(syncer::READING_LIST), GetReturnDescription(syncer::CONTACT_INFO), GetReturnDescription(syncer::THEMES), }; diff --git a/chrome/browser/ui/webui/signin/batch_upload_handler.cc b/chrome/browser/ui/webui/signin/batch_upload_handler.cc index 8a3f0f034295a..e7e766e8ca29a 100644 --- a/chrome/browser/ui/webui/signin/batch_upload_handler.cc +++ b/chrome/browser/ui/webui/signin/batch_upload_handler.cc @@ -296,6 +296,8 @@ int BatchUploadHandler::GetTypeSectionTitleId(syncer::DataType type) { return IDS_BATCH_UPLOAD_SECTION_TITLE_PASSWORDS; case syncer::DataType::BOOKMARKS: return IDS_BATCH_UPLOAD_SECTION_TITLE_BOOKMARKS; + case syncer::DataType::READING_LIST: + return IDS_BATCH_UPLOAD_SECTION_TITLE_READING_LIST; case syncer::DataType::CONTACT_INFO: return IDS_BATCH_UPLOAD_SECTION_TITLE_ADDRESSES; case syncer::DataType::THEMES: