TOOD -> TODO
TBR=jochen@chromium.org Bug: https://cs.chromium.org/search/?q=%5E(%7C.*%5B%5ETtRrSsEe%5D)(TOOO%7CTOD0%7CTODI%7CTODP%7CTOO%7CTOSO%7CTODDO%7CTOOD%7CTOCO%7CTOTO%7CODO%7CTDOO%7CTODOD%7CTOFO%7CTDDO%7CTODD%7CTOD%7CTODOO%7CTDO%7CTODL)%5CW?%5C(%5Cs*(%5Ba-z%5D%7B3,14%7D)%5Cs*%5C)+case:yes&sq=package:chromium&type=cs Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ie238e22c240bc2842543d6b224163f4c9a7e4e9f Reviewed-on: https://chromium-review.googlesource.com/629516 Reviewed-by: Scott Graham <scottmg@chromium.org> Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#496837}
This commit is contained in:
chrome/browser
components/proximity_auth
content/renderer/pepper
extensions
browser
app_window
shell
gpu/ipc/service
media/audio/mac
native_client_sdk/src/libraries/nacl_io/devfs
net
cert
http
tools
epoll_server
url_request
services/ui/ws
third_party
WebKit
LayoutTests
fast
forms
select-popup
Source
core
html
platform
cacheinvalidation
overrides
google
cacheinvalidation
deps
protobuf
src
google
protobuf
tools/perf/metrics
ui
base
l10n
file_manager
file_manager
foreground
views
@@ -72,7 +72,7 @@ class CertLibrary : public CertLoader::Observer {
|
|||||||
// Returns the index of a Certificate matching |pem_encoded| or -1 if none
|
// Returns the index of a Certificate matching |pem_encoded| or -1 if none
|
||||||
// found. This function may be slow depending on the number of stored
|
// found. This function may be slow depending on the number of stored
|
||||||
// certificates.
|
// certificates.
|
||||||
// TOOD(pneubeck): Either make this more efficient, asynchronous or get rid of
|
// TODO(pneubeck): Either make this more efficient, asynchronous or get rid of
|
||||||
// it.
|
// it.
|
||||||
int GetServerCACertIndexByPEM(const std::string& pem_encoded) const;
|
int GetServerCACertIndexByPEM(const std::string& pem_encoded) const;
|
||||||
// Same as above but for a PKCS#11 id.
|
// Same as above but for a PKCS#11 id.
|
||||||
|
@@ -68,7 +68,7 @@ const char kBAccountIdString[] =
|
|||||||
const char kArrowBAccountIdString[] =
|
const char kArrowBAccountIdString[] =
|
||||||
"->{\"account_type\":\"unknown\",\"email\":\"B\"}";
|
"->{\"account_type\":\"unknown\",\"email\":\"B\"}";
|
||||||
|
|
||||||
// TOOD(beng): This implementation seems only superficially different to the
|
// TODO(beng): This implementation seems only superficially different to the
|
||||||
// production impl. Evaluate whether or not we can just use that
|
// production impl. Evaluate whether or not we can just use that
|
||||||
// one.
|
// one.
|
||||||
class TestShellContentState : public ash::ShellContentState {
|
class TestShellContentState : public ash::ShellContentState {
|
||||||
|
@@ -129,7 +129,7 @@ void BluetoothConnection::OnAdapterInitialized(
|
|||||||
if (!bluetooth_device) {
|
if (!bluetooth_device) {
|
||||||
PA_LOG(WARNING) << "Device with address " << address
|
PA_LOG(WARNING) << "Device with address " << address
|
||||||
<< " is not known to the system Bluetooth daemon.";
|
<< " is not known to the system Bluetooth daemon.";
|
||||||
// TOOD(isherman): Optimistically attempt to seek the device and connect
|
// TODO(isherman): Optimistically attempt to seek the device and connect
|
||||||
// anyway, as was previously implemented in BluetoothConnectionFinder.
|
// anyway, as was previously implemented in BluetoothConnectionFinder.
|
||||||
Disconnect();
|
Disconnect();
|
||||||
return;
|
return;
|
||||||
|
@@ -242,7 +242,7 @@ void PepperBroker::ConnectPluginToBroker(PPB_Broker_Impl* client) {
|
|||||||
result = PP_ERROR_FAILED;
|
result = PP_ERROR_FAILED;
|
||||||
}
|
}
|
||||||
|
|
||||||
// TOOD(ddorwin): Change the IPC to asynchronous: Queue an object containing
|
// TODO(ddorwin): Change the IPC to asynchronous: Queue an object containing
|
||||||
// client and plugin_socket.release(), then return.
|
// client and plugin_socket.release(), then return.
|
||||||
// That message handler will then call client->BrokerConnected() with the
|
// That message handler will then call client->BrokerConnected() with the
|
||||||
// saved pipe handle.
|
// saved pipe handle.
|
||||||
|
@@ -42,7 +42,7 @@ content::WebContents* AppWebContentsHelper::OpenURLFromTab(
|
|||||||
// anchor tags (even those without target="_blank") to new tabs, but right
|
// anchor tags (even those without target="_blank") to new tabs, but right
|
||||||
// now we can't distinguish between those and <meta> refreshes or window.href
|
// now we can't distinguish between those and <meta> refreshes or window.href
|
||||||
// navigations, which we don't want to allow.
|
// navigations, which we don't want to allow.
|
||||||
// TOOD(mihaip): Can we check for user gestures instead?
|
// TODO(mihaip): Can we check for user gestures instead?
|
||||||
WindowOpenDisposition disposition = params.disposition;
|
WindowOpenDisposition disposition = params.disposition;
|
||||||
if (disposition == WindowOpenDisposition::CURRENT_TAB) {
|
if (disposition == WindowOpenDisposition::CURRENT_TAB) {
|
||||||
web_contents_->GetMainFrame()->AddMessageToConsole(
|
web_contents_->GetMainFrame()->AddMessageToConsole(
|
||||||
|
@@ -31,7 +31,7 @@ IN_PROC_BROWSER_TEST_F(ShellApiTest, LoadApp) {
|
|||||||
AppWindowRegistry::Get(browser_context())->app_windows().front();
|
AppWindowRegistry::Get(browser_context())->app_windows().front();
|
||||||
ASSERT_TRUE(app_window);
|
ASSERT_TRUE(app_window);
|
||||||
|
|
||||||
// TOOD(yoz): Test for focus on Cocoa.
|
// TODO(yoz): Test for focus on Cocoa.
|
||||||
// app_window->GetBaseWindow()->IsActive() is possible, although on Mac,
|
// app_window->GetBaseWindow()->IsActive() is possible, although on Mac,
|
||||||
// focus changes are asynchronous, so interactive_ui_tests are required.
|
// focus changes are asynchronous, so interactive_ui_tests are required.
|
||||||
#if defined(USE_AURA)
|
#if defined(USE_AURA)
|
||||||
|
@@ -18,7 +18,7 @@ ShellDesktopControllerMac::ShellDesktopControllerMac()
|
|||||||
}
|
}
|
||||||
|
|
||||||
ShellDesktopControllerMac::~ShellDesktopControllerMac() {
|
ShellDesktopControllerMac::~ShellDesktopControllerMac() {
|
||||||
// TOOD(yoz): This is actually too late to close app windows (for tests).
|
// TODO(yoz): This is actually too late to close app windows (for tests).
|
||||||
// Maybe this is useful for non-tests.
|
// Maybe this is useful for non-tests.
|
||||||
CloseAppWindows();
|
CloseAppWindows();
|
||||||
}
|
}
|
||||||
|
@@ -65,7 +65,7 @@ class GPU_EXPORT GpuMemoryBufferFactoryIOSurface
|
|||||||
typedef std::pair<gfx::IOSurfaceId, int> IOSurfaceMapKey;
|
typedef std::pair<gfx::IOSurfaceId, int> IOSurfaceMapKey;
|
||||||
typedef base::hash_map<IOSurfaceMapKey, base::ScopedCFTypeRef<IOSurfaceRef>>
|
typedef base::hash_map<IOSurfaceMapKey, base::ScopedCFTypeRef<IOSurfaceRef>>
|
||||||
IOSurfaceMap;
|
IOSurfaceMap;
|
||||||
// TOOD(reveman): Remove |io_surfaces_| and allow IOSurface backed GMBs to be
|
// TODO(reveman): Remove |io_surfaces_| and allow IOSurface backed GMBs to be
|
||||||
// used with any GPU process by passing a mach_port to CreateImageCHROMIUM.
|
// used with any GPU process by passing a mach_port to CreateImageCHROMIUM.
|
||||||
IOSurfaceMap io_surfaces_;
|
IOSurfaceMap io_surfaces_;
|
||||||
base::Lock io_surfaces_lock_;
|
base::Lock io_surfaces_lock_;
|
||||||
|
@@ -84,7 +84,7 @@ class MEDIA_EXPORT AudioManagerMac : public AudioManagerBase {
|
|||||||
// Streams should consult ShouldDeferStreamStart() and if true check the value
|
// Streams should consult ShouldDeferStreamStart() and if true check the value
|
||||||
// again after |kStartDelayInSecsForPowerEvents| has elapsed. If false, the
|
// again after |kStartDelayInSecsForPowerEvents| has elapsed. If false, the
|
||||||
// stream may be started immediately.
|
// stream may be started immediately.
|
||||||
// TOOD(henrika): track UMA statistics related to defer start to come up with
|
// TODO(henrika): track UMA statistics related to defer start to come up with
|
||||||
// a suitable delay value.
|
// a suitable delay value.
|
||||||
enum { kStartDelayInSecsForPowerEvents = 5 };
|
enum { kStartDelayInSecsForPowerEvents = 5 };
|
||||||
bool ShouldDeferStreamStart() const;
|
bool ShouldDeferStreamStart() const;
|
||||||
|
@@ -169,7 +169,7 @@ Error TtyNode::Echo(const char* string, int count) {
|
|||||||
HandleAttr data;
|
HandleAttr data;
|
||||||
Error error = Write(data, string, count, &wrote);
|
Error error = Write(data, string, count, &wrote);
|
||||||
if (error != 0 || wrote != count) {
|
if (error != 0 || wrote != count) {
|
||||||
// TOOD(sbc): Do something more useful in response to a
|
// TODO(sbc): Do something more useful in response to a
|
||||||
// failure to echo.
|
// failure to echo.
|
||||||
return error;
|
return error;
|
||||||
}
|
}
|
||||||
|
@@ -444,7 +444,7 @@ TEST_P(CertVerifyProcInternalTest, DISABLED_PaypalNullCertParsing) {
|
|||||||
// ERR_CERT_AUTHORITY_INVALID on the real device.
|
// ERR_CERT_AUTHORITY_INVALID on the real device.
|
||||||
EXPECT_THAT(error, IsError(ERR_CERT_INVALID));
|
EXPECT_THAT(error, IsError(ERR_CERT_INVALID));
|
||||||
} else {
|
} else {
|
||||||
// TOOD(bulach): investigate why macosx and win aren't returning
|
// TODO(bulach): investigate why macosx and win aren't returning
|
||||||
// ERR_CERT_INVALID or ERR_CERT_COMMON_NAME_INVALID.
|
// ERR_CERT_INVALID or ERR_CERT_COMMON_NAME_INVALID.
|
||||||
EXPECT_THAT(error, IsError(ERR_CERT_AUTHORITY_INVALID));
|
EXPECT_THAT(error, IsError(ERR_CERT_AUTHORITY_INVALID));
|
||||||
}
|
}
|
||||||
|
@@ -102,7 +102,7 @@ void HttpAuthHandler::OnGenerateAuthTokenComplete(int rv) {
|
|||||||
}
|
}
|
||||||
|
|
||||||
void HttpAuthHandler::FinishGenerateAuthToken() {
|
void HttpAuthHandler::FinishGenerateAuthToken() {
|
||||||
// TOOD(cbentzel): Should this be done in OK case only?
|
// TODO(cbentzel): Should this be done in OK case only?
|
||||||
net_log_.EndEvent(EventTypeFromAuthTarget(target_));
|
net_log_.EndEvent(EventTypeFromAuthTarget(target_));
|
||||||
callback_.Reset();
|
callback_.Reset();
|
||||||
}
|
}
|
||||||
|
@@ -661,7 +661,7 @@ class EpollServer {
|
|||||||
};
|
};
|
||||||
|
|
||||||
|
|
||||||
// TOOD(sushantj): Having this hash_set is avoidable. We currently have it
|
// TODO(sushantj): Having this hash_set is avoidable. We currently have it
|
||||||
// only so that we can enforce stringent checks that a caller can not register
|
// only so that we can enforce stringent checks that a caller can not register
|
||||||
// the same alarm twice. One option is to have an implementation in which
|
// the same alarm twice. One option is to have an implementation in which
|
||||||
// this hash_set is used only in the debug mode.
|
// this hash_set is used only in the debug mode.
|
||||||
|
@@ -132,7 +132,7 @@ void URLRequestFileDirJob::OnListFile(
|
|||||||
#if defined(OS_WIN)
|
#if defined(OS_WIN)
|
||||||
std::string raw_bytes; // Empty on Windows means UTF-8 encoded name.
|
std::string raw_bytes; // Empty on Windows means UTF-8 encoded name.
|
||||||
#elif defined(OS_POSIX)
|
#elif defined(OS_POSIX)
|
||||||
// TOOD(jungshik): The same issue as for the directory name.
|
// TODO(jungshik): The same issue as for the directory name.
|
||||||
const std::string& raw_bytes = filename.value();
|
const std::string& raw_bytes = filename.value();
|
||||||
#endif
|
#endif
|
||||||
data_.append(GetDirectoryListingEntry(
|
data_.append(GetDirectoryListingEntry(
|
||||||
|
@@ -555,7 +555,7 @@ void WindowManagerState::ScheduleInputEventTimeout(WindowTree* tree,
|
|||||||
base::MakeUnique<InFlightEventDispatchDetails>(this, tree, display_id,
|
base::MakeUnique<InFlightEventDispatchDetails>(this, tree, display_id,
|
||||||
event, phase);
|
event, phase);
|
||||||
|
|
||||||
// TOOD(sad): Adjust this delay, possibly make this dynamic.
|
// TODO(sad): Adjust this delay, possibly make this dynamic.
|
||||||
const base::TimeDelta max_delay = base::debug::BeingDebugged()
|
const base::TimeDelta max_delay = base::debug::BeingDebugged()
|
||||||
? base::TimeDelta::FromDays(1)
|
? base::TimeDelta::FromDays(1)
|
||||||
: GetDefaultAckTimerDelay();
|
: GetDefaultAckTimerDelay();
|
||||||
|
2
third_party/WebKit/LayoutTests/fast/forms/select-popup/popup-menu-appearance-zoom110.html
vendored
2
third_party/WebKit/LayoutTests/fast/forms/select-popup/popup-menu-appearance-zoom110.html
vendored
@@ -9,7 +9,7 @@ window.enablePixelTesting = true;
|
|||||||
</head>
|
</head>
|
||||||
<body style="zoom:1.1;">
|
<body style="zoom:1.1;">
|
||||||
<p>There is no whitespace at the bottom of the popup in 110% zoom level.</p>
|
<p>There is no whitespace at the bottom of the popup in 110% zoom level.</p>
|
||||||
<!-- TOOD(tkent): The pixel result on Linux has unexepcted scroll bar. We
|
<!-- TODO(tkent): The pixel result on Linux has unexepcted scroll bar. We
|
||||||
-- should understand the cause. The scrollbar doesn't appear on content_shell
|
-- should understand the cause. The scrollbar doesn't appear on content_shell
|
||||||
-- and chrome. So, it's not a serious issue. -->
|
-- and chrome. So, it's not a serious issue. -->
|
||||||
<select id="menu" style="font-size: 12px; font-family: 'Segoe UI', Tahoma, -webkit-sans-serif; width: 145.455px;">
|
<select id="menu" style="font-size: 12px; font-family: 'Segoe UI', Tahoma, -webkit-sans-serif; width: 145.455px;">
|
||||||
|
@@ -161,7 +161,7 @@ void ExternalPopupMenu::UpdateFromElement(UpdateReason reason) {
|
|||||||
break;
|
break;
|
||||||
|
|
||||||
case kByStyleChange:
|
case kByStyleChange:
|
||||||
// TOOD(tkent): We should update the popup location/content in some
|
// TODO(tkent): We should update the popup location/content in some
|
||||||
// cases. e.g. Updating ComputedStyle of the SELECT element affects
|
// cases. e.g. Updating ComputedStyle of the SELECT element affects
|
||||||
// popup position and OPTION style.
|
// popup position and OPTION style.
|
||||||
break;
|
break;
|
||||||
|
@@ -57,7 +57,7 @@ class BlobBytesStreamer {
|
|||||||
} else if (write_result == MOJO_RESULT_SHOULD_WAIT) {
|
} else if (write_result == MOJO_RESULT_SHOULD_WAIT) {
|
||||||
break;
|
break;
|
||||||
} else {
|
} else {
|
||||||
// TOOD(mek): Something went wrong, log this error somewhere.
|
// TODO(mek): Something went wrong, log this error somewhere.
|
||||||
delete this;
|
delete this;
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
|
@@ -198,7 +198,7 @@ void OffscreenCanvasFrameDispatcherImpl::DispatchFrame(
|
|||||||
const bool kNeedsBlending = true;
|
const bool kNeedsBlending = true;
|
||||||
gfx::Rect opaque_rect(0, 0);
|
gfx::Rect opaque_rect(0, 0);
|
||||||
|
|
||||||
// TOOD(crbug.com/645993): this should be inherited from WebGL context's
|
// TODO(crbug.com/645993): this should be inherited from WebGL context's
|
||||||
// creation settings.
|
// creation settings.
|
||||||
const bool kPremultipliedAlpha = true;
|
const bool kPremultipliedAlpha = true;
|
||||||
const gfx::PointF uv_top_left(0.f, 0.f);
|
const gfx::PointF uv_top_left(0.f, 0.f);
|
||||||
|
@@ -76,7 +76,7 @@ WhenDeserializedAs(const InnerMatcher& inner_matcher) {
|
|||||||
} // namespace proto
|
} // namespace proto
|
||||||
|
|
||||||
MATCHER_P(EqualsProto, message, "") {
|
MATCHER_P(EqualsProto, message, "") {
|
||||||
// TOOD(ghc): This implementation assume protobuf serialization is
|
// TODO(ghc): This implementation assume protobuf serialization is
|
||||||
// deterministic, which is true in practice but technically not something that
|
// deterministic, which is true in practice but technically not something that
|
||||||
// code is supposed to rely on. However, it vastly simplifies the
|
// code is supposed to rely on. However, it vastly simplifies the
|
||||||
// implementation...
|
// implementation...
|
||||||
|
@@ -76,7 +76,7 @@ class NoHeapChecker {
|
|||||||
private:
|
private:
|
||||||
class NewDeleteCapture {
|
class NewDeleteCapture {
|
||||||
public:
|
public:
|
||||||
// TOOD(xiaofeng): Implement this for opensource protobuf.
|
// TODO(xiaofeng): Implement this for opensource protobuf.
|
||||||
void Hook() {}
|
void Hook() {}
|
||||||
void Unhook() {}
|
void Unhook() {}
|
||||||
int alloc_count() { return 0; }
|
int alloc_count() { return 0; }
|
||||||
|
@@ -309,7 +309,7 @@ class ThreadTimesTimelineMetric(timeline_based_metric.TimelineBasedMetric):
|
|||||||
for thread_results in thread_category_results.values():
|
for thread_results in thread_category_results.values():
|
||||||
if thread_results.name in self.results_to_report:
|
if thread_results.name in self.results_to_report:
|
||||||
thread_results.AddResults(num_intervals, interval_name, results)
|
thread_results.AddResults(num_intervals, interval_name, results)
|
||||||
# TOOD(nduca): When generic results objects are done, this special case
|
# TODO(nduca): When generic results objects are done, this special case
|
||||||
# can be replaced with a generic UI feature.
|
# can be replaced with a generic UI feature.
|
||||||
if thread_results.name in self.details_to_report:
|
if thread_results.name in self.details_to_report:
|
||||||
thread_results.AddDetailedResults(
|
thread_results.AddDetailedResults(
|
||||||
|
@@ -334,7 +334,7 @@ std::string GetLanguage(const std::string& locale) {
|
|||||||
return std::string(locale, 0, hyphen_pos);
|
return std::string(locale, 0, hyphen_pos);
|
||||||
}
|
}
|
||||||
|
|
||||||
// TOOD(jshin): revamp this function completely to use a more sytematic
|
// TODO(jshin): revamp this function completely to use a more sytematic
|
||||||
// and generic locale fallback based on ICU/CLDR.
|
// and generic locale fallback based on ICU/CLDR.
|
||||||
bool CheckAndResolveLocale(const std::string& locale,
|
bool CheckAndResolveLocale(const std::string& locale,
|
||||||
std::string* resolved_locale) {
|
std::string* resolved_locale) {
|
||||||
|
@@ -17,7 +17,7 @@
|
|||||||
* @param {boolean} writableOnly If true, only writable volumes are returned.
|
* @param {boolean} writableOnly If true, only writable volumes are returned.
|
||||||
* @param {Window=} opt_backgroundPage Window object of the background
|
* @param {Window=} opt_backgroundPage Window object of the background
|
||||||
* page. If this is specified, the class skips to get background page.
|
* page. If this is specified, the class skips to get background page.
|
||||||
* TOOD(hirono): Let all clients of the class pass the background page and
|
* TODO(hirono): Let all clients of the class pass the background page and
|
||||||
* make the argument not optional.
|
* make the argument not optional.
|
||||||
*/
|
*/
|
||||||
function VolumeManagerWrapper(allowedPaths, writableOnly, opt_backgroundPage) {
|
function VolumeManagerWrapper(allowedPaths, writableOnly, opt_backgroundPage) {
|
||||||
|
@@ -661,7 +661,7 @@ void BridgedNativeWidget::AcquireCapture() {
|
|||||||
// will reset the mouse cursor to an arrow. Asking the window for an update
|
// will reset the mouse cursor to an arrow. Asking the window for an update
|
||||||
// here will restore what we want. However, it can sometimes cause the cursor
|
// here will restore what we want. However, it can sometimes cause the cursor
|
||||||
// to flicker, once, on the initial mouseDown.
|
// to flicker, once, on the initial mouseDown.
|
||||||
// TOOD(tapted): Make this unnecessary by only asking for global mouse capture
|
// TODO(tapted): Make this unnecessary by only asking for global mouse capture
|
||||||
// for the cases that need it (e.g. menus, but not drag and drop).
|
// for the cases that need it (e.g. menus, but not drag and drop).
|
||||||
[window_ cursorUpdate:[NSApp currentEvent]];
|
[window_ cursorUpdate:[NSApp currentEvent]];
|
||||||
}
|
}
|
||||||
|
Reference in New Issue
Block a user