0

grit: qualify includes for shell_resources.h, virtual_driver_setup_resources.h, bluetooth_strings.h, app_shell_resources.h

BUG=401588
TBR=fake virtual printer dep

Review-Url: https://codereview.chromium.org/2714393004
Cr-Commit-Position: refs/heads/master@{#453586}
This commit is contained in:
thakis
2017-02-28 05:28:30 -08:00
committed by Commit bot
parent db10455e00
commit 9b5475a957
13 changed files with 14 additions and 12 deletions
chromecast
cloud_print
DEPS
virtual_driver
device/bluetooth
extensions/shell

@ -92,6 +92,7 @@ source_set("unittests") {
grit("resources") { grit("resources") {
source = "//chromecast/app/resources/shell_resources.grd" source = "//chromecast/app/resources/shell_resources.grd"
use_qualified_include = true
resource_ids = "//chromecast/app/resources/resource_ids" resource_ids = "//chromecast/app/resources/resource_ids"
@ -104,6 +105,8 @@ grit("resources") {
grit("chromecast_settings") { grit("chromecast_settings") {
source = "//chromecast/app/resources/chromecast_settings.grd" source = "//chromecast/app/resources/chromecast_settings.grd"
resource_ids = "//chromecast/app/resources/resource_ids" resource_ids = "//chromecast/app/resources/resource_ids"
# TODO(thakis): Consider removing this in favor of the default directory.
output_dir = "$root_gen_dir/chromecast_strings" output_dir = "$root_gen_dir/chromecast_strings"
outputs = [ outputs = [

@ -2,6 +2,7 @@ include_rules = [
"+cc/base/switches.h", "+cc/base/switches.h",
"+chromecast/common", "+chromecast/common",
"+chromecast/graphics", "+chromecast/graphics",
"+chromecast/app/resources/grit/shell_resources.h",
"+chromecast/media", "+chromecast/media",
"+chromecast/net", "+chromecast/net",
"+chromecast/service", "+chromecast/service",
@ -17,7 +18,6 @@ include_rules = [
"+gin/v8_initializer.h", "+gin/v8_initializer.h",
"+gpu/command_buffer/service/gpu_switches.h", "+gpu/command_buffer/service/gpu_switches.h",
"+grit/chromecast_settings.h", "+grit/chromecast_settings.h",
"+grit/shell_resources.h",
"+media/audio", "+media/audio",
"+media/base", "+media/base",
"+media/mojo", "+media/mojo",

@ -6,8 +6,8 @@
#include "base/macros.h" #include "base/macros.h"
#include "build/build_config.h" #include "build/build_config.h"
#include "chromecast/app/grit/shell_resources.h"
#include "content/public/browser/devtools_agent_host.h" #include "content/public/browser/devtools_agent_host.h"
#include "grit/shell_resources.h"
#include "ui/base/resource/resource_bundle.h" #include "ui/base/resource/resource_bundle.h"
namespace chromecast { namespace chromecast {

@ -1,5 +1,5 @@
include_rules = [ include_rules = [
"+chrome/common", "+chrome/common",
"+chrome/installer/launcher_support", "+chrome/installer/launcher_support",
"+grit", "+virtual_driver_setup_resources",
] ]

@ -59,7 +59,9 @@ grit("resources") {
visibility = [ ":*" ] visibility = [ ":*" ]
source = "virtual_driver_setup_resources.grd" source = "virtual_driver_setup_resources.grd"
use_qualified_include = true
# TODO(thakis): Consider removing this in favor of the default directory.
output_dir = "$root_gen_dir/virtual_driver_setup_resources" output_dir = "$root_gen_dir/virtual_driver_setup_resources"
outputs = [ outputs = [

@ -23,7 +23,7 @@
#include "cloud_print/common/win/install_utils.h" #include "cloud_print/common/win/install_utils.h"
#include "cloud_print/virtual_driver/win/virtual_driver_consts.h" #include "cloud_print/virtual_driver/win/virtual_driver_consts.h"
#include "cloud_print/virtual_driver/win/virtual_driver_helpers.h" #include "cloud_print/virtual_driver/win/virtual_driver_helpers.h"
#include "grit/virtual_driver_setup_resources.h" #include "virtual_driver_setup_resources/grit/virtual_driver_setup_resources.h"
#include <strsafe.h> // Must be after base headers to avoid deprecation #include <strsafe.h> // Must be after base headers to avoid deprecation
// warnings. // warnings.

@ -2,7 +2,6 @@ include_rules = [
"+chromeos/dbus", "+chromeos/dbus",
"+crypto", "+crypto",
"+dbus", "+dbus",
"+grit",
"+jni", "+jni",
"+net/base", "+net/base",
"+net/log", "+net/log",

@ -19,7 +19,7 @@
#include "device/bluetooth/bluetooth_remote_gatt_descriptor.h" #include "device/bluetooth/bluetooth_remote_gatt_descriptor.h"
#include "device/bluetooth/bluetooth_remote_gatt_service.h" #include "device/bluetooth/bluetooth_remote_gatt_service.h"
#include "device/bluetooth/string_util_icu.h" #include "device/bluetooth/string_util_icu.h"
#include "grit/bluetooth_strings.h" #include "device/bluetooth/strings/grit/bluetooth_strings.h"
#include "ui/base/l10n/l10n_util.h" #include "ui/base/l10n/l10n_util.h"
namespace device { namespace device {

@ -6,6 +6,7 @@ import("//tools/grit/grit_rule.gni")
grit("strings") { grit("strings") {
source = "../bluetooth_strings.grd" source = "../bluetooth_strings.grd"
use_qualified_include = true
outputs = [ outputs = [
"grit/bluetooth_strings.h", "grit/bluetooth_strings.h",
"bluetooth_strings_am.pak", "bluetooth_strings_am.pak",

@ -13,6 +13,7 @@ assert(enable_extensions)
grit("resources") { grit("resources") {
source = "app_shell_resources.grd" source = "app_shell_resources.grd"
use_qualified_include = true
outputs = [ outputs = [
"grit/app_shell_resources.h", "grit/app_shell_resources.h",
"app_shell_resources.pak", "app_shell_resources.pak",

@ -16,10 +16,5 @@ include_rules = [
# the embedder before being used by the extension. # the embedder before being used by the extension.
"+components/storage_monitor", "+components/storage_monitor",
# Only allow app_shell and extensions resources, not general Chrome ones.
"-grit",
"+grit/app_shell_resources.h",
"+grit/extensions_resources.h",
# Real DEPS go in subdirectories, for example extensions/shell/browser/DEPS. # Real DEPS go in subdirectories, for example extensions/shell/browser/DEPS.
] ]

@ -1,5 +1,6 @@
include_rules = [ include_rules = [
"+components/nacl/common", "+components/nacl/common",
"+components/nacl/renderer/plugin", "+components/nacl/renderer/plugin",
"+extensions/shell/grit",
"+ppapi", "+ppapi",
] ]

@ -27,7 +27,7 @@
#include "extensions/shell/common/api/shell_behavior_features.h" #include "extensions/shell/common/api/shell_behavior_features.h"
#include "extensions/shell/common/api/shell_manifest_features.h" #include "extensions/shell/common/api/shell_manifest_features.h"
#include "extensions/shell/common/api/shell_permission_features.h" #include "extensions/shell/common/api/shell_permission_features.h"
#include "grit/app_shell_resources.h" #include "extensions/shell/grit/app_shell_resources.h"
namespace extensions { namespace extensions {