chromium/src
0
Fork 0
Code Activity

Check for first frame in CreateImageBitmap

Browse Source 
HTMLVideoElement::CreateImageBitmap is currently rejecting valid calls,
when we have an available first frame, but the ready state hasn't been
updated.

This CL updates CreateImageBitmap to check for a valid frame, which
amounts to having a first frame available.

This CL also updates some WPTs to use preload=auto, to allow video
elements to load without being visible, and yield expected results when
calling CreateImageBitmap.

Bug: 1090960
Change-Id: I21302a9c3433bf8218a75c3f6918bc20f4d36ca3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231453
Auto-Submit: Thomas Guilbert <tguilbert@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775670}
This commit is contained in:
Thomas Guilbert
2020-06-05 18:34:09 +00:00
committed by Commit Bot
parent f7456118b2
commit 9c24e63c71
2 changed files with 4 additions and 1 deletions
third_party/blink
renderer
core
html
media
html_video_element.cc
web_tests
external
wpt
html
canvas
resources
canvas-tests.js

2
third_party/blink/renderer/core/html/media/html_video_element.cc vendored

@ -654,7 +654,7 @@ ScriptPromise HTMLVideoElement::CreateImageBitmap(
"The provided element has not retrieved data.");
return ScriptPromise();
}
if (getReadyState() <= HTMLMediaElement::kHaveMetadata) {
if (!HasAvailableVideoFrame()) {
exception_state.ThrowDOMException(
DOMExceptionCode::kInvalidStateError,
"The provided element's player has no current data.");

3
third_party/blink/web_tests/external/wpt/html/canvas/resources/canvas-tests.js vendored

@ -144,6 +144,7 @@ function forEachCanvasSource(crossOriginUrl, sameOriginUrl, callback) {
return new Promise((resolve, reject) => {
const video = document.createElement("video");
video.oncanplaythrough = () => resolve(video);
video.preload = "auto";
video.onerror = reject;
video.src = getVideoURI(crossOriginUrl + "/media/movie_300");
});
@ -156,6 +157,7 @@ function forEachCanvasSource(crossOriginUrl, sameOriginUrl, callback) {
return new Promise((resolve, reject) => {
const video = document.createElement("video");
video.oncanplaythrough = () => resolve(video);
video.preload = "auto";
video.onerror = reject;
video.src = "/common/redirect.py?location=" + getVideoURI(crossOriginUrl + "/media/movie_300");
});
@ -168,6 +170,7 @@ function forEachCanvasSource(crossOriginUrl, sameOriginUrl, callback) {
return new Promise((resolve, reject) => {
const video = document.createElement("video");
video.oncanplaythrough = () => resolve(video);
video.preload = "auto";
video.onerror = reject;
video.src = crossOriginUrl + "/common/redirect.py?location=" + getVideoURI(sameOriginUrl + "/media/movie_300");
});