0

Add host symlinks for microdump_stackwalk, minidump_*

It's not obvious how to build non-default-toolchain targets in ninja.
Creating a wrapper alleviates the problem.

BUG=none

Review URL: https://codereview.chromium.org/1822743002

Cr-Commit-Position: refs/heads/master@{#382611}
This commit is contained in:
agrieve
2016-03-22 11:08:07 -07:00
committed by Commit bot
parent 99a69c51e9
commit a218d2dade

@@ -51,7 +51,8 @@ config("sender_config") {
# {micro,mini}dump_stackwalk and minidump_dump are tool-type executables
# that do not build on Windows.
if (!is_win && current_toolchain == host_toolchain) {
if (!is_win) {
if (current_toolchain == host_toolchain) {
# Contains the code shared by both {micro,mini}dump_stackwalk.
static_library("stackwalk_common") {
# Always want these files included regardless of platform.
@@ -213,11 +214,24 @@ if (!is_win && current_toolchain == host_toolchain) {
"//build/config/sanitizers:deps",
]
}
} else {
# Aliases for convenience.
binary_symlink("microdump_stackwalk") {
binary_label = ":dump_syms($host_toolchain)"
}
binary_symlink("minidump_stackwalk") {
binary_label = ":dump_syms($host_toolchain)"
}
binary_symlink("minidump_dump") {
binary_label = ":$target_name($host_toolchain)"
}
}
}
# Mac --------------------------------------------------------------------------
if (current_toolchain == host_toolchain && is_mac) {
if (is_mac) {
if (current_toolchain == host_toolchain) {
# TODO(GYP) This should be only 64-bit on Mac. From .gypi:
# Like ld, dump_syms needs to operate on enough data that it may
# actually need to be able to address more than 4GB. Use x86_64.
@@ -296,6 +310,14 @@ if (current_toolchain == host_toolchain && is_mac) {
"//build/config/sanitizers:deps",
]
}
} else {
binary_symlink("dump_syms") {
binary_label = ":$target_name($host_toolchain)"
}
binary_symlink("symupload") {
binary_label = ":$target_name($host_toolchain)"
}
}
}
if (is_mac) {