chromium/src
0
Fork 0
Code Activity

Mahi: Update accessible names for some UI components

Browse Source 
Update accessible names for the textfield in the menu card and the learn
more link in the panel.

Fixed: b:356165820, b:356692319
Change-Id: Icd1767cfa61b4149c4e7a4ad743574feb596f50c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5783627
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Commit-Queue: Andre Le <leandre@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1342343}
This commit is contained in:
Andre Le
2024-08-15 17:37:44 +00:00
committed by Chromium LUCI CQ
parent b7e514b714
commit a797dfa100
4 changed files with 8 additions and 0 deletions

3
ash/ash_strings.grd

@ -5384,6 +5384,9 @@ No devices connected.
<message name="IDS_ASH_MAHI_RETRY_LINK_CLICK_ACTIVATION_ACCESSIBLE_NAME" desc="Text for the accessible name that announced when the retry link is clicked"> <message name="IDS_ASH_MAHI_RETRY_LINK_CLICK_ACTIVATION_ACCESSIBLE_NAME" desc="Text for the accessible name that announced when the retry link is clicked">
Retry link activated Retry link activated
</message> </message>
<message name="IDS_ASH_MAHI_LEARN_MORE_LINK_ACCESSIBLE_NAME" desc="Text for the accessible name that announced when the learn more button is focused">
Learn more link. Redirect to the browser when activated
</message>
<message name="IDS_ASH_MAHI_LEARN_MORE_CLICK_ACTIVATION_ACCESSIBLE_NAME" desc="Text for the accessible name that announced when the learn more button is clicked"> <message name="IDS_ASH_MAHI_LEARN_MORE_CLICK_ACTIVATION_ACCESSIBLE_NAME" desc="Text for the accessible name that announced when the learn more button is clicked">
Opened learn more link in the browser Opened learn more link in the browser
</message> </message>

1
ash/ash_strings_grd/IDS_ASH_MAHI_LEARN_MORE_LINK_ACCESSIBLE_NAME.png.sha1 Normal file

@ -0,0 +1 @@
7e04b9d8208601cefd7f221d72c1d37a96804dab

2
ash/system/mahi/mahi_panel_view.cc

@ -718,6 +718,8 @@ MahiPanelView::MahiPanelView(MahiUiController* ui_controller)
views::Builder<views::Link>() views::Builder<views::Link>()
.SetText(l10n_util::GetStringUTF16( .SetText(l10n_util::GetStringUTF16(
IDS_ASH_MAHI_LEARN_MORE_LINK_LABEL_TEXT)) IDS_ASH_MAHI_LEARN_MORE_LINK_LABEL_TEXT))
.SetAccessibleName(l10n_util::GetStringUTF16(
IDS_ASH_MAHI_LEARN_MORE_LINK_ACCESSIBLE_NAME))
.SetCallback(base::BindRepeating( .SetCallback(base::BindRepeating(
&MahiPanelView::OnLearnMoreLinkClicked, &MahiPanelView::OnLearnMoreLinkClicked,
weak_ptr_factory_.GetWeakPtr())) weak_ptr_factory_.GetWeakPtr()))

2
chrome/browser/ui/views/mahi/mahi_menu_view.cc

@ -395,6 +395,8 @@ std::unique_ptr<views::FlexLayoutView> MahiMenuView::CreateInputContainer() {
.SetTextInputType(ui::TEXT_INPUT_TYPE_TEXT) .SetTextInputType(ui::TEXT_INPUT_TYPE_TEXT)
.SetPlaceholderText( .SetPlaceholderText(
l10n_util::GetStringUTF16(IDS_MAHI_MENU_INPUT_TEXTHOLDER)) l10n_util::GetStringUTF16(IDS_MAHI_MENU_INPUT_TEXTHOLDER))
.SetAccessibleName(
l10n_util::GetStringUTF16(IDS_MAHI_MENU_INPUT_TEXTHOLDER))
.SetProperty( .SetProperty(
views::kFlexBehaviorKey, views::kFlexBehaviorKey,
views::FlexSpecification(views::FlexSpecification( views::FlexSpecification(views::FlexSpecification(