chromium/src
0
Fork 0
Code Activity

Remove unexpected user gesture creation in a test.

Browse Source 
Bug: 902517
Change-Id: Ie5121198b9ce41e2d72ea696570b05de0071aafa
Reviewed-on: https://chromium-review.googlesource.com/c/1321156
Reviewed-by: Camille Lamy <clamy@chromium.org>
Commit-Queue: Mustaq Ahmed <mustaq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606505}
This commit is contained in:
Mustaq Ahmed
2018-11-08 17:07:04 +00:00
committed by Commit Bot
parent 6fbae55578
commit a88adf774d
1 changed files with 12 additions and 10 deletions

22
content/browser/navigation_browsertest.cc

@@ -1138,11 +1138,12 @@ IN_PROC_BROWSER_TEST_F(NavigationBrowserTest, HistoryBackInBeforeUnload) {
GURL url_2(embedded_test_server()->GetURL("/title2.html")); GURL url_2(embedded_test_server()->GetURL("/title2.html"));
EXPECT_TRUE(NavigateToURL(shell(), url_1)); EXPECT_TRUE(NavigateToURL(shell(), url_1));
EXPECT_TRUE(ExecuteScript(shell()->web_contents(), EXPECT_TRUE(
"onbeforeunload = function() {" ExecuteScriptWithoutUserGesture(shell()->web_contents(),
" history.pushState({}, null, '/');" "onbeforeunload = function() {"
" history.back();" " history.pushState({}, null, '/');"
"};")); " history.back();"
"};"));
EXPECT_TRUE(NavigateToURL(shell(), url_2)); EXPECT_TRUE(NavigateToURL(shell(), url_2));
} }
@@ -1156,11 +1157,12 @@ IN_PROC_BROWSER_TEST_F(NavigationBrowserTest,
GURL url_2(embedded_test_server()->GetURL("/title2.html")); GURL url_2(embedded_test_server()->GetURL("/title2.html"));
EXPECT_TRUE(NavigateToURL(shell(), url_1)); EXPECT_TRUE(NavigateToURL(shell(), url_1));
EXPECT_TRUE(ExecuteScript(shell()->web_contents(), EXPECT_TRUE(
"onbeforeunload = function() {" ExecuteScriptWithoutUserGesture(shell()->web_contents(),
" history.pushState({}, null, '/');" "onbeforeunload = function() {"
" setTimeout(()=>history.back());" " history.pushState({}, null, '/');"
"};")); " setTimeout(()=>history.back());"
"};"));
TestNavigationManager navigation(shell()->web_contents(), url_2); TestNavigationManager navigation(shell()->web_contents(), url_2);
auto ipc_observer = base::MakeRefCounted<BrowserMessageObserver>( auto ipc_observer = base::MakeRefCounted<BrowserMessageObserver>(
ViewMsgStart, ViewHostMsg_GoToEntryAtOffset::ID); ViewMsgStart, ViewHostMsg_GoToEntryAtOffset::ID);