chromium/src
0
Fork 0
Code Activity

Revert "Add DumpWithoutCrashing() for Vulkan features"

Browse Source 
This reverts commit 6976fd65c2.

Reason for revert: Change is no longer needed to collect data. Will
leave unreverted on M134 branch to get stable channel data but we
don't need it in M135+

Original change's description:
> Add DumpWithoutCrashing() for Vulkan features
>
> Check VkPhysicalDeviceFeatures in the Ganesh/Vulkan path that are
> checked in Graphite/Dawn/Vulkan path. If any of the features aren't
> supported then DumpWithoutCrashing() with feature data stored in a crash
> key. This is to help track down why there are more Vulkan users running
> Ganesh/Vulkan than Graphite/Dawn/Vulkan.
>
> Bug: 381535049
> Change-Id: Ib4880438ac8dedc3514e2c2f36e1c1a6ae7df041
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6157279
> Reviewed-by: Colin Blundell <blundell@chromium.org>
> Commit-Queue: Kyle Charbonneau <kylechar@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1404300}

Bug: 381535049, 395038359
Change-Id: Ic00ccddaaa3c00a2f16afcbb2451354690ae387a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6254698
Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Kyle Charbonneau <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1419256}
This commit is contained in:
Kyle Charbonneau
2025-02-12 06:30:40 -08:00
committed by Chromium LUCI CQ
parent 066ca56f58
commit a9ad9c5155
1 changed files with 0 additions and 30 deletions

30
gpu/ipc/service/gpu_init.cc

@@ -26,7 +26,6 @@
#include "build/build_config.h" #include "build/build_config.h"
#include "build/chromecast_buildflags.h" #include "build/chromecast_buildflags.h"
#include "build/chromeos_buildflags.h" #include "build/chromeos_buildflags.h"
#include "components/crash/core/common/crash_key.h"
#include "gpu/command_buffer/service/gpu_switches.h" #include "gpu/command_buffer/service/gpu_switches.h"
#include "gpu/config/gpu_driver_bug_list.h" #include "gpu/config/gpu_driver_bug_list.h"
#include "gpu/config/gpu_driver_bug_workaround_type.h" #include "gpu/config/gpu_driver_bug_workaround_type.h"
@@ -1257,35 +1256,6 @@ bool GpuInit::InitializeVulkan() {
return false; return false;
} }
#if BUILDFLAG(IS_ANDROID)
// Check if any VkPhysicalDeviceFeatures that Dawn/Vulkan requires are not
// available when Ganesh/Vulkan is used.
// TODO(crbug.com/381535049): Remove after collecting data to see if any of
// these features explain discrepancies in Vulkan user counts.
if (auto& features = vulkan_info.physical_devices.front().features;
!features.robustBufferAccess || !features.textureCompressionETC2 ||
!features.textureCompressionASTC_LDR || !features.depthBiasClamp ||
!features.fragmentStoresAndAtomics || !features.fullDrawIndexUint32 ||
!features.imageCubeArray || !features.independentBlend ||
!features.sampleRateShading) {
static crash_reporter::CrashKeyString<256> crash_key(
"vulkan-physical-device-features");
std::string feature_str = base::StringPrintf(
"robustBufferAccess=%d textureCompressionETC2=%d "
"textureCompressionASTC_LDR=%d depthBiasClamp=%d "
"fragmentStoresAndAtomics=%d fullDrawIndexUint32=%d "
"imageCubeArray=%d independentBlend=%d sampleRateShading=%d",
features.robustBufferAccess, features.textureCompressionETC2,
features.textureCompressionASTC_LDR, features.depthBiasClamp,
features.fragmentStoresAndAtomics, features.fullDrawIndexUint32,
features.imageCubeArray, features.independentBlend,
features.sampleRateShading);
crash_reporter::ScopedCrashKeyString crash_key_scope(&crash_key,
feature_str);
base::debug::DumpWithoutCrashing();
}
#endif
gpu_info_.hardware_supports_vulkan = true; gpu_info_.hardware_supports_vulkan = true;
gpu_info_.vulkan_info = gpu_info_.vulkan_info =
vulkan_implementation_->GetVulkanInstance()->vulkan_info(); vulkan_implementation_->GetVulkanInstance()->vulkan_info();