chromium/src
0
Fork 0
Code Activity

Fix -Wloop-analysis: rlz/

Browse Source 
This has no effect on performance; it makes explicit a lifetime
extension of a temp that was already occurring.

Bug: 1223264
Change-Id: Idb1ec8d46f3117ec2257ec70453009de23e062db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3023462
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#901018}
This commit is contained in:
Peter Kasting
2021-07-13 15:31:39 +00:00
committed by Chromium LUCI CQ
parent 57f2b68b60
commit aa5329f773
1 changed files with 1 additions and 1 deletions

2
rlz/chromeos/lib/rlz_value_store_chromeos.cc

@ -163,7 +163,7 @@ absl::optional<base::Value> CopyWithoutEmptyChildren(const base::Value& value) {
case base::Value::Type::DICTIONARY: { case base::Value::Type::DICTIONARY: {
base::Value::DictStorage storage; base::Value::DictStorage storage;
for (const auto& key_value_pair : value.DictItems()) { for (const auto key_value_pair : value.DictItems()) {
absl::optional<base::Value> item_copy = absl::optional<base::Value> item_copy =
CopyWithoutEmptyChildren(key_value_pair.second); CopyWithoutEmptyChildren(key_value_pair.second);
if (item_copy) if (item_copy)