From ae9909f29e2d6cc896213cae35e5526b5febea1e Mon Sep 17 00:00:00 2001 From: Antonio Sartori <antoniosartori@chromium.org> Date: Wed, 7 May 2025 02:48:41 -0700 Subject: [PATCH] [Gardener] Disable flaky HeadlessProtocolTests on Mac These two tests are flaky on Mac. Bug: 352304682 Change-Id: I3893b2d7139b6b12fcd807b3da1d3ec88b4555ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6517878 Auto-Submit: Antonio Sartori <antoniosartori@chromium.org> Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Owners-Override: Antonio Sartori <antoniosartori@chromium.org> Reviewed-by: Sayed Elabady <elabadysayed@chromium.org> Commit-Queue: Sayed Elabady <elabadysayed@chromium.org> Cr-Commit-Position: refs/heads/main@{#1456834} --- headless/test/headless_protocol_browsertest.cc | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/headless/test/headless_protocol_browsertest.cc b/headless/test/headless_protocol_browsertest.cc index 7344a1dcbd861..2b675b6732a0a 100644 --- a/headless/test/headless_protocol_browsertest.cc +++ b/headless/test/headless_protocol_browsertest.cc @@ -290,12 +290,24 @@ HEADLESS_PROTOCOL_TEST(VirtualTimeHistoryNavigationSameDoc, "emulation/virtual-time-history-navigation-same-doc.js") HEADLESS_PROTOCOL_TEST(VirtualTimeSVG, "emulation/virtual-time-svg.js") -HEADLESS_PROTOCOL_TEST(VirtualTimeWorkerBasic, +// Flaky on Mac. TODO(crbug.com/352304682): Re-enable. +#if BUILDFLAG(IS_MAC) +#define MAYBE_VirtualTimeWorkerBasic DISABLED_VirtualTimeWorkerBasic +#else +#define MAYBE_VirtualTimeWorkerBasic VirtualTimeWorkerBasic +#endif +HEADLESS_PROTOCOL_TEST(MAYBE_VirtualTimeWorkerBasic, "emulation/virtual-time-worker-basic.js") HEADLESS_PROTOCOL_TEST(VirtualTimeWorkerLockstep, "emulation/virtual-time-worker-lockstep.js") -HEADLESS_PROTOCOL_TEST(VirtualTimeWorkerFetch, +// Flaky on Mac. TODO(crbug.com/352304682): Re-enable. +#if BUILDFLAG(IS_MAC) +#define MAYBE_VirtualTimeWorkerFetch DISABLED_VirtualTimeWorkerFetch +#else +#define MAYBE_VirtualTimeWorkerFetch VirtualTimeWorkerFetch +#endif +HEADLESS_PROTOCOL_TEST(MAYBE_VirtualTimeWorkerFetch, "emulation/virtual-time-worker-fetch.js") HEADLESS_PROTOCOL_TEST(VirtualTimeWorkerTerminate, "emulation/virtual-time-worker-terminate.js")